From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 108D14642F for ; Tue, 8 Apr 2025 09:46:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 082614027F; Tue, 8 Apr 2025 09:46:56 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) by mails.dpdk.org (Postfix) with ESMTP id 2277E40E48 for ; Tue, 8 Apr 2025 09:46:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n/gMMbda2Hp48HU1mxKF9heRCflATdCj5freuiQf3iPKAlteLpGd9GB+yo96ICq7UabwfcIVOG8c4AYuBZcUxcwBm+NZrvbyD3saq/oImrEEobqUbfQzgy4TE6iN6t+D6GnirJ3cctHC6ywyo5k5IL9fxlhuZAkYfhzo8WuPMszaqZDAKJut0b/CiqvFvkAzggrc4WIJhKxZv7sUoHoRwyvb4XB9V4vkpo8Z1CEHPLl7vym23N0Pjj5hA5JdNLA00u05o+oDSn2CX9CM68ZsWW1DKRfel7Q1s5ozk/YAo1LQgTZGaJf+TFHmEs4gxx9tH6ObPF3D6zBtDLaSYtTXnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S9/n2eBcT1gsmxc6TvHBmwzWmvDOibmsL4/Zz4uBe28=; b=EL2MfS6DRTKNMS30xv3uGHt91JrqvHwiV5YE4+io1noktPZfnJ5KZjBK0PPVajkXuJMAfDP8sB3gHpc7XKl6hdL5eyFcFMypJ5NG9GEDzWfNdQsTpYLvrOy6BB+ZKIYclJQivUOJhXJ4/kltIZNEAPwd1gqxJ9kUKp8Ds3NzG+7aeKcglgxqolgDrPKaJXyA43vSwKe6yc17ndnTHwjjunu8gBBB86jMUltlvYr65lxhHoSNz7s4dB0juOjb/gbzRh3rxyI9M8dEneczmrtZcb5O3uksUz4G/S05UC9YJYOMBEBpId2IPKo7NgyOCHK+DbdfjWueVeWgo4r+LdsoxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9/n2eBcT1gsmxc6TvHBmwzWmvDOibmsL4/Zz4uBe28=; b=hXDRwEU+KQRiD1C7E1LvidEuUcgblPbQPsh1dSqEQQaSPUeGWzLnq9RmjkJJ9u7ezOJOfFHaOz30C2HZ/KcLAc2sMgVx3RSZeoJPmKeIfpP8ofQUUosZ2Fb95s0JtB7n19MVnq2mblUfrpHtOKGZfBqVyRMNcrtNL1GXifE9zrKeqG6fpZ89yGL4rStRFsb8iVZo4dXwhSRyPWqN1N7T88bCP7Id3x8ugzzyQqekVP4K7Nl2DTbE0ZgUQIMKFVCISsLCPlANj2oVGEY3gu81dP8SifFeWe/2Oy867dbWWRI4rFc0F7Kh5Dc4FJjlUDnhaQxk6sDfXj4b7wwJn8KAWQ== Received: from SJ0PR03CA0193.namprd03.prod.outlook.com (2603:10b6:a03:2ef::18) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 07:46:50 +0000 Received: from SJ1PEPF000023CB.namprd02.prod.outlook.com (2603:10b6:a03:2ef:cafe::9a) by SJ0PR03CA0193.outlook.office365.com (2603:10b6:a03:2ef::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.33 via Frontend Transport; Tue, 8 Apr 2025 07:46:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023CB.mail.protection.outlook.com (10.167.244.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 07:46:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 00:46:35 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 00:46:33 -0700 From: Xueming Li To: Chengwen Feng CC: Xueming Li , dpdk stable Subject: patch 'app/testpmd: avoid crash in DCB config' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 15:44:31 +0800 Message-ID: <20250408074515.361046-7-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408074515.361046-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408074515.361046-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023CB:EE_|DM6PR12MB4108:EE_ X-MS-Office365-Filtering-Correlation-Id: b90e125d-6367-4754-f2c7-08dd7671853b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PS7/y/4PVoJPg2yXEOyXJ3V84uuBX62vig7oHsaM0bqZ+JL5fPzdJKu9rdxO?= =?us-ascii?Q?pjUSBb4MHIUnhHcOfhrqCVqMUbkhX+mIn6upwMC8zQ8kYvq1Av4V9shvHlv8?= =?us-ascii?Q?DBVTPjGikFvpObZ3apzgW2cJ3rkqeVVNJLUpa/Uh44New8EES8Mh5gfFCT0p?= =?us-ascii?Q?PCOWSqEE6jgsX478iyCYOpmGztXSiPcQUr0IuDnD78lznPwywynfXY443MHc?= =?us-ascii?Q?aCZ6RuDz4gkejuXOPsBdnbYtOMqoSDnIQeGZX0euEjqdQY6FjJq04ghMGEjt?= =?us-ascii?Q?ji0GJi8Wc7HLk+PREAZw9YwCLSzqr0xerDgwGFP/zaFABOmPftOUGiaVGbUv?= =?us-ascii?Q?ivYqpLXd0ci8Us4g/M/mJzqS68RycPY7CIe33QT3gFMzyuscZCusCaNZYtnm?= =?us-ascii?Q?SgRIMCo04n9o5bK/AD3Q64L+OVf5BKp3ZHVSoRdrWr07VsAIUWegGNi6pxU/?= =?us-ascii?Q?XhiyC7L5Y40u/6oQLerlKNacwCfDN+3JEMiZ7NqggOszgjEdApPA9C8ekkzJ?= =?us-ascii?Q?efYYqqZr2wAbCPUfF/l0aC5pQMOW6H0kupAJP97Qd2maKcsk84Jerd1D9DJo?= =?us-ascii?Q?zBdFp1y+OUv5hyqeNoOrfKkCCMg0XKEX+sHVOm7P8V6bsacJfNOxqaFCjL1l?= =?us-ascii?Q?rAbeQwmVgRWwjUt0skM1LG4sp7e+75Ito3GakMNhZqKCCY1Z+npwttNZP13M?= =?us-ascii?Q?7Dn5dJedHy5TViwjFRVgaeCXM0dhny2rq7gBrNVcrqDcaOsB8MyymkzwiWV+?= =?us-ascii?Q?LFHWJrJuAT6KR3ulDgX1MdHU2csfXDR1sjq+NRTmKUd4//Ab+yHWXyjjLX7S?= =?us-ascii?Q?65HDelmCLbIPDdsTsqOYi3uhWDL+vZs8esOYHBpzhTfgkbDQtDWnybLOl5HG?= =?us-ascii?Q?rgrAr1uT7T/0FczhDIq6gqoyow0taMlkANwO33FnwLnsolH7ZbMa7u98A2Te?= =?us-ascii?Q?ZTp5mBAqcdLTpiEgHQ9HS5bHtD8BwTCzPOJdTsg2NXAutJxQWXA35bov2qag?= =?us-ascii?Q?scXyEPJ5LIW11PrcyHBnBGajqb94EFMTjTWk9DJ8LMKZqSyB+vo9UbcTlT+z?= =?us-ascii?Q?TQMEq4JsCfQBnAnHuyeSqBVViefN7AZLfjWZq9qwZslxPvvtMfdjl5wFLXii?= =?us-ascii?Q?GWgl5mN/dEi1NgYLOFujjRFrZm8zzKu81xejUIX7c9++7WNzsGkLwjDpeSKK?= =?us-ascii?Q?9NxnnMSGCZPZIAsiNS1fgT+iY3olm0agEo9S8hm5BclH/2lbigr5yPov1qGI?= =?us-ascii?Q?VPFG7FiLPp27uGh7RwrO/00FOqTu1q+xOEJqzpEwjemNnwuGmUrgBahZPMbj?= =?us-ascii?Q?KaIfDdpu3TWIVETH0jpgUWkmErYqLpdGjMyb2ARSg5KXlcnUzWJhHIzW9Uij?= =?us-ascii?Q?JADJF9P8U54ftpUmCX4sX9ZZvSIOiS19BMv0Kn6pMXsl3GgkKh3gmiHCfT2n?= =?us-ascii?Q?5Z8/5GqyTFWAbhqKAXR5FTP8igkj+GtRxjlwwWnvtfC35Y3ZTikqpT2RSplE?= =?us-ascii?Q?gzOPkJjTuyvkFpU=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 07:46:49.5002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b90e125d-6367-4754-f2c7-08dd7671853b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023CB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=afcc3d93754bba06e1797f4e3ab2f4b88c5d9cf4 Thanks. Xueming Li --- >From afcc3d93754bba06e1797f4e3ab2f4b88c5d9cf4 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 20 Feb 2025 15:06:51 +0800 Subject: [PATCH] app/testpmd: avoid crash in DCB config Cc: Xueming Li [ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ] The "port config dcb ..." command will segment fault when input with invalid port id, this patch fixes it. Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control") Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index bf6794ee1d..c150315eb8 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3120,6 +3120,9 @@ cmd_config_dcb_parsed(void *parsed_result, uint8_t pfc_en; int ret; + if (port_id_is_invalid(port_id, ENABLED_WARN)) + return; + port = &ports[port_id]; /** Check if the port is not started **/ if (port->port_status != RTE_PORT_STOPPED) { @@ -6322,6 +6325,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result, int rx_fc_enable, tx_fc_enable; int ret; + if (port_id_is_invalid(res->port_id, ENABLED_WARN)) + return; + /* * Rx on/off, flow control is enabled/disabled on RX side. This can indicate * the RTE_ETH_FC_TX_PAUSE, Transmit pause frame at the Rx side. -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.228737283 +0800 +++ 0006-app-testpmd-avoid-crash-in-DCB-config.patch 2025-04-08 15:39:05.866436601 +0800 @@ -1 +1 @@ -From d646e219b34ffc4d531f3703fc317e7cff9a25ae Mon Sep 17 00:00:00 2001 +From afcc3d93754bba06e1797f4e3ab2f4b88c5d9cf4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index 6b0d8af4f6..6ca3eedb92 100644 +index bf6794ee1d..c150315eb8 100644 @@ -21 +23 @@ -@@ -3462,6 +3462,9 @@ cmd_config_dcb_parsed(void *parsed_result, +@@ -3120,6 +3120,9 @@ cmd_config_dcb_parsed(void *parsed_result, @@ -31 +33 @@ -@@ -6664,6 +6667,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result, +@@ -6322,6 +6325,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,