From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27F5146532 for ; Tue, 8 Apr 2025 10:04:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 210C840E5A; Tue, 8 Apr 2025 10:04:38 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2069.outbound.protection.outlook.com [40.107.237.69]) by mails.dpdk.org (Postfix) with ESMTP id 9DD7D40E5A for ; Tue, 8 Apr 2025 10:04:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ukzSkAmnyYS/qf94n18ybNZ/5FroYVkCfogllmipUqaP4JLinxTYU9dBSdgxGQhKd983cQvIulJahEeywQ2TTY32FZPBh14tjZV6AOabGDIQR3yIPXhYw9l4Fe0KuTOVdtFOuCvvzTJfdBAGr3OzQNYc221Zaqs43c3zfssDDU8uCXxhmE4c6TTTe5H2UsJ7VTaeHu3klvqEGoSw6ATuGBbw54bOqgdEXiciLDyIMzyiUCyouiGEhjOpKEn8NmN2E4qXAHeGrgFaQVXbygSNq5Cw/LAuowE7oprl/LehhVCIDRRWfjCc/rMPIKdaybbtlXFLxtVtMzH/DpOj+R17RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfVPl/wlVv9qr2/Mjm2HUUU+JAFBJTrtf7i/w+QCALE=; b=zMk7dMGdhKjexnfMZyrrOxrkAcQ/YS5Btt6UZxH4HZxDpTvJ+LThKdEuPSVNggAn5slCaS5dFk01geUKWULKvI7oHhWn/o2cz983OV0N0gviShhmAz0A8HTgc7cPFgQ7AjKB3C+6rz4qLsM9jqDeaeJv3YkvJdK7Tp6SdX7gnTCgYYxz5a5GDP9osGwlDBVb6GSz3wB7LXs7bc8J3nABRt236tZnQuV6P170BJaoRgzgK0GtjrdXNY7S0W1L8vQKQsEX3zDvg/DGbAG+FcQO4e0tlWG5MqxwHD2JHOBwmFpxcNaZc5SOyaPWg7hUSYssMWC9a5u88XDu8NgjKsGHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LfVPl/wlVv9qr2/Mjm2HUUU+JAFBJTrtf7i/w+QCALE=; b=gwcR5ItEyv64Fzu+MTbDSsR1MQk9KIF+ILZ6VXFj3p26U9R/V0P3h8f6o+g3829Zv7xdxocjGXq8xrsdHZbMUlzkPBDTSfxWnuAyhze7akXk0Sl/I8zj1whFVj89eb+h/cE4RVaaA5WpaqoGJtLPaoMIXsMNhmkiWky8KLzuTUxKCZGz0x5ynavtEHnxF9yj9TKY6bYcAO0cCUPBYZ4EhPpIMxGjWMgY0ZJKzJuHVkvQNdozEmxBjd7o9PTXlTWfAin/o97dNlVjYyxvusWB6ezh31q2X2EhrkWZLc3lsYSH13OcYhxjORIA4BM1g2i8xWMZdddiyOw5HAYk8BZrYg== Received: from PH7P221CA0072.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:328::10) by SJ1PR12MB6340.namprd12.prod.outlook.com (2603:10b6:a03:453::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 08:04:34 +0000 Received: from BY1PEPF0001AE16.namprd04.prod.outlook.com (2603:10b6:510:328:cafe::34) by PH7P221CA0072.outlook.office365.com (2603:10b6:510:328::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Tue, 8 Apr 2025 08:04:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE16.mail.protection.outlook.com (10.167.242.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 08:04:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:04:24 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:04:18 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: Xueming Li , Akhil Goyal , "dpdk stable" Subject: patch 'crypto/openssl: validate incorrect RSA signature' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:01:52 +0800 Message-ID: <20250408080214.371154-14-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408080214.371154-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408080214.371154-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE16:EE_|SJ1PR12MB6340:EE_ X-MS-Office365-Filtering-Correlation-Id: 13a772f5-1408-4fd6-41ff-08dd7673ffd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/MV2h7yGHfOOQzAKmgww4xUY8I01HcGfoVYDrBhmPv0QtKLoMtzsGSTvLiQu?= =?us-ascii?Q?EtwTNPX+InGlvUemrjZTCrg2xvRd8yfLbRkafxukHB0H+NyrSo0srSBsV6sB?= =?us-ascii?Q?SmfzRVyJdqAFcxjHSOXDjgAinjk0FdooO5X04ZPCEXkYYMDCbnK0agSX4yYT?= =?us-ascii?Q?ZrsAibPu3g88VuY0MtB+1ur2hzu9Va8GMm565KJHVt4MkS2LEAdSR/OhjHfc?= =?us-ascii?Q?E3f86VOEnVG5MaL2kARK5w/JJg3qqpR2j/eLxvJlWct3J5JORx+4bJjOKOTv?= =?us-ascii?Q?We5aGpGI7C7pl4dQJSui26piwvmCLxk4Gp4ggO/157cT0atUrMoDydMAe3YJ?= =?us-ascii?Q?hfI+Fsi14uzJO0FBN9E3tz5B454TiZBdo4fgbsaxk0NqRvyOfjkYyvAvixah?= =?us-ascii?Q?M/ozbsC9L4UP+lg8KrwAWiM9SbNTJDhpH4jnTdfLDoGQbc9VCSaYhPxrCDEw?= =?us-ascii?Q?qr/sdOQ8KNKZV9HQCfGcgzfu/Ya7lk1QsYym3VMFhRdAuSnGW9dp7RFU1JCV?= =?us-ascii?Q?DNRDR1+lvnrPab/6bizDHWcYHH2q2FQM9MMSKxlnHNR1Da4oAWcE8S0GsJRf?= =?us-ascii?Q?xUIcQOVS1+y5TWLEA5hyZ0N8hFNk6DiW03B6MwtTGLxGa5DA+5nvHSqByiXq?= =?us-ascii?Q?pKGxISHX6va/iyZx4yYMXpA5xRLmF02OEH5hKPTAgiv3nyFj3NxIbfchDfEN?= =?us-ascii?Q?+cQNj6xGyBdeFae3C4ej1kjQ0hzlpWMBZSIz7VmxF14r0zgFEW9RLLdM5boi?= =?us-ascii?Q?LrcVKj8pAhBc2TpxISzVyWXEye7GUHcOvn5BMOSlQ6l+1XboIGqkrY6uChOi?= =?us-ascii?Q?0BFQt0B3gs84AvgZDs1t3XLLMENXZjIxjLZKGnRNhtGKUNNXWiwp4R98jM1U?= =?us-ascii?Q?Kytr3ixfs08RHk7ZYrkRvF8umfhbm6GziXfeSTdoykU1a+lJ09CJ+IdmMyQZ?= =?us-ascii?Q?J8RqJl04Y1CHIYGEauLxgcsS/UVHT9ZTAzX2jHGIGSl18Yl/nmJeIiq6OazY?= =?us-ascii?Q?rS2CB5/KslC3a3rTRuAwLqU81QeSu3oKjF8DqZ8l1XvAFvC9Bwu3NsyOF2Ef?= =?us-ascii?Q?x48CmqrWpU5oAimMdibourUzAtlHrC/xfrbQWcp5EDa/JRds6JOILgYLGEL9?= =?us-ascii?Q?bqbHwtmazdUNbCe4cMLpOu6dqnWeDRUubhA24NVhPu7zP72vu3IcKtk4+jAo?= =?us-ascii?Q?00ZN0XgKkptNVejgRjnLMBhJjhvX8Vc9UDYjfJJmZoRBcgszcXrNm/DQTFci?= =?us-ascii?Q?pijOGdYT087xxCrQutv2KAvPfbpnVY0gnpGfU8mO/w2VRHna3C9aV8Vpl6xA?= =?us-ascii?Q?WZ09zjWFNOpp0RAQX3s79GbG17jaz5FmWxYa8BLJYRWpKI4zrWsZKbxzR117?= =?us-ascii?Q?4v/Jl401I/N4t+ICiOW1Cu15JZ2ERR8S1X01p6PiHe3FHER89mdtd86Bd4pS?= =?us-ascii?Q?1FhiFjuH0KO/MQ6/4fQ58TAciDkEbNw6RFno/IYUC5VsCA/kc2vIaWTcOwwD?= =?us-ascii?Q?ZInHCPi5eQ4HdsE=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:04:34.1008 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13a772f5-1408-4fd6-41ff-08dd7673ffd0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE16.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6340 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1beaef965d323ec092dd7ac589c10d44491c4bfa Thanks. Xueming Li --- >From 1beaef965d323ec092dd7ac589c10d44491c4bfa Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Sun, 23 Feb 2025 11:34:04 +0530 Subject: [PATCH] crypto/openssl: validate incorrect RSA signature Cc: Xueming Li [ upstream commit 6c209dd8785f34bfdc99b869c14e063d084508c2 ] Return correct error status when incorrect signature is used in RSA verify op. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- drivers/crypto/openssl/rte_openssl_pmd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 11734c4c21..1e6f0467e3 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -2803,9 +2803,15 @@ process_openssl_rsa_op_evp(struct rte_crypto_op *cop, goto err_rsa; } - if (EVP_PKEY_verify_recover(rsa_ctx, tmp, &outlen, + ret = EVP_PKEY_verify_recover(rsa_ctx, tmp, &outlen, op->rsa.sign.data, - op->rsa.sign.length) <= 0) { + op->rsa.sign.length); + if (ret <= 0) { + /* OpenSSL RSA verification returns one on + * successful verification, otherwise 0. Hence, + * this enqueue operation should succeed even if + * invalid signature has been requested in verify. + */ OPENSSL_free(tmp); goto err_rsa; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.788577203 +0800 +++ 0028-crypto-openssl-validate-incorrect-RSA-signature.patch 2025-04-08 15:39:05.946436575 +0800 @@ -1 +1 @@ -From 6c209dd8785f34bfdc99b869c14e063d084508c2 Mon Sep 17 00:00:00 2001 +From 1beaef965d323ec092dd7ac589c10d44491c4bfa Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6c209dd8785f34bfdc99b869c14e063d084508c2 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index b090611bd0..5bfad92b7c 100644 +index 11734c4c21..1e6f0467e3 100644