From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C430046532 for ; Tue, 8 Apr 2025 10:05:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDB634027F; Tue, 8 Apr 2025 10:05:30 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2067.outbound.protection.outlook.com [40.107.93.67]) by mails.dpdk.org (Postfix) with ESMTP id AC4434027F for ; Tue, 8 Apr 2025 10:05:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mmYZYSbWl7JFrSOuAiKRtEHRh810Yd1nV4CtxZ44MJRtR6nNT2kJxLaBRR6/amAHh5XWjrPht+OJCj6H9YqT+8hIYixVEIUgf3dprZDqBngbW78OA1bdVMKNfulzPIZHiGR+S5oQwlO1FmQXLSYnfYnJi9NUkoPIWbQCePtGBApCVhuoU7e4eZ476Zu04bYXuYT7JcsHKMWLeOKmYlZ0z2IjBeGaAucFn7QcSTV23S/1B0+mYiFO1Fg8VyRPVOKLJHmCzTbk66o7bpFJDS0Hg/DDNpfJHVgyDMVhR2WX67kBub8scbhCGkP17Oa4VHiwpTMgxt8CVYFAq9NB7Z1FpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1/E/bSkHGHF6HojQkTr4qvVD8+o02ZJbIn7cbJ9lS4s=; b=y4/4vY9pGqVGSsQLs2i0ZN9FWuD66Q+LsQljtOd/cKCFmaWweCQ+FbhyyFVvosur6N7tUdcPjkRup9hHzan31dsJOJ5GUcXiOa0WWiAG8dx2Q0/J1Nv8ei90o/hMIBXPyIVMJ+sA7FwVMLSuBCOuayDuXNAc58lr/DsuUCdM1ZjobNmOUlNEIu2SPwLapvyfIouo2SDvePzQmGr+Sc4lIMwLQHlpaASPspaQONeUq0ps7k3YwMMTMMV7vYw9ZokF3REwpeo9AhKR/2qNsXNQVUg6lyvbAskKizMQRULmG82Ere8TW1yayYULW7c8VEl1yLl2eU+weydcGqnm2ZySoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1/E/bSkHGHF6HojQkTr4qvVD8+o02ZJbIn7cbJ9lS4s=; b=Fimq+5SiNSZWvKDtPmZV7ReajIoLh3q7V+HIVBzRAizHVs4x2WlA0pwnfuAWzj3qL7TK3MwfXM03Y0q69FOQ7AGVm6a7i59RZUGQ3ujAIThdxXDbaf2Qsh1VwdaROPXTHNHVKYUZ0J2JkLpLg9v5a4aewvSnn46Uk4d9iWSdvdPCAEm11C7VzrfaK1IMiEajb44ikj5bhJkVJdXM4tFAl5bR0nQJMuomLg8H459c6PFNxKT6FOJGXspVnvmZUglXHPpuDY1q6GnN9b/euS6XFTPQ+eelHTNUkIOCJBcaAhan6EWPmEYH/21dLIYco4Tr1mlSjawIB45FS2vUAH/NpQ== Received: from CH5P222CA0011.NAMP222.PROD.OUTLOOK.COM (2603:10b6:610:1ee::26) by LV8PR12MB9405.namprd12.prod.outlook.com (2603:10b6:408:1fa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Tue, 8 Apr 2025 08:05:25 +0000 Received: from CH1PEPF0000AD7E.namprd04.prod.outlook.com (2603:10b6:610:1ee:cafe::a1) by CH5P222CA0011.outlook.office365.com (2603:10b6:610:1ee::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8632.19 via Frontend Transport; Tue, 8 Apr 2025 08:05:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CH1PEPF0000AD7E.mail.protection.outlook.com (10.167.244.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 08:05:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:05:11 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:05:07 -0700 From: Xueming Li To: Vladimir Medvedkin CC: Xueming Li , Bruce Richardson , dpdk stable Subject: patch 'net/ice: fix flow engines order' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:01:57 +0800 Message-ID: <20250408080214.371154-19-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408080214.371154-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408080214.371154-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7E:EE_|LV8PR12MB9405:EE_ X-MS-Office365-Filtering-Correlation-Id: 97abb684-ac7e-4fe1-0f29-08dd76741e7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J+Io8fYAQUApoBT2OXtDzCA9n9hzT9JFyK+NzcZvX+MyMCVT/ZYf3vMwhgre?= =?us-ascii?Q?L/JYPJ4W+pLkOaBU0Pl/4wrjay3GOzvqdfJvdV5DXHev0Dzx/6eBLl8WzZ8y?= =?us-ascii?Q?JSjMEPLCPa0eaxc30gfDT4bkroywvmkGjbbxmNikrXXt8XaZwvUaU2J4Qdz7?= =?us-ascii?Q?0VE7iDZbzZe7ZbZ1KQ36LG3IraPt7my3JAFz9Qz23FXWlc7Bk8Om1NhXxl2N?= =?us-ascii?Q?BLxVs6kPCx8aIlOVRMzj2tcFNVXD1n/rSPF3lBWIouqXXWzREK+nMcaZVImu?= =?us-ascii?Q?Mj4vYF+u7Z4Up1QscVVXwV7xBGWdFRj3Bbtii+m96PqGFF0fnKnMLhpfE3pt?= =?us-ascii?Q?YU6I6yJF3cQVze4IJ3OooLytO/P6p2Ew6AXY1E0Ks0jtL30EDa7t7/5HRLOO?= =?us-ascii?Q?kHJ6qhnAS2bwkNCf0sJFNVzQnizqsbFbdltTPCoGYjkmNXuXezLZ2Zh0thX4?= =?us-ascii?Q?9/yKvC7961SdXaTjbJqd0xi9MrgpSKkF8rpQghiRy1+34Ij/upe+BpwITwjT?= =?us-ascii?Q?WWTKB9UvuA7rAqpf9U4nOj2m/uUa6lurnv9O79ZfuKTrIQWuCqGMYFeqGysR?= =?us-ascii?Q?ptvwDLOHrFETsWiRzV0hG7GspKt9uzmyJdxOlGXFpa9uAJbXrfI6ml++Bi/n?= =?us-ascii?Q?6nav4Tn81yF8t3GyIHkj2LyeBFSZ0RG15VUQrigAFO9wCcK1d7GxRtPl5VOI?= =?us-ascii?Q?NAmq7n1BowPg9bjO1N/00fQYBQjXPnd/9mFWXfMgm9pMfh30NOHUiP+4O5AX?= =?us-ascii?Q?kVIFceEnfPsfEfx6XKtpQXiHip5JJRM5xZ+8WmSsrEVgGWNhgu10tNIor/Lw?= =?us-ascii?Q?UrWAWpmY2UzJqdc1NMET9yF1tPq0+57ML24YD71Ht/jLcpfoo0JrhU1RzT++?= =?us-ascii?Q?JFtIHDtUWZQBRBajO8DhQBFDVEamelEvjOpgLoP1KLDTEivs+5UiaOmJZ/VO?= =?us-ascii?Q?9FdiW8ChOgoh76tr7GBgyQpTqU9u2uyi8sCX3tcO8F+4AxnBDFilch7/zMLk?= =?us-ascii?Q?EE23mvF0pSDS5RLUlw2f8EVCrsKqEsOxkfgah6gqAW3o4grRVIttTZm9gGm+?= =?us-ascii?Q?3GUkLvJgPhZmclRfxBgyWkkVC2KrHoHfhGpqq6WufADwDHxwcjN1GIbxwuJo?= =?us-ascii?Q?UWObQmq5FvqsJiMJVwNOseVZ8pjeriegAeNS0SITeaHoYqIoCPpfFLl/8X0F?= =?us-ascii?Q?GRdNT0VTtgyly3krKHFv5nzD76PH1c+CAj8UnIfeXSY+pGYGcX+k78urfXaL?= =?us-ascii?Q?UyB45qZRJ/xdqTkXf3eZydjqWOpX4aO03UdrH0S22NrwaMN629p/4sXoPtIU?= =?us-ascii?Q?JrlXcvYZoRRSvXVf7o8+wvTUAuJbP6WKjHQR1XQlkOcozJ4QT2r76btBfvY6?= =?us-ascii?Q?at6Cu0uVFhZb74B5f5kiw5fLQsKRyzp5+ISoLJcutG2jj72KWY+OB3pyw/iB?= =?us-ascii?Q?aS5gIAGC3p+3y6dYtVbMnnMHMx14fcIZCypfFNjg9SFMJwvyFeUpXI/jVADb?= =?us-ascii?Q?0rinvMqxVbdsgUM=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:05:25.4999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97abb684-ac7e-4fe1-0f29-08dd76741e7f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9405 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=e42c10138ea18f856bc57d8822c65a68575090af Thanks. Xueming Li --- >From e42c10138ea18f856bc57d8822c65a68575090af Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Mon, 10 Mar 2025 17:40:28 +0000 Subject: [PATCH] net/ice: fix flow engines order Cc: Xueming Li [ upstream commit b309503d63159680d4ff8ca9e968fcb12ac609a0 ] Currently, the driver evaluates rules with the engines in the order they are executed in the hardware. However, in this situation, some wildcarded flows that are also supported by the ACL engine are installed as switch engine rules, which scales poorly with each distinct wildcard mask configuration. Reorder flow engine evaluation for RTE flow rule installation to fix this problem. Fixes: fabc9e1322e2 ("net/ice: fix flows handling") Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson --- drivers/net/ice/ice_generic_flow.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index 5c34e0385f..4049157eab 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -2239,9 +2239,9 @@ static struct ice_flow_parser *get_flow_parser(uint32_t group) { switch (group) { case 0: - return &ice_switch_parser; - case 1: return &ice_acl_parser; + case 1: + return &ice_switch_parser; case 2: return &ice_fdir_parser; default: @@ -2298,6 +2298,13 @@ ice_flow_process_filter(struct rte_eth_dev *dev, } for (int i = 0; i < ICE_FLOW_ENGINE_NB; i++) { + /** + * Evaluate parsers in the following order: + * ACL - for some subset of wildcard matching rules + * Switch - This engine is placed after ACL because + * it scales worse than ACL for different wildcard masks. + * FDIR - for exact match rules + **/ parser = get_flow_parser(i); if (parser == NULL) { rte_flow_error_set(error, EINVAL, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.913016462 +0800 +++ 0033-net-ice-fix-flow-engines-order.patch 2025-04-08 15:39:05.976436565 +0800 @@ -1 +1 @@ -From b309503d63159680d4ff8ca9e968fcb12ac609a0 Mon Sep 17 00:00:00 2001 +From e42c10138ea18f856bc57d8822c65a68575090af Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b309503d63159680d4ff8ca9e968fcb12ac609a0 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ - drivers/net/intel/ice/ice_generic_flow.c | 11 +++++++++-- + drivers/net/ice/ice_generic_flow.c | 11 +++++++++-- @@ -22 +24 @@ -diff --git a/drivers/net/intel/ice/ice_generic_flow.c b/drivers/net/intel/ice/ice_generic_flow.c +diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c @@ -24,2 +26,2 @@ ---- a/drivers/net/intel/ice/ice_generic_flow.c -+++ b/drivers/net/intel/ice/ice_generic_flow.c +--- a/drivers/net/ice/ice_generic_flow.c ++++ b/drivers/net/ice/ice_generic_flow.c