From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E090246532 for ; Tue, 8 Apr 2025 10:03:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A053E40E5E; Tue, 8 Apr 2025 10:03:20 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55]) by mails.dpdk.org (Postfix) with ESMTP id 027A040E54 for ; Tue, 8 Apr 2025 10:03:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gkd3vxjXolvyUXzyWOMhuZrx7FcdXAMVhZ2MKNaXRrJiu4I6BiuM2T+4XhfHPJ1YbBu7xC/i8yWXViJk+gMvvAG4onaFEZFETP1Vp0NDqrE0vXenfXe2OlrTvK/5qkwRRcWJVuxlG067FkG0YU2YFDKrqnTHLCjP6A0RRoL5N/XCW9ozTAv4jNHcjdr+9WcdjLGbdTrNDabFFJcTzSDcvT8B+eBcM40/P/cbj0h6YzlUiK6itNhjKVOjZEmgURTmcSNhxiDTY07HwcohjT0t+ZqiaYgCFf6E1ABzAjBtfplL7rdBED6c0WkDWWCoLPA40U1aAGuwH7Lr2V+R+P4WLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYNvj8y1BS2dRPGXdWEQFmFHAna1MBa4BehZC1tjNXc=; b=AWN+qtkW29mrX8NlXd9lkKGyWoj30tmAo1fcwiCSMoUUm829979Ke3WbaZOq5X1uXBZTheRXiYOl+5obiEON35udx9lf+5iFghicROAXwjiY4BGTVCtmnOOaO4I19ByRsZFfVMtpAUGUXEPYLP2/2iwIsq1CE4f3QHDjAwrXWA90F+VwOWctXhi0eEj9dAfPTbt99RR/x1eScobxUtOhjarYWNVXXgxpihEEhoEp6ZjDxbzN/MwWP2p1hSd6GLFot7z9DjH5a4yvU+IaniRIaRqXWbP33q16NJhgLC4J/WnFmGsDTetvpiu14agFX1dDGBR6YpAKOOml22fUBmFrYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYNvj8y1BS2dRPGXdWEQFmFHAna1MBa4BehZC1tjNXc=; b=amRC9G033vspoTXojDnmK0X88gOKb6Vh9HEFjfDOt9i2hrlQC7xKYqttJeCB6bQwuo5cIZ2CY0Yda+aepL1a2oaMNhCrZWjtlYahqvBzyx/1bm+HQ2eutgOjzPrpRY0OV7MlsmwA4aO08XVkePVfjlRvoNEvme+9dRTutkbB7ytGWWTGwQe65xpst98iupM9Tq4mIUY+/7tx6VmquR6KKFzTDJ7c5w6NEoaGK14fSsfwtviWifJZHDbTLTPFpmf+micp2UP4RmHi5IIoGUH2jQubdzTUuLYGC0ZnjTgbvGCbEnji1ltR2qDQWEmrmVn1M7yHQoPkmMADR6N+jd/1qA== Received: from PH7P222CA0021.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::33) by LV3PR12MB9412.namprd12.prod.outlook.com (2603:10b6:408:211::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Tue, 8 Apr 2025 08:03:15 +0000 Received: from CO1PEPF000044FC.namprd21.prod.outlook.com (2603:10b6:510:33a:cafe::b2) by PH7P222CA0021.outlook.office365.com (2603:10b6:510:33a::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Tue, 8 Apr 2025 08:03:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000044FC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.0 via Frontend Transport; Tue, 8 Apr 2025 08:03:14 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:02:58 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:02:55 -0700 From: Xueming Li To: Mingjin Ye CC: Xueming Li , Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe: fix minimum Rx/Tx descriptors' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:01:42 +0800 Message-ID: <20250408080214.371154-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408080214.371154-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408080214.371154-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FC:EE_|LV3PR12MB9412:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a33ff58-3703-4fc9-f757-08dd7673d099 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QhFC3+4GcSOL1QAQO7N2ce8LpJV1XjisitEaaXda+0Gf1G3KtEyO6fVWi/D/?= =?us-ascii?Q?bS5E8+5LszIK6rKgf+aahjqCshbfSB51uAjxs1s196/8DSoNJAzdtegBFofs?= =?us-ascii?Q?7SfTBL3wSCPWY7U9kUXXF4cANbaW8jMnwRSRqP5Ki2QG8MycSz1eb7+LsYOV?= =?us-ascii?Q?0KqnHOkVLM2F2RbZh/SaxKawh63Ntesg/X3oCQFuOoqE4PwubqYpwqNb5n1n?= =?us-ascii?Q?BIVCvbgK5OxIJUBtuYNr4vBqalM7M6cc70XsBU2kEemZYaEGVatREgYZKmto?= =?us-ascii?Q?WZtCnhPfY1eXW93DtxRi+dG0Ue54tLcE/5mOpqCu8vstlGguS/lU6Dj+USjz?= =?us-ascii?Q?V0aWboY+RNLlQOoDfsdTNmIrglYWp+YVUO3hRBgxZyMi+qHoHZ/zwRVTYB10?= =?us-ascii?Q?GGckufkqhnzLgjnbF9hEZA0JMvP0ktzIcqRJSg1ic19Np+GlOAGll7sCPH3f?= =?us-ascii?Q?/G41k+p/EVtLpuPlLmGuWSrX9ar4RQ4vHz8052AxkDqBJl5vElkKAl6WGd8R?= =?us-ascii?Q?ZOn0U4dL9lqNMPlql26uqaexwgWS9n9FzOnB1h3Jx1yyVdGMKTOVjIxaEeFG?= =?us-ascii?Q?GR3SHTSXCMT/C8aBdY3QhWerBprTS76SCZEiQVS2OhyNiPr4lH2UIYuv2bO9?= =?us-ascii?Q?gVmk9nl+8lnzbOTxHxXz92N/Qxu4o9LogeUM+VBqKDY14nQ2JlNYxB0yEJse?= =?us-ascii?Q?xzYJJAH7sY/RUw6u92iJPorBdg/MnxyZKmbcLATaQ9OLSh0M7USV7fsDX4k1?= =?us-ascii?Q?rBzoTDZ1Rx23O1rWM/RJmYxMxn1U/7HKSSEe7c5kdX7oL8QsPRiZu3TN9+pv?= =?us-ascii?Q?rKEkKSpZ28LoQ1a2jI5osgZO+T9noBtmaNf5kQbXrxCQQccLROrM7hvr1Dj6?= =?us-ascii?Q?cUrD6vQjeUa+Ls5KJN6OBmHy1lpwSGdNScu1KtR6fC46NTp+pE5RlKBg0OTF?= =?us-ascii?Q?jH5YPVdAsxUn79ELhKEi0n1OS4Zq9xFFHo3hdmNRAG+hT4DrypddGGKKoPZv?= =?us-ascii?Q?WkHmXAUkeWM6+CodMW0IsD+N+0O4IO6e4o7Yv4Srd8jmHBUFpzpzqPjge2bV?= =?us-ascii?Q?B1aSCHeu+DmsiE1YeKgm0aFPfcepqkJUqaJswRM3M2xSIfyjckGz5cGDf5G6?= =?us-ascii?Q?qUgBjz03LARgyASoDMrySZbFrG5Wdkm1RcUevx4DqRBV9LjAPnjadp93pWeh?= =?us-ascii?Q?PgWTilBIh69ECByqWYDuOBaTXvoouqNKe+5vGrpVjf3rq8jviBXvnZ/zA0nd?= =?us-ascii?Q?mI2xJjeWQvnpRei7sbBFZOO2uoksW0BRMOV0j+uQl0MO9n6Q1/K9lJHBvTUc?= =?us-ascii?Q?pBYJ7VjCbqo5Si4NJfbnCX6zQ3N8ven7sZUlZpstOAh54QluQbFXKXKapI66?= =?us-ascii?Q?Wy8dUyaODjGZ+yHMSzQnHTxZAwiqFOQi1xaTqkN5kaUJZHuD3ueNS2Apx4xs?= =?us-ascii?Q?j9+e5zdOvE4VGj3wLiBqF5n59dBSD7WPtanvAHDHr9Yter1aWx1wSn+MwhyC?= =?us-ascii?Q?v8B9xYWLYfE7pF4=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:03:14.8633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a33ff58-3703-4fc9-f757-08dd7673d099 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FC.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9412 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=05298e9879e2f51b87efdb91bc6b65336e5e423d Thanks. Xueming Li --- >From 05298e9879e2f51b87efdb91bc6b65336e5e423d Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Tue, 25 Feb 2025 09:12:36 +0000 Subject: [PATCH] net/ixgbe: fix minimum Rx/Tx descriptors Cc: Xueming Li [ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] The minimum free packet threshold (tx_free_thresh) and the minimum RS bit threshold (tx_rs_thresh) both have a default value of 32. Therefore, the default minimum number of ring descriptors value is 64. For reference, see "Configuration of Transmit Queues" in doc/guides/prog_guide/ethdev/ethdev.rst Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits") Signed-off-by: Mingjin Ye Acked-by: Bruce Richardson --- doc/guides/nics/ixgbe.rst | 8 +++----- drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index e32eff6244..d54c20e1ea 100644 --- a/doc/guides/nics/ixgbe.rst +++ b/doc/guides/nics/ixgbe.rst @@ -68,13 +68,11 @@ Ensure that the following pre-conditions are satisfied: * (rxq->nb_rx_desc % rxq->rx_free_thresh) == 0 -* rxq->nb_rx_desc < (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST) +* rxq->nb_rx_desc >= IXGBE_MIN_RING_DESC -These conditions are checked in the code. +* rxq->nb_rx_desc <= IXGBE_MAX_RING_DESC -Scattered packets are not supported in this mode. -If an incoming packet is greater than the maximum acceptable length of one "mbuf" data size (by default, the size is 2 KB), -vPMD for RX would be disabled. +These conditions are checked in the code. By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h index ee89c89929..78f17a0825 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.h +++ b/drivers/net/ixgbe/ixgbe_rxtx.h @@ -24,7 +24,7 @@ * descriptors should meet the following condition: * (num_ring_desc * sizeof(rx/tx descriptor)) % 128 == 0 */ -#define IXGBE_MIN_RING_DESC 32 +#define IXGBE_MIN_RING_DESC 64 #define IXGBE_MAX_RING_DESC 4096 #define RTE_PMD_IXGBE_TX_MAX_BURST 32 -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.539412783 +0800 +++ 0018-net-ixgbe-fix-minimum-Rx-Tx-descriptors.patch 2025-04-08 15:39:05.916436584 +0800 @@ -1 +1 @@ -From 6808ee1ceddc76846f80ae3d05aad374a34a1754 Mon Sep 17 00:00:00 2001 +From 05298e9879e2f51b87efdb91bc6b65336e5e423d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -19,2 +21,2 @@ - doc/guides/nics/ixgbe.rst | 8 +++----- - drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +- + doc/guides/nics/ixgbe.rst | 8 +++----- + drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- @@ -24 +26 @@ -index 8dcde7ae1c..a03ec7a7e8 100644 +index e32eff6244..d54c20e1ea 100644 @@ -42 +44 @@ - By default, IXGBE_MAX_RING_DESC is set to 8192 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. + By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. @@ -44,5 +46,5 @@ -diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.h b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -index 278f665108..54569c7ade 100644 ---- a/drivers/net/intel/ixgbe/ixgbe_rxtx.h -+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -@@ -26,7 +26,7 @@ +diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h +index ee89c89929..78f17a0825 100644 +--- a/drivers/net/ixgbe/ixgbe_rxtx.h ++++ b/drivers/net/ixgbe/ixgbe_rxtx.h +@@ -24,7 +24,7 @@ @@ -54 +56 @@ - #define IXGBE_MAX_RING_DESC 8192 + #define IXGBE_MAX_RING_DESC 4096