From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 694B146532 for ; Tue, 8 Apr 2025 10:03:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61EC940E4C; Tue, 8 Apr 2025 10:03:51 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2076.outbound.protection.outlook.com [40.107.95.76]) by mails.dpdk.org (Postfix) with ESMTP id 0A4D94027F for ; Tue, 8 Apr 2025 10:03:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nbHJGSG0OgGG72kfiD0qPXuz+wwY06OsU1zVeNWOMwO4QulzugnSdwsGg/HDDnmvIOkuG3Z/oJELmy7SMdRZf4QMx2DhOPL6lWdPa0TSflRk+K0Fc96ZYakJW9F1CbYSnX9ZZaRVt0ONmxq1d0wSzL4rggHJUak6UKIabjKKBDXI8T77tEAlinJWQ7nVWrpb9Ste2N9B066JhjE1+aflDfLQjQiR58Q2ZEJVO8yTMFhx3O+FiBav1HxeQo0k6tQj10qmIOr8NJm2u1rN6ynGlA+5evLr2dbel9tVZABs7gMZXv7EKsIeSnclq5q0TJFRkdDIPJHsCHE47ZI3gRS4dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HHbbv7VuYyQDZKkYxPVrkc8kukQHcefVNf2PPtjN+mE=; b=B/BmgHjl3oyQkNmLPueHHRapakS8Dw5hUuSonAHoBjUBpfnSnVEzy92J05HI5nO5977lQfFwb1H1kWKSrb2Czy4ew7dZu6iHWjJzQPdoMGPQE8uhdwJEZ8FgGZmcLn7kBLRr7VwvfKV1hhXsODR2bmiKXZWG7zDH1fW5fWu/PyUqOgF8lGDxiyOhPY1LrzyxBMsXue+8iP9Bf/RgKvfkIOFuB2E/plMW6Rjc7xMkuMvprliGOWOhgtL6xxQYwiWPh9TbeKna/9jzRaDZKfQ+IMMnEAa2Z6n90hraWJAT/oNcxeBlhTA/EkeXk89JeS+TSVY7se1cNlgEXYojC4v9bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=linux.microsoft.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HHbbv7VuYyQDZKkYxPVrkc8kukQHcefVNf2PPtjN+mE=; b=qkC/56/zlkCWweMqnniLEv2Qznu4XElmNlSgPmyNEz26iht+sbgE4iHGEHHtOin9Cp+VLWrqSG4IGgKoCOWVqiAFcZFA/fZ/NdXBAHBNF8JWVpD+imizKonhsP128MiAhr8rKoiy4uqfo3zXnX/F6QKBgaG0OjIw9VwMRHjoJ2hlNYp5kVBSgxrugfKL3XIB68GaJHJf9YuuLgddHQY9UCZVcx5YmVQ2JxwM7P4BtILsSjQYgIBe2emaJt86lErZlRpYg0K4kRvOdDN6uG8JHb7I/Q0JE6Pp8kp4TmAIAO675nHVxMi4/04KPVum4E01gRTx1zsGbKLvuinu1gEtHA== Received: from PH8P221CA0055.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:349::8) by CY8PR12MB7195.namprd12.prod.outlook.com (2603:10b6:930:59::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 08:03:47 +0000 Received: from BY1PEPF0001AE19.namprd04.prod.outlook.com (2603:10b6:510:349:cafe::61) by PH8P221CA0055.outlook.office365.com (2603:10b6:510:349::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Tue, 8 Apr 2025 08:03:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE19.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 08:03:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:03:32 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:03:29 -0700 From: Xueming Li To: Andre Muezerie CC: Xueming Li , David Marchand , dpdk stable Subject: patch 'stack: fix pop in C11 implementation' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:01:47 +0800 Message-ID: <20250408080214.371154-9-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408080214.371154-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408080214.371154-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE19:EE_|CY8PR12MB7195:EE_ X-MS-Office365-Filtering-Correlation-Id: 39444b2a-1424-4574-ed8f-08dd7673e409 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ezzb0GjdayODkYOQI6Jm92vEPPhdRtneiAH2l8E5j4z2XaheKfG4waatMEzv?= =?us-ascii?Q?4VQdri/qE1865j9SkJlmUy5Hn2BnPLrl9d2biw3k5gnzfE4NNZ3OscXGaqDf?= =?us-ascii?Q?DIm3/MGtH34wc+JBFPJ+EvekCurElVQ6WJ60XqFdOevuMy4WZ+vyCtqRJf9C?= =?us-ascii?Q?umau79Xvllq2lvZ5HxlCwI6Zc2BsBSt5PAJI5aN3JkODX0rPwc5tUfs3zBwt?= =?us-ascii?Q?vCgYra9L/QkGb/pGWxhm9cE3VfbExcp/HtAurO+wpMv+PD1u61mYKUtfKaSW?= =?us-ascii?Q?B+o8yp/g7SWaQ4Ztl6VQqKIFgfqQ5VeSHdmpYx/RZ4aRCAN1HVte+jw1sp7b?= =?us-ascii?Q?CBquhOxs+mSrWYQBJb5POQ8930NH5msm3rE+jrfE+9IS1RGY1mpkjjrFCu4S?= =?us-ascii?Q?oX+Hl4FEbox5JXeBQpDfZxuUKzqwiyYnkIy+mUwHdJyTVRRdPdSfU6lFGljg?= =?us-ascii?Q?x82qbz7pVdJq2327eoX0pfsTuVEKps1KCq8FuKojtu4dBi1fW4Ji+pONYps2?= =?us-ascii?Q?Utdzc0MU0iVE9bm3B4mJFVOdIcNDhFdXyRe5L35oUzIQQ6T4v6Or1IppBGy6?= =?us-ascii?Q?oG5s/2UXsBzWNovHBSv0h5Um0C6AS1y78JkQf6pyXwH8mdR3dgO6RD3nGtdm?= =?us-ascii?Q?ZrTN+TMVRRxe73wvQ1wQOAT5g+w+2LtdimdEoR2xLFDmFeAUxjEHTqXBbZ41?= =?us-ascii?Q?TVqSDhmAkLwiVWDBOi1kWb+HdWW7eFIr2H/uj+R5ZSgCHTeOXbAgP/5foB/q?= =?us-ascii?Q?pHTjGROXwilPdtkETM1VOnTNkbBDlLVW4MF7eb3bg8sRbnTLjYEHFOlQvRN5?= =?us-ascii?Q?hrCXBlisWrm6Wc3p70VIggZAA7wBWp8bDorhm0gAKhluTcpy9CSvvIe7f9NL?= =?us-ascii?Q?pF88E/dkJFGuSv8xrEfX2Ou/03vZKQCmVpxtXolQyvgdrdrSfJLIyy01YLNc?= =?us-ascii?Q?Ss/bLUhZyUYHIBuU4OtyPWJ5kDkwa0GXFplE0DsPusIi87mxR0NPqTSUJP7y?= =?us-ascii?Q?izdjfqUSCXEZRLaLJMkHk0uha+xQY7Eh9Dc8YcbakwkJ5JDgrN9XYSDglEwe?= =?us-ascii?Q?9Kv+7QEEmpMvNKpJnc3YtHWoA+p1BsgvM6d2V/OAG8k9qzmoo3HW62eQZOr2?= =?us-ascii?Q?4CFjmMzrmsOm+63MqFAjGb+NJqaBpOtOJfkxP5Ip+DBOpchfbtvzIONJJiqV?= =?us-ascii?Q?bkQ+ixLii5gbRDlTKYV5jh5K4x+TRsM7LMKQlmVsPCJiEd4eQV5FPQRk0YGJ?= =?us-ascii?Q?osBJsNIN4LQNa658XvDSPNyKkTL/uusH/xC9WsLRzVH1tyFPLpA3/VsVCzgF?= =?us-ascii?Q?iTlfm7omCUPK8U2/Z/Gx9LLsX0aqE7qfE4lqDfUdTyngrycFyhw0aoOg8l24?= =?us-ascii?Q?l5Vd/yu9rWQSq4zsgcexAvmcyZYZ7l9p8C2BGIqcRhupl8AzgtDHHxbXfzef?= =?us-ascii?Q?KCNNgUC0SyVhIyhbIMAgZhH+/4y6iWtU3m0veiY0edh2xaeGYx9gCjVrwGx+?= =?us-ascii?Q?Z7slm5+FX4DtUlA=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:03:47.5025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39444b2a-1424-4574-ed8f-08dd7673e409 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE19.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7195 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ed66387d301de1dc8022128b4b2e3ad3223f3504 Thanks. Xueming Li --- >From ed66387d301de1dc8022128b4b2e3ad3223f3504 Mon Sep 17 00:00:00 2001 From: Andre Muezerie Date: Mon, 3 Feb 2025 17:23:37 -0800 Subject: [PATCH] stack: fix pop in C11 implementation Cc: Xueming Li [ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] Variable "success" was not being initialized and there was a code path where the last do/while loop in __rte_stack_lf_pop_elems looked at the value of this variable before it was set to any. Compiling with msvc resulted in stack_lf_autotest sometimes crashing. The fix is to initialize the variable. This same fix was applied to stack\rte_stack_lf_generic.h in the past but was missed here. Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation") Signed-off-by: Andre Muezerie Reviewed-by: David Marchand --- lib/stack/rte_stack_lf_c11.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stack/rte_stack_lf_c11.h b/lib/stack/rte_stack_lf_c11.h index 9cb69983d5..3d83bad747 100644 --- a/lib/stack/rte_stack_lf_c11.h +++ b/lib/stack/rte_stack_lf_c11.h @@ -77,7 +77,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list, { struct rte_stack_lf_head old_head; uint64_t len; - int success; + int success = 0; /* Reserve num elements, if available */ len = rte_atomic_load_explicit(&list->len, rte_memory_order_relaxed); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.678600838 +0800 +++ 0023-stack-fix-pop-in-C11-implementation.patch 2025-04-08 15:39:05.926436581 +0800 @@ -1 +1 @@ -From 916424f2c6029cd8da5c56ed62847a4b09d7e0ac Mon Sep 17 00:00:00 2001 +From ed66387d301de1dc8022128b4b2e3ad3223f3504 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 60d46e963b..ee1c79c095 100644 +index 9cb69983d5..3d83bad747 100644