From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBC2D46532 for ; Tue, 8 Apr 2025 10:11:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC3284027F; Tue, 8 Apr 2025 10:11:34 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2042.outbound.protection.outlook.com [40.107.244.42]) by mails.dpdk.org (Postfix) with ESMTP id 2AD2B4027F for ; Tue, 8 Apr 2025 10:11:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i7N3744T7x66Ng5bK35Ax9mnwghAgA1BmQB4vP+Mxhw38zkiGUTms49jqNfAChSKMz4RLgNi51jVfuMTJ6UNs6AHiNbb7VLvoh5vrPz4zDlsTkJbjFUeZlSVG0YY6Mv2Bv+Z+iflYi22smyeAVpIb6XIsKuCgRrDequHiuGj2ml1L+m6OHiQgdkkGkbc9wOtnVBvATYV+HM4wdnsV7IUo7d0RjDSrEItfPT78orapPR5DWaH+xl3NF+ZoipfeU4WIanXRPwPm9XKFuJ6GVR0AsapdkcHrGNhNFDjeCa1YD1C7AejQa++GabCSwtB8ddTr6wUPyBVgqoG0DxRO3gvHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7yfkejgbD1jDQK0tMR4DwIxRtr0s1l9gxjYK3tJIlCw=; b=DRzdSxwGdg6x8ODz2YYzhYRQVrdkzSSCUbU9CZUMnOMmUdmP/RmCLwEHCnqjtabtyGKkyzKPVGAp6ZqIR0bEJQgqusPenR4/BRey7inhWZ/GnFTrDXasXiL4uluz/8r/vLq7GqUnoax9ak2LHf+qwIYqFojJI8YWv58BTnNf6HavHxqcEk887BjNwIz1ft9vFCgEwdBgf5WoLpp9vnXoAv/WO3f/Fjq08mZyVAo9ZTyD8g2HIZCjOEhPwILm6xtMD9ObGXREhki5gMzAnCddY0ZjDzxnK+kC0htwYaqiiCbwtaTkBIioDXg1WfnEIv18/r2JvxLf8qbjsmzoRV+Kfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yfkejgbD1jDQK0tMR4DwIxRtr0s1l9gxjYK3tJIlCw=; b=jaN9rC90Y48Mdh15vD2PoOaaUF2tQ63PjRGV1oTmkv/QI8XBwVjdu/umTzqNJ5AHyFd+FqrOrTnl3svesGgj445TyHGgn70i5H7Vyy9gSbFRvDgZCvIOOV2ZjWRpv9JP+GualIEd64ELX73NDqDmt1G+31TAUWe71okpMZN+39YENR+TNOyM/7dGaqu92/2EDA2Kwl+82sBY3uZJgCaM194QMDPhw3blymkMK11rQY2S3ZEmio34zYM/pweDpkNA85z0GhyIL5g3myiaCWapoCPdyrGXvEMSD56BagWprBSFCsppzs0ZuskA5LU0R5OhHLPJmAWwReCT8y8/mT7U2Q== Received: from DS7PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:3b8::14) by SA1PR12MB6846.namprd12.prod.outlook.com (2603:10b6:806:25d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.36; Tue, 8 Apr 2025 08:11:29 +0000 Received: from DS3PEPF000099E2.namprd04.prod.outlook.com (2603:10b6:5:3b8:cafe::54) by DS7PR03CA0009.outlook.office365.com (2603:10b6:5:3b8::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Tue, 8 Apr 2025 08:11:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099E2.mail.protection.outlook.com (10.167.17.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 08:11:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:11:16 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:11:10 -0700 From: Xueming Li To: Bruce Richardson CC: Xueming Li , Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: check interrupt registration failure' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:10:39 +0800 Message-ID: <20250408081054.375502-1-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E2:EE_|SA1PR12MB6846:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bb682df-b461-41ae-5a94-08dd7674f6f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SbNjFkRHJ41WFHmZ2S8l6EvuxJuHrtM6TajxC7lujetBYLGgm/IPDsedTjW5?= =?us-ascii?Q?j7Whif8dWHXdx8e3ZpZRLZ565AVRvJonailSpT69AastH+13IzFi/9F3SLYL?= =?us-ascii?Q?/EwPSGuc04CSj6/P4t9qlBueveHP62Qe8+lIaeGSqMrnLKRYKED2vxPOyHdC?= =?us-ascii?Q?M+WafZ1oMHhjAcHj8L++XCrFsze0HiOVAz4iexUT4AyaqLr2GB1hG6es575Y?= =?us-ascii?Q?UxkjCN1YgsF/bQvpd8X3M1lPivCevXwpoveqkwVPCTy+q0lmDZVQzaVKpusx?= =?us-ascii?Q?ia8BjVNyCIV5Vw5DMtfJjExlFIZa+7TKO6/BFU4Xmxz6D8WEWpmjjsoQWHDk?= =?us-ascii?Q?5SjuzS+bbmojKZ+dtmijT+t7Rl050wST+0/szuPATIOLgbCkRgUk75hxh843?= =?us-ascii?Q?8HLYJzCX5cZ8n3a93XIN4Zl0pF1Ct4XYb6m3gT27eQIdQBQurgH97lAwSykj?= =?us-ascii?Q?t6dlNFCKZ1FdQdrQJiJSHd6UZf6CND/f2NEPtNDKOFynaRZvjXrCLhk+A29m?= =?us-ascii?Q?UajJ5NqO4Qmqaud1KnQHzA/WpBUUlMGcNhbwD7/Sc8SD3fKWbskkVKKxRaOM?= =?us-ascii?Q?p/9O6WX955DdB5WUVvACwTBCM8LUGhfuSmvdC0MaBxYmwW5xR2eIXe6dJsh5?= =?us-ascii?Q?l2nOKoMERDK+R+uTj9DPHV/6E+S6Uj7/AvW6Dzeiide4X6boCd6ZRCg/qWq1?= =?us-ascii?Q?h6LRRP2uV/yeRzXTG5Gev+HXJ8ZeGP7tBDxCL+r9g9Mm+QCo3XxCnQ8qFFP9?= =?us-ascii?Q?b5GFymvqxTHVDNuZPm5eyqpxFNpQzk4HeOC2Ly005jbFaokEXOt4J6P7rCpC?= =?us-ascii?Q?PJa8u+0uZZl/kgvanuPMwdaE59an7/+xTA2TkHxgvp0yDbiJ06Vt+Mru3jqg?= =?us-ascii?Q?l8qrD5hgRuGVwvnbizj/Zc3+2uwWAQGiYyvlEDRl/HT2jHS17XruHOs7tlxJ?= =?us-ascii?Q?EojVf6FohAwlcnfCQXYUVEkpd0FeM4g06MNuPv3yLteZuTKx1nkFrI+19oNJ?= =?us-ascii?Q?ZOnuD1keObURwri7a7pMaus8Rynik6BnjbFonoW0f0qFsS/pzKJGYeA2+8rc?= =?us-ascii?Q?tiEU/7zf/b7UjjgBG3y9S7ns/0Xt70AGT7b4OwAPIdX6RNTvj9A8wLPoTwZo?= =?us-ascii?Q?v0CkqBHvEX5NHGZ/rWgHsYFPwUZFToQGGP/Az+ZF6tE2igvomUe/QJ0y/QYC?= =?us-ascii?Q?psDrdQ42DTPTLMa1ocvganpmwRiOCIrWWxD5ljN/vPz8n7/evXMmktWekD0w?= =?us-ascii?Q?4pxYRvdcG3/CZND2Lc8gNs6nNZL/aIO56k2lPPo+01eC3qW8HYBSeFArCUXA?= =?us-ascii?Q?PCXcDGnA1HnWF3qppodt2vuGHkjDH0I4McojGehT/hBvp+UQxx0JJiM4bCb9?= =?us-ascii?Q?i6sWM25bKGqgd2if9PadDDAul72RyZJ/R9eFvgTvHyUWkvtYXlgr2kKIHbV4?= =?us-ascii?Q?Ft/f4V/Endi3nbxrq/CA7ry2uqORUxlqTXYfqIiPqDdksq0fpvF9mpcf1xeM?= =?us-ascii?Q?Ofwu3rr1iuHLqUw=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:11:28.6303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb682df-b461-41ae-5a94-08dd7674f6f0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6846 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=48a73ea8dcd161ae0a6842c122a4c1429b108b44 Thanks. Xueming Li --- >From 48a73ea8dcd161ae0a6842c122a4c1429b108b44 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:15 +0000 Subject: [PATCH] net/iavf: check interrupt registration failure Cc: Xueming Li [ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] When registering interrupts, there was no check if the registration of the interrupt succeeded. Add in such a check, and go to fallback path if the check fails. This prevents errors on FreeBSD due to missed admin queue messages. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 9f3658c48b..4971090001 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2738,18 +2738,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) ð_dev->data->mac_addrs[0]); - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) { - /* register callback func to eal lib */ - rte_intr_callback_register(pci_dev->intr_handle, - iavf_dev_interrupt_handler, - (void *)eth_dev); + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR && + /* register callback func to eal lib */ + rte_intr_callback_register(pci_dev->intr_handle, + iavf_dev_interrupt_handler, (void *)eth_dev) == 0) /* enable uio intr after callback register */ rte_intr_enable(pci_dev->intr_handle); - } else { + else rte_eal_alarm_set(IAVF_ALARM_INTERVAL, iavf_dev_alarm_handler, eth_dev); - } /* configure and enable device interrupt */ iavf_enable_irq0(hw); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.964496346 +0800 +++ 0035-net-iavf-check-interrupt-registration-failure.patch 2025-04-08 15:39:05.976436565 +0800 @@ -1 +1 @@ -From 12e8844f0bda3c4e4e578e180dfa0136f9285182 Mon Sep 17 00:00:00 2001 +From 48a73ea8dcd161ae0a6842c122a4c1429b108b44 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +19 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 12 +++++------- + drivers/net/iavf/iavf_ethdev.c | 12 +++++------- @@ -20,5 +22,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 9cd2b0c867..1ab84b0bfc 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -2825,18 +2825,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 9f3658c48b..4971090001 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -2738,18 +2738,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)