From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D76EE46532 for ; Tue, 8 Apr 2025 10:11:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFF454027F; Tue, 8 Apr 2025 10:11:36 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2082.outbound.protection.outlook.com [40.107.95.82]) by mails.dpdk.org (Postfix) with ESMTP id 1CD0240E4D for ; Tue, 8 Apr 2025 10:11:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i83SxU3Uxi+cpH+dX+1wW/wonGS+5xsWdiYj7A+K6fSB6syca6RiH5q9dvBzlqfw54jU87WWHlqChmHwX9TyyPg+qcfky7XK5wVTJpgFo80FAaCTR4sKo85BY583gpLcq5wCDvC+JMXEw+c+54ygKTsCnqxhxR+ONJL2KESWU1DMbv6C64uT4hBAt89NSihMY1jMHefLzpXeYM7eyhYhZDxuUcNcTkvPMrfPpcSKrQdylvcCRtfsDCh1paI7jNXj2dXTgNfhsxPe15Wm9vocFomjy5NB6mtlxZj3fHCmvaT0qpF6CJY8O1NXYfCAuQORlAvDwsIi/3Lt0BTqVgoMVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1DFFOqUc+V3ewATJIfR0iv+WNysPRGJmX25YIGfDOSQ=; b=QX8UAoRvES1/E83/7Y5b8DMDNQK/mzC3Bn3Hn4mg3CouFD4qRLBcwL9VU9cmot6pEOkX2GJJR+htQrBMJ9Qu0pDlQqLz+tjv8wy9+F/cizhMdoCsi64/47xkp+CmlaEb7R8nx5ikWEyiEH5xdKmIhJpsuqLI4G2a82GtPQDjRrPnRwku9irSM7a++Cl2ygmrdzPdbnx27lSvuQKKxvRPpupSTA2ZL4c8AQI3aLJZbHd7ks3tegyXBSqfYjh0AEClxjk7dJ+GVmssxUodfZaRuNMVCNMfXSnFx/86RUa99N8ojU3kJlG8uIxlPeaP4wIXwpa7jvLgA2f/AzmCIsJJDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1DFFOqUc+V3ewATJIfR0iv+WNysPRGJmX25YIGfDOSQ=; b=ZE1why/elYVHAnnozb0RDUl3GlWrZZN+isV/dvcT2hyDOOya1qtbyAouMhn6Tmwe5JzcP/8hvYaaP9IxPLRDBa9MYDQ9yS2uiFuyXhwA1T0+4QgcAeVBTIEuiK8SZN2KaEpkNQl5k3EQsSo4g0+y9FYMvnO2y0MRT0jSCrE/uZptaL0qP9p64yYq4v8rVwYibiXR3PKiPYPJ/xli6LX/KCHvqvfs6s4L/KG7cVzuR2FAPhmhKyGz//H13aTASP2tkjiMUjfsyMGr9EcRnECpt6EN7YnFMv2mDdDiDXv+VCkLWKxOZRYHVhcSszuJ919uIQd5gRngya8RUAASBjqCJw== Received: from BN9P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:13e::9) by LV2PR12MB5942.namprd12.prod.outlook.com (2603:10b6:408:171::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 08:11:32 +0000 Received: from BN1PEPF00004689.namprd05.prod.outlook.com (2603:10b6:408:13e:cafe::30) by BN9P220CA0004.outlook.office365.com (2603:10b6:408:13e::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Tue, 8 Apr 2025 08:11:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF00004689.mail.protection.outlook.com (10.167.243.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.13 via Frontend Transport; Tue, 8 Apr 2025 08:11:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:11:19 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:11:16 -0700 From: Xueming Li To: Bruce Richardson CC: Xueming Li , Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: fix crash on app exit on FreeBSD' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:10:40 +0800 Message-ID: <20250408081054.375502-2-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408081054.375502-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408081054.375502-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004689:EE_|LV2PR12MB5942:EE_ X-MS-Office365-Filtering-Correlation-Id: 92d5fa2a-b7dd-45a5-ed13-08dd7674f8d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Mib8ckRHhvlxQcar+RZ3nJLibQjERkrSI5nwo49ZiytrTA4xi1rwb7MqO6um?= =?us-ascii?Q?WbG5L9pLoKo5o77m6JA+eP0YZkTmEyEbsePGZGBYvBB0aXNyfnz/eLQr/hfP?= =?us-ascii?Q?2gAdnn2zwMvGrU6irqv9MmPZbeErmKMjeWFGgyavX6Qq961qaZkec9x+DpxN?= =?us-ascii?Q?w2stBZ8uM+zo7ByBToMIZObTszuGC2bifCthgoW8TUH4c7uwAPzUxWoN0Bpa?= =?us-ascii?Q?ws8SYCmnow0hgH6FUbqgHNY15GdwUjQLTzKV0F3YI/eYDcGyb5O+mhwkROAe?= =?us-ascii?Q?usYVWJVr9k1RqZZzSBARH8ai7clfX0xWNDgz6pAUxc6Pl+otojcgrCiKteBs?= =?us-ascii?Q?B06VlNsEvhEClXJlEFW4JGIAIYsPvQZ0xAEorH0CW7CiiiQ+3aDO2owhU2hR?= =?us-ascii?Q?IdyqpBa8e9lqGMFkyphK0/HY2W1nzVjygM7ozE36KQmU6X/j+Fi0p0MMQwIF?= =?us-ascii?Q?UYBs29AsG9grcrj4t0TkMMfuDphAjd+SxFbjokXsZ6HtyeSw1f24HkO3+fmj?= =?us-ascii?Q?Cb7JPiIL0l8C8DDUkSCZu+DBbHSQOvmTSfzeDSgH3ELbROMGWrnEe+KBP1Nd?= =?us-ascii?Q?rpSZtzXXJUbgT+okYcQhFwIMYCvnINJrm8SfOM4uFZcMwxmsnrZRNiWuybGs?= =?us-ascii?Q?My9BGnaL3ARaekUIIXEOy31TgrAy7cdyOCHmPbKqF9D5lqV6NKU/Dy2UpV6F?= =?us-ascii?Q?AXWqYorXLSY3hpAJPswsylN4i4iaHAX8D9gdZr73rqTnFV32WSo7VOu6nu+/?= =?us-ascii?Q?piebGa5n1faRmbNGrunlIB3ya3nzZC/Eoy1gAxYfBOs+6vxNJk51MH/WAnRD?= =?us-ascii?Q?+q0cwF6Gz545/0F2Mn4mNepvMO5O5e5FrwR1KnhqNPVfg6x3BBynMcD48gEZ?= =?us-ascii?Q?x6SuAM+t0ta41RFqr79Q7HvOMRdrhKNxzVHM5Eyn6vmiBpBgD4UcuVOCr788?= =?us-ascii?Q?pYo6NehdP0kV/mTjLumI4364xdbfdVfDTtSFLw8cfdzGwMu9o6dX/VLy2C/m?= =?us-ascii?Q?ccB4imnN5e7XbGNpyVuvOSihO9s0nzBW8tLSA6iegAbs57JE99xDSKcmzpJ0?= =?us-ascii?Q?OVJLCRfXltBaEcHYZx2s5kEbyP5jWRmiFTD8T87DC53pRBVL9Sn6UzzlQ/Xy?= =?us-ascii?Q?hPyNiAawV1godMImj/uahzvr2YJAqAQ9MkktP5f53OmOv9KPE4OaYS+n0iXS?= =?us-ascii?Q?Dn24BjkNcJR3Y7r1AklJrL7PJsSzG9D5NLSZuxSRfS7ZW4nqCSnQsuE/vDcz?= =?us-ascii?Q?lSk7AzCguYXRc8nIltJcHax3JdXjjlyt02BhEEAJjvHT2/N79rQwsKfYX/O/?= =?us-ascii?Q?5Qod9ND5yMuCBez+8D7oGt9w9SRQK1aqB8S9ELFN3VxBvQB8xaoXikgjv6mU?= =?us-ascii?Q?O3EnDEHQepl7OM96yvvwZs4EgIy4iM94UrZlXaSw9Klxe63q+WqUYlVS/aIG?= =?us-ascii?Q?jTI+fp5MfqldKeSD6pNQAHK/xxpOs1uN1qNz1FoWkgYDGgndPHirITxpH2Lz?= =?us-ascii?Q?79K9HrEYkjnC5ns=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:11:31.7904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92d5fa2a-b7dd-45a5-ed13-08dd7674f8d9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004689.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5942 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0316705217039b687eb16f1f79a90718297e90d5 Thanks. Xueming Li --- >From 0316705217039b687eb16f1f79a90718297e90d5 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:16 +0000 Subject: [PATCH] net/iavf: fix crash on app exit on FreeBSD Cc: Xueming Li [ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] With the fallback interrupt path now enabled on FreeBSD there are segmentation faults on app exit, due to the alarm interrupt trying to access invalid pointers. Add checks for null to fix these crashes. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 4971090001..4472fd2c2d 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2611,6 +2611,9 @@ void iavf_dev_alarm_handler(void *param) { struct rte_eth_dev *dev = (struct rte_eth_dev *)param; + if (dev == NULL || dev->data == NULL || dev->data->dev_private == NULL) + return; + struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t icr0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.991477837 +0800 +++ 0036-net-iavf-fix-crash-on-app-exit-on-FreeBSD.patch 2025-04-08 15:39:05.986436562 +0800 @@ -1 +1 @@ -From 44a86bcf2447d7d914d7195448285aa82eaedcba Mon Sep 17 00:00:00 2001 +From 0316705217039b687eb16f1f79a90718297e90d5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 3 +++ + drivers/net/iavf/iavf_ethdev.c | 3 +++ @@ -19,5 +21,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 1ab84b0bfc..2335746f04 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -2698,6 +2698,9 @@ void +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 4971090001..4472fd2c2d 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -2611,6 +2611,9 @@ void