From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C61246532 for ; Tue, 8 Apr 2025 10:12:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1419040E54; Tue, 8 Apr 2025 10:12:25 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2043.outbound.protection.outlook.com [40.107.92.43]) by mails.dpdk.org (Postfix) with ESMTP id 9071540A89 for ; Tue, 8 Apr 2025 10:12:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RA8Ifp7oc/euVI4iY+Z8HLuSPlwNO7VaXwDm1L8sRlGuB5gf90ZwCfNUJLmeHaROX10dlo3yR2Okwyo6F1CPObFS+RsFAD2G39qeUWoai5yP8Fz4+6qAqfGBuu9iCbrwV2JzuhB3bOsweupnDYDygsx1GUWdMbvSIVu4Vg4rCGr5l5knFBCKEe5tXDhbeYTtkj7pUd4w0z6gnxVndLUkZeDcnxiQSOl8H69M8gNN9I/NQPubNLCDFfMBXPj23oawIGaIlgovBtdfZfepZL0E0BmHhPlvUyF3hrsXvlv5397ajQW3kaIeCmxQhR5q9KolEj9PW9st3vkQtt4g9zDXPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z81bAmRSQCjXN/9npYjoinVrwjd4Cd6NEqco4xuHetI=; b=gHRuA0Ag8z/AQA8udTNUM2GdakqXtgAoqWeAJ+eOIRz9gBo6zIG6F9/oZsiHNrll0daLETqj2U6zyaiQs1j7h8s90gBCxRfXrlBCKqBIPymLK1U2H3OkAQYVBEqdUecyTmdfxPr/qn1K87TS1PGTgwu2o1HqfG6LPPbCcZ/55KwXJO+VzMceKR+xHA/ywyzuwMS03KcELG351v0DePj4/YnS+BkULQsFrPI1EOVPF36eyqKzLXpQUrmRrgE9+mp4cIsBNSFZzPiltpbeAuTzPZxjODvsKkZbg+eN67pVX+LCPq6bGZP5cxRrTZNPy9i8Hc6yP6C5kzOAWzoEXvSrbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z81bAmRSQCjXN/9npYjoinVrwjd4Cd6NEqco4xuHetI=; b=RwCpyWFk26vFIxSEjUFe6vvqutjL21/TQHIr8zrWYlnEq2lsJDtzNpTmZtJ+FT7oUxym83m6t5tDKbPWbheGCQpWXmjhA+mUg3xIZRn9WPA8Jag0GamsMNKErqvO2Qn1LXZx1kls6JeWHsRnobtfXpVJpnfjW3wf86jDWwiIA53VMt4HSa9EKbu/kzrhHqEgqNU+rMqYvpUDoZicpJt663wQBUr06FiZu4mqYDgWvIt3cv4i48iKU2TUssnuYY+SYdNxSFzuMJYq83pMz3Ksuzcba/YT3RqhYXgHNMnaBA5ZiaXgzOfqlwJ90f4GiVAsror+WfeJPkkF0BIXOwZOXQ== Received: from CH0PR03CA0065.namprd03.prod.outlook.com (2603:10b6:610:cc::10) by CYYPR12MB8991.namprd12.prod.outlook.com (2603:10b6:930:b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.42; Tue, 8 Apr 2025 08:12:21 +0000 Received: from DS3PEPF000099E0.namprd04.prod.outlook.com (2603:10b6:610:cc:cafe::89) by CH0PR03CA0065.outlook.office365.com (2603:10b6:610:cc::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Tue, 8 Apr 2025 08:12:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099E0.mail.protection.outlook.com (10.167.17.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 08:12:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 01:12:08 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 01:12:05 -0700 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Bruce Richardson , Vladimir Medvedkin , dpdk stable Subject: patch 'pdump: clear statistics when enabled' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 16:10:47 +0800 Message-ID: <20250408081054.375502-9-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408081054.375502-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408081054.375502-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E0:EE_|CYYPR12MB8991:EE_ X-MS-Office365-Filtering-Correlation-Id: efeccd73-d914-4a48-257b-08dd767515d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7ljImzB+DLi6Ojvjb79wQT/VzVcTzfxqpWJFNqrtNXTBYTk7KVY49zsYsoF3?= =?us-ascii?Q?dG0B+7iN0j7NPusy5HJGSkm62Sl0Nphm4SGck4XxB6W08mKSPMZdfB25lGuM?= =?us-ascii?Q?3N+w45fSiKYWAa91M8vSG4WKZ+i4ImYXNfqaT2xGFddca1gngKOrDrlY/2U9?= =?us-ascii?Q?n1Zyeg62EgGq0mLL0ghfQX3NlGeZOdml8vN9CkiawwWSF4vMVez15YvgkCgn?= =?us-ascii?Q?dng5r9wuOL/o+0dOEhurlp7wURQKUdakVh33yJDiWChktwyyWbLmkz0UjcnA?= =?us-ascii?Q?p93lR6Ffa/iHwLbRFflfMXLwFp+cBMmh2os8NwM8BN2x43rQVBFwbx037W/p?= =?us-ascii?Q?vmOlyYD1UPn9al3ZFwjMygKHosd8gTmkgwl7eTiCwdQA3aMpu7VfwwyMVv09?= =?us-ascii?Q?DGbknfanNChnmxGYmuRuZ+Kwka5GHrXuk00Fqi8XYdvxLMlJpvQneVo6epS0?= =?us-ascii?Q?TieRa9O82LJEEuvlpSbkYdb2o6eqCaLUeMuHmR69EMje55K7EcLLqfkkVS5w?= =?us-ascii?Q?LUt0C7vAA1ZZUi3k6DzBfL2FFh/m/SA9TX0od9vcS2hrqbksmhRRD1P6St7T?= =?us-ascii?Q?VnQoK3de7gRq33jgxdJDIT05cClJIgWDcGoj6YIgL4Ebuaeq1nMjOcLSn/bA?= =?us-ascii?Q?vzX4k9cnooGScvTW1Z5yDOD2aePzzFRpNhp9bpbHEr1eDQi1yC/7ius5E7Oj?= =?us-ascii?Q?Fp7XiY0/wIJJk4ikpFTX0dSHg1e/BzMpNgZnQcHzLfV+LxVBjYtuu70gxI44?= =?us-ascii?Q?LykKQnSfTPvW99xByh99uBEg1DIo2ElG1+Z+kKMJBt8L2QhOjTz8MP/9wAFU?= =?us-ascii?Q?N0Y0n04UCSYmuEA/mSHPj/n6NEGaMZX1KpuSSgXFH+6tXiBb6noKdP7Yb1v1?= =?us-ascii?Q?ai46AI3bvTdSC8H3UUoDAuznECtaJhjvdIy4bi02FBN6OG1ZSjiYLIeiMVSw?= =?us-ascii?Q?AfV0D4cng/VFmgn72GWDzFBby+KYXDOAt3Yq1uPxonVGVLd8r7NYcY3utQcD?= =?us-ascii?Q?TkuVLq5vjC9WlY4NdPlRFcAcR0r5YS9fB31pRog/yms9WBEjvRkaiNlL1lXr?= =?us-ascii?Q?QPtMZ8pVz1ocZObp5KpJU9PNc1FkmlqZ1dggskaVlC1Mz4iawmtWaiVGOd2J?= =?us-ascii?Q?PSLpJINJhBSA8J2SvsqnX+guVW3IyDYUmob2JJgsTRJMszgWHBYduEp0kbXz?= =?us-ascii?Q?Nlqu2ewVbiI2K8bhStzny+IfPAV0Cy0kWXFegtXBsYCVMTlSojNIL5qOzEA1?= =?us-ascii?Q?lLdXv4p56wnJ1Au/i2pqQhh90Jh+xfB+LPIMttMxm38BpqUyOX+TXh0x5tw2?= =?us-ascii?Q?I84kVGOYuy4nX5TXSB7DadTQx/wkQ+C9Y1lH1dn2P+kDqOE1NCxOJEwJunrR?= =?us-ascii?Q?lyVj36BTS/Ei6z0KM/1q3O4/tC/ZZzkDLUbxYU2njvGWe5rvMGKVfKZaZ4av?= =?us-ascii?Q?oDXCW/4KPlH2q/mt5yOm3qyney6oyViFSTBTWfEtWWNErFrsIoW8oIgO2Yrq?= =?us-ascii?Q?pAx/nXBGXqJ4+LI=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 08:12:20.4417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efeccd73-d914-4a48-257b-08dd767515d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8991 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7390205d1311798606e02388b012620706293d5b Thanks. Xueming Li --- >From 7390205d1311798606e02388b012620706293d5b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 19 Dec 2024 15:58:53 -0800 Subject: [PATCH] pdump: clear statistics when enabled Cc: Xueming Li [ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] The pdump statistics are used to keep track of the number of packets captured, filtered, etc. These need not be cumalative and instead should be start counting when capture starts. This fixes the issue where multiple invocations of dumpcap would include counts from previous invocations. Bugzilla ID: 1604 Fixes: 10f726efe26c ("pdump: support pcapng and filtering") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- lib/pdump/rte_pdump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 5a1ec14d7a..56e1a8d598 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -200,6 +200,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, rte_errno); return rte_errno; } + + memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; @@ -258,6 +260,7 @@ pdump_register_tx_callbacks(enum pdump_version ver, rte_errno); return rte_errno; } + memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:07.182378375 +0800 +++ 0043-pdump-clear-statistics-when-enabled.patch 2025-04-08 15:39:06.046436542 +0800 @@ -1 +1 @@ -From b8392fa204ed46b580d61e7621948f1b187c9f98 Mon Sep 17 00:00:00 2001 +From 7390205d1311798606e02388b012620706293d5b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 679c3dd0b5..0e6ffc167b 100644 +index 5a1ec14d7a..56e1a8d598 100644 @@ -28 +30 @@ -@@ -199,6 +199,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, +@@ -200,6 +200,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, @@ -37 +39 @@ -@@ -257,6 +259,7 @@ pdump_register_tx_callbacks(enum pdump_version ver, +@@ -258,6 +260,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,