[PATCH] net/ixgbe: fix port mask default value in flow director

[PATCH] net/ixgbe: fix port mask default value in flow director

[Yuan Wang]

The fdir filter should mask L4 protocol in order to process raw IP packets.
However, the initial value of port mask is 0xFF and the filter will not
process raw IP packets if the flow rule does not change it.

Fixed by setting the default value to 0.

Fixes: 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)
Cc: stable@dpdk.org

Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
index 33da2f47ec..1e3804bb15 100644
--- a/drivers/net/intel/ixgbe/ixgbe_flow.c
+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
@@ -1644,6 +1644,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 	memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
 	rule->mask.vlan_tci_mask = 0;
 	rule->mask.flex_bytes_mask = 0;
+	rule->mask.dst_port_mask = 0;
+	rule->mask.src_port_mask = 0;
 
 	/**
 	 * The first not void item should be
-- 
2.47.1

RE: [PATCH] net/ixgbe: fix port mask default value in flow director

[Xu, HailinX]

> -----Original Message-----
> From: Yuan Wang <yuanx.wang@intel.com>
> Sent: Friday, April 18, 2025 3:43 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; dev@dpdk.org
> Cc: Wang, YuanX <yuanx.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix port mask default value in flow director
>
> The fdir filter should mask L4 protocol in order to process raw IP packets.
> However, the initial value of port mask is 0xFF and the filter will not process
> raw IP packets if the flow rule does not change it.
>
> Fixed by setting the default value to 0.
>
> Fixes: 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
Tested-by: Xu, HailinX <hailinx.xu@intel.com>

Re: [PATCH] net/ixgbe: fix port mask default value in flow director

[Stephen Hemminger]

On Fri, 18 Apr 2025 15:43:09 +0800
Yuan Wang <yuanx.wang@intel.com> wrote:

> The fdir filter should mask L4 protocol in order to process raw IP packets.
> However, the initial value of port mask is 0xFF and the filter will not
> process raw IP packets if the flow rule does not change it.
> 
> Fixed by setting the default value to 0.
> 
> Fixes: 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>

Ok, but Intel needs to remove flow director by 25.11.
It has been on the deprecation list for years.