From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3654A465FD for ; Tue, 22 Apr 2025 17:52:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 100134060B; Tue, 22 Apr 2025 17:52:07 +0200 (CEST) Received: from mail-wm1-f98.google.com (mail-wm1-f98.google.com [209.85.128.98]) by mails.dpdk.org (Postfix) with ESMTP id 4427F402E2 for ; Tue, 22 Apr 2025 17:52:04 +0200 (CEST) Received: by mail-wm1-f98.google.com with SMTP id 5b1f17b1804b1-43ede096d73so39514425e9.2 for ; Tue, 22 Apr 2025 08:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1745337124; x=1745941924; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zHPssj39VGFIIkgqBoFARWtn4d+9iP+BTx8Pz7s6cb4=; b=BWDMJlcpqnHA+KMqgKHD29+9zEHCWF174CR+HA3WN4nlVFjvDgAwlMrxrPSAW0VShi wOyPeQE1xoXY3zXtUHQ7i/QvT5ABo1nJNRykoxmgIrpZoNNoeJAUDSSfxI+JNfEmWkrh uaUOzYKkQPPphfux5uUQUZrYEw73luD/ZXr+bQg919jhIbOEogLxgGQpjGth26oFA9IF vY3bRL3CcPRuYyfrQxI5S4XJKhmbXndKjqfF+M29WVjO3vdY6LbKL75dsydTl7WLBtos aZkJCRFESOkpP8HPgqwBQlA0SnMQaz2x/Jg4iIwBdf1KEoBbiznlMlnRQhMVe2hCqYzm 3oEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745337124; x=1745941924; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zHPssj39VGFIIkgqBoFARWtn4d+9iP+BTx8Pz7s6cb4=; b=ChC4YodYDxY66D57s9girfrkdxfW1QERQHE2Gae5pKXL7YM+pX/Y/mTd/7Ji/7PI45 lA6ZbWmUAcwX+spCWR2HoxHeX5sreJQF2DU9KCwKq5/oOlSt9BIwTjTOgnCVCmEZaS8b Rt/XKtk5Q6ZdhMKU8hNRi8nnK4UCkujorlmjGx7Q80zKVY2kCX4RzbjVH8KJXKGsVNLn vBzhq0/iZfvH6sQOjm+/1FYw6+eVW+2hLFVVkXacdpEnVTtwO58LNKXbGGBX7WV+nlLL pJZ173hHrCODgkH6kXh6uQc3AeGDGQTxJgEqAug5C6oAseX1b+vTqMolAhrvy1ycAATV 0zRg== X-Forwarded-Encrypted: i=1; AJvYcCUjey47U29DRrZ+IXpzI6yB08PEVqq8Gv283UO29ddam9O6viFWJTrvMOesulsVoJTnpYRqwIY=@dpdk.org X-Gm-Message-State: AOJu0YwCttK7wlZ+pM5pS95a2BEqro3m/WEZFiNCZuUBkhU2HRMrdoX1 1X1nePJltxF8g+2PTqjS026b7iv967E4YkKsa8/x968Wu4GIRG0/a/7ySRzFZdwXhbt6myH1jZb 82nrg+il1fiVfyPhCwRDM6sXJ9mIXGTx6 X-Gm-Gg: ASbGncvBVi/gWPicptOp2KGFZ3OIbtUBlYycj6dvfjNKmEVyc+RWLIGh3QiN0XSRAWw vsKBpP4TT+JEkEo9NFngldoeYbc9Jhf+JpDul35AsrF7yGhzsAxPkADPqjDbxP7Z+aGwspeGpJ4 mx/B98KSckoBX+0PrkAeedWQDCoReBFZdyg4k6kt5hRUQnqd9se2uspY26TzO905Foj8jOEhENO Wg3qAfDJqwDsT2pUMHYF51AOVwn4JTpzsVQ8tAzd9iB71VHg7RqOiM/lzAmrtKMhbkOq+FDacEf RxzGAmI6PSHrPRBR0Er/ge7QpZvebSbK+rnMY80gZc5NjHaidT2OsojrklRjH9b8JTA= X-Google-Smtp-Source: AGHT+IFvvOrBG0TfeuBmPVgL1rXvzT+JcoRpyInqlIW5PZmgVOXdZP5kBLeg3m++nmQqZ3bQsXRRjllaTDry X-Received: by 2002:a05:600c:1d02:b0:439:86fb:7340 with SMTP id 5b1f17b1804b1-4406ac412c4mr163556955e9.30.1745337123851; Tue, 22 Apr 2025 08:52:03 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id 5b1f17b1804b1-4406d5bf7cfsm9120505e9.22.2025.04.22.08.52.03; Tue, 22 Apr 2025 08:52:03 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (dio.dev.6wind.com [10.17.1.86]) by smtpservice.6wind.com (Postfix) with ESMTP id 93FA9360DA; Tue, 22 Apr 2025 17:52:03 +0200 (CEST) From: edwin.brossette@6wind.com To: dev@dpdk.org Cc: olivier.matz@6wind.com, didier.pallard@6wind.com, lauren.hardy@6wind.com, dsinghrawat@marvell.com, palok@marvell.com, Edwin Brossette , stable@dpdk.org Subject: [PATCH 3/5] Revert "net/qede: fix maximum Rx packet length" Date: Tue, 22 Apr 2025 17:51:41 +0200 Message-Id: <20250422155143.3893525-3-edwin.brossette@6wind.com> X-Mailer: git-send-email 2.35.0.4.g44a5d4affccf In-Reply-To: <20250422155143.3893525-1-edwin.brossette@6wind.com> References: <20250422155143.3893525-1-edwin.brossette@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Edwin Brossette This reverts commit d8ded501e05ce879f27f0ed1df7721a88b737e25. The maximum length for Rx packets computed in qede_rx_queue_setup() takes Ethernet CRC into account. This is not consistent with the value computed in qede_set_mtu(). RTE_ETHER_CRC_LEN should not be added to max_rx_pktlen, as HW does not include CRC in received frames passed to host. The original commit tries to fix another bug with this inappropriate patch: packets with size nearing MTU limit are being dropped. This is not because CRC length is not being accounted for in Rx buff size, but because of the flooring applied to it: the rx_buff size computed is lower than expected because we try to align it. This issue will be fixed in the following patch. CC: stable@dpdk.org Signed-off-by: Edwin Brossette Acked-by: Didier Pallard --- drivers/net/qede/qede_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 601fcb30b357..fe839a6ba844 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -235,7 +235,7 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qid, dev->data->rx_queues[qid] = NULL; } - max_rx_pktlen = dev->data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; + max_rx_pktlen = dev->data->mtu + RTE_ETHER_HDR_LEN; /* Fix up RX buffer size */ bufsz = (uint16_t)rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM; -- 2.35.0.4.g44a5d4affccf