From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: [PATCH] net/ice: fix support for 3 scheduler levels
Date: Tue, 6 May 2025 11:34:14 +0100 [thread overview]
Message-ID: <20250506103414.892849-1-bruce.richardson@intel.com> (raw)
When using only 3 scheduler levels, the VSI node needs to be a node
further down the scheduler hierarchy, rather than one up it as with all
other possible level settings (5-9). Take account of this possibility in
the code.
Fixes: 4ace7701eb44 ("net/ice: provide parameter to limit scheduler layers")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/ice/ice_tm.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/intel/ice/ice_tm.c b/drivers/net/intel/ice/ice_tm.c
index ff3a6cd77f..f2d8e12181 100644
--- a/drivers/net/intel/ice/ice_tm.c
+++ b/drivers/net/intel/ice/ice_tm.c
@@ -818,6 +818,18 @@ commit_new_hierarchy(struct rte_eth_dev *dev)
uint8_t qg_lvl = q_lvl - 1;
struct ice_sched_node *new_vsi_root = hw->vsi_ctx[pf->main_vsi->idx]->sched.vsi_node[0];
+ /* handle case where VSI node needs to move DOWN the hierarchy */
+ while (new_vsi_root->tx_sched_layer < new_root_level) {
+ if (new_vsi_root->num_children == 0)
+ return -1;
+ /* remove all child nodes but the first */
+ while (new_vsi_root->num_children > 1)
+ free_sched_node_recursive(pi, new_vsi_root,
+ new_vsi_root->children[1],
+ new_vsi_root->vsi_handle);
+ new_vsi_root = new_vsi_root->children[0];
+ }
+ /* handle case where VSI node needs to move UP the hierarchy */
while (new_vsi_root->tx_sched_layer > new_root_level)
new_vsi_root = new_vsi_root->parent;
--
2.45.2
reply other threads:[~2025-05-06 10:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506103414.892849-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).