From: Dhanya Pillai <dhanya.r.pillai@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org,
Waldemar Dworakowski <waldemar.dworakowski@intel.com>,
stable@dpdk.org, Dhanya Pillai <dhanya.r.pillai@intel.com>
Subject: [PATCH v3 01/10] net/ice/base: fix type conversion
Date: Tue, 27 May 2025 13:17:20 +0000 [thread overview]
Message-ID: <20250527131741.7606-2-dhanya.r.pillai@intel.com> (raw)
In-Reply-To: <20250527131741.7606-1-dhanya.r.pillai@intel.com>
From: Waldemar Dworakowski <waldemar.dworakowski@intel.com>
In ice_sched_move_vsi_to_agg() int16 is used to pass 8 bit value
what causes compiler warning:
warning C4244: 'function' : conversion from 'UINT16' to 'UINT8',
possible loss of data
Changed variable type to avoid conversion
Fixes: 29a0c11489ef ("net/ice/base: clean code")
Cc: stable@dpdk.org
Signed-off-by: Waldemar Dworakowski <waldemar.dworakowski@intel.com>
Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
drivers/net/intel/ice/base/ice_sched.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/intel/ice/base/ice_sched.c b/drivers/net/intel/ice/base/ice_sched.c
index 1f520bb7c0..a8a149f541 100644
--- a/drivers/net/intel/ice/base/ice_sched.c
+++ b/drivers/net/intel/ice/base/ice_sched.c
@@ -2383,7 +2383,8 @@ ice_sched_move_vsi_to_agg(struct ice_port_info *pi, u16 vsi_handle, u32 agg_id,
u16 num_nodes_added;
u8 aggl, vsil;
int status;
- u16 i;
+ u16 j;
+ u8 i;
tc_node = ice_sched_get_tc_node(pi, tc);
if (!tc_node)
@@ -2409,9 +2410,9 @@ ice_sched_move_vsi_to_agg(struct ice_port_info *pi, u16 vsi_handle, u32 agg_id,
num_nodes[i] = 1;
/* Check if the aggregator subtree has any free node to add the VSI */
- for (i = 0; i < agg_node->num_children; i++) {
+ for (j = 0; j < agg_node->num_children; j++) {
parent = ice_sched_get_free_vsi_parent(pi->hw,
- agg_node->children[i],
+ agg_node->children[j],
num_nodes);
if (parent)
goto move_nodes;
--
2.43.0
next parent reply other threads:[~2025-05-27 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250527131741.7606-1-dhanya.r.pillai@intel.com>
2025-05-27 13:17 ` Dhanya Pillai [this message]
2025-05-27 13:17 ` [PATCH v3 02/10] net/ice/base: fix typo in media type check Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 03/10] net/ice/base: fix integer overflow issue Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 05/10] net/ice/base: fix typo in desc for dev ID 579F Dhanya Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527131741.7606-2-dhanya.r.pillai@intel.com \
--to=dhanya.r.pillai@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=waldemar.dworakowski@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).