From: Dhanya Pillai <dhanya.r.pillai@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Ian Stokes <ian.stokes@intel.com>,
Paul Greenwalt <paul.greenwalt@intel.com>,
Alice Michael <alice.michael@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, Dhanya Pillai <dhanya.r.pillai@intel.com>
Subject: [PATCH v3 02/10] net/ice/base: fix typo in media type check
Date: Tue, 27 May 2025 13:17:21 +0000 [thread overview]
Message-ID: <20250527131741.7606-3-dhanya.r.pillai@intel.com> (raw)
In-Reply-To: <20250527131741.7606-1-dhanya.r.pillai@intel.com>
From: Paul Greenwalt <paul.greenwalt@intel.com>
Found a typo in original implementation of ice_set_media_type,
where one of the checks for FIBER checks for C2C media type
instead of C2M. This results in failure of this check for some
AOC devices, consequently setting the media type as AUI.
Bug was found in ethtool.
Fixes: e7bd7d54a26b ("net/ice/base: improve PHY media capabilities handling")
Cc: stable@dpdk.org
Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
Signed-off-by: Dhanya Pillai <dhanya.r.pillai@intel.com>
---
drivers/net/intel/ice/base/ice_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/base/ice_common.c b/drivers/net/intel/ice/base/ice_common.c
index fce9b070cf..69070b740e 100644
--- a/drivers/net/intel/ice/base/ice_common.c
+++ b/drivers/net/intel/ice/base/ice_common.c
@@ -452,7 +452,7 @@ static void ice_set_media_type(struct ice_port_info *pi)
((phy_type_low & ICE_MEDIA_OPT_PHY_TYPE_LOW_M ||
phy_type_high & ICE_MEDIA_OPT_PHY_TYPE_HIGH_M) &&
(phy_type_low & ICE_MEDIA_C2M_PHY_TYPE_LOW_M ||
- phy_type_high & ICE_MEDIA_C2C_PHY_TYPE_HIGH_M)))
+ phy_type_high & ICE_MEDIA_C2M_PHY_TYPE_HIGH_M)))
*media_type = ICE_MEDIA_FIBER;
/* else if PHY types are only DA, or DA and C2C, then media type DA */
else if (ice_phy_maps_to_media(phy_type_low, phy_type_high,
--
2.43.0
next prev parent reply other threads:[~2025-05-27 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250527131741.7606-1-dhanya.r.pillai@intel.com>
2025-05-27 13:17 ` [PATCH v3 01/10] net/ice/base: fix type conversion Dhanya Pillai
2025-05-27 13:17 ` Dhanya Pillai [this message]
2025-05-27 13:17 ` [PATCH v3 03/10] net/ice/base: fix integer overflow issue Dhanya Pillai
2025-05-27 13:17 ` [PATCH v3 05/10] net/ice/base: fix typo in desc for dev ID 579F Dhanya Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527131741.7606-3-dhanya.r.pillai@intel.com \
--to=dhanya.r.pillai@intel.com \
--cc=alice.michael@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=paul.greenwalt@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).