From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF61846B72 for ; Mon, 14 Jul 2025 17:12:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8AAF400D5; Mon, 14 Jul 2025 17:12:10 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id D2ADF400D5 for ; Mon, 14 Jul 2025 17:12:09 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45555e3317aso18412395e9.3 for ; Mon, 14 Jul 2025 08:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752505929; x=1753110729; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3YLWFEEEzsGGM/8adfDOrNGuOZrbY6oQpMOuTVwHBks=; b=AizJVgfx0bcrP4yCJkE9cuKwF1rXNDRyhAwp5Nu5gs0jm5cMDSj8TgaILOe0mwsLVd Sti6tcJoT0FuAX6u1SK7ym6J30abIhTmXgy3ys+9T/bX5a7vvRlTOv2lFZrBQ5PtTRCp zTXeY9pF5uVP9/k0DMc84KC5Qc7xzC005AHlHE3TpYXnnRAvKk6OwBTBgEpQsHpawH3K NlillgmrQuzD9pgHvBdPDBKhB3fBHXJirIduGRKEsBdjouuZH1vGysT/42WzKkSmufg/ 0uXcKwpIdN+eqxH1RSzUv3CziPXbT2SVZsGnyxEfM1AqWxfkUPmiEMPwT9eF3S3r++Ko aIeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752505929; x=1753110729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3YLWFEEEzsGGM/8adfDOrNGuOZrbY6oQpMOuTVwHBks=; b=XVJt/rKVmp9wgZsKp/Z6bNk1EjdyFHNtACfIceYfSgmD1DOF3YweZzYvQdjFBTq9OT SHZTqEl4dmrPv0yfC6y2S95EUDCcNvwRDksdBh4cctK5UfehpU29lbdBCBpUczk7K5HK I+dnbbq+zo4Qa71z+oONqu6vhvXxJ14uNsDrxdp7QsvJ1dVMN/8DwFDL6QG99m+jrL4r lMZIiWlwCbLjiScu0BAMuMBCIaOxwKbes40y+OWvd5C095mG5UOI3+eQbLSngMbXg+4V H7g2Fgmw/oi4ZXCz6xDHMW4A11pQ+osa2C2S0kW3yLDpYkB89y4wJfmCkUrVFup9xaFV UiKg== X-Gm-Message-State: AOJu0Yzp2GGYOPhKCranE0S27HUkpxI1Va+IMpY8NcCyILzeyNH7m/Zv XdnBjPnQ87xrWTDm0DCcdVzmKVcSWc/kHaN4kMiROd+mf7RqgCOHPiKKLuQLllZw X-Gm-Gg: ASbGncuCRUdtiw7Am/QvFWjWcuigbtuj0mHLQHZffmlQwwCkigHbIDiW/VR3p48AErD YFuB1iG5JnrqaiHEn2fhagtO5mEY9hhWkUzjMDErxcwZiBayVbOttOUKObwKb9YSgPX3KqI/+QR XvIrSfV4+BuDZBNBNqvSwPJ9+uui36BSRVN5VBDHKbWnKrp6PkpiNAQnL3lO3vLmCqg7IhsRGe+ nmxpMqslC+4wHESoZusTKwjYmsptTLdgXxJLZzHLlM8S6uythTsmr6lY8hL4rPd3QULUJW/WdZw uoAhdwmQJGAU2CLHA9CX8j1vFOdHubEvAUk9pKsGNJjjZmV08HBxegwq/wnH+L6r5EbW8eCTigt K5/FwQGcCIu5+zLmMMxd+P6FucdDv X-Google-Smtp-Source: AGHT+IFmb/37c8A5CnIS7hLAWIobMYdaQ3OnRfTsesLiLVZiHBphl+54xnoi9RUSfNpY2rFdztabCg== X-Received: by 2002:a05:600c:1c8f:b0:456:2212:46b8 with SMTP id 5b1f17b1804b1-45622124965mr15690565e9.28.1752505929164; Mon, 14 Jul 2025 08:12:09 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:a923:75e5:f97f:ef33]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-456030270f8sm79487115e9.22.2025.07.14.08.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 08:12:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix ntuple filter parsing' has been queued to stable release 22.11.9 Date: Mon, 14 Jul 2025 16:10:56 +0100 Message-ID: <20250714151121.219866-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250630122556.1133654-23-luca.boccassi@gmail.com> References: <20250630122556.1133654-23-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7fb125f4c4443fe575d12ae2d9eebb6cb2de40d9 Thanks. Luca Boccassi --- >From 7fb125f4c4443fe575d12ae2d9eebb6cb2de40d9 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:44 +0800 Subject: [PATCH] net/txgbe: fix ntuple filter parsing [ upstream commit bed0e6aba0aef7a1e67d3ee620873817f00a511d ] The rule is incorrectly parsed to ntuple filter when setting the pattern likes: flow create ... ipv4 / udp dst is ... / raw ... / end actions ... / end It causes the rule to be created successfully, but not works. Fix it to parse for FDIR rules. Fixes: b7eeecb17556 ("net/txgbe: parse n-tuple filter") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7b18dca7e8..4186562665 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -361,7 +361,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, if (item->type != RTE_FLOW_ITEM_TYPE_END && (!item->spec && !item->mask)) { - goto action; + goto item_end; } /* get the TCP/UDP/SCTP info */ @@ -490,6 +490,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, goto action; } +item_end: /* check if the next not void item is END */ item = next_no_void_pattern(pattern, item); if (item->type != RTE_FLOW_ITEM_TYPE_END) { -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-14 16:09:40.767717430 +0100 +++ 0001-net-txgbe-fix-ntuple-filter-parsing.patch 2025-07-14 16:09:40.680448281 +0100 @@ -1 +1 @@ -From bed0e6aba0aef7a1e67d3ee620873817f00a511d Mon Sep 17 00:00:00 2001 +From 7fb125f4c4443fe575d12ae2d9eebb6cb2de40d9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bed0e6aba0aef7a1e67d3ee620873817f00a511d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 1d854d0767..269f0b54e3 100644 +index 7b18dca7e8..4186562665 100644