From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53F1846B72 for ; Mon, 14 Jul 2025 17:12:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 499E24042C; Mon, 14 Jul 2025 17:12:33 +0200 (CEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 10FB54042C for ; Mon, 14 Jul 2025 17:12:32 +0200 (CEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-455b00339c8so20923705e9.3 for ; Mon, 14 Jul 2025 08:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752505952; x=1753110752; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rI1iyqRYsEppErbIKtWsIBUQdpkBqRQ/Uco+IHHlKKM=; b=QxYCiDPR+OaGNHbvtJTziQa4IPGietgEG1Tutdk6uZMVT5CmxRMaxr+FLcU3cIhk1K HizNJwp3RyyZmLs5zkF2DlxWJFpb0ybj2IG6eiQ+Azb5r1aAPgDiaUIhdkjFuAiJe/cT 9796VoEv4oHGB2BCHzI7SoNbU/RT695ijVuujiwGxsZG5Wy1KeLdPh8hUHVMxFbKJLbr AO0F6Qnbwp14Lho3cYvcUMjn7J9bYSHbF/UjvKpQdH/fL9d9cua4jxNcDF206LbMnYe2 91wa5k0sEfEuxeDDa6hT1TKGyMjNaNa9uFsTI88yeHQlFclgL+Ce4EZNHBTUaQsuKZa0 HH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752505952; x=1753110752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rI1iyqRYsEppErbIKtWsIBUQdpkBqRQ/Uco+IHHlKKM=; b=J8Oao88egZeYzJqyQyxhWLc7tLxL8Oglg5A9EEjuzL7TUm7K5dBo1Uz7w5p+QIwNIW ETuxMyPGJo3MHa60wn0Z3/mEUA3evbgFLpTJ+2q0YXnf0P0tvFK1ZOse7sTZcqwW/UJP LYxJd0y/P7Cky0f/WV+iGmzR0lVnJmWrKLJTEVxt9jn52rdbeCmO6ojC9VZh+ti2CJOd aObC1Be09bFzrQKbTmpG811C1y0vuA1XHyuR3p1EBXvK9J+XvDKpccrgVbunEW18jhuS QjXQF5xe6L+3MTMPKrGh1DPYSw/w7JQRjxSj1dzT0f0Rdj6MtUkWlT0bpWvSfSrv7Zpk S5rA== X-Gm-Message-State: AOJu0YyxET2lY1yExyf4ldaRAUUD0CLBAIMTKCZgkUghnDLCgSv8GSXq h2qQ1sbHreJVy6/JI+OSLAhOO8fLLKj+cmOjZJhYOBQj0pGM7efJ1eMnJBpTFpR7 X-Gm-Gg: ASbGncsXfZuLJrcEC/TmVkJp+ja54C3RCSqayW9asxPRu5aaAhJlYzbZIUuzckMDgHW G+qYeXfJld0L9WESYk1HQC/BEkQU/1aTgbAaIIPGnfXV7pLlDiOKp8m2s2aQ16M+3DhutNQU6s/ WfZgYNXfr9KnRLV+fGm9EhtKJKOwoc26McsRF1R2our+rWSi1T9yLW6ZsPbetM0H3h2wz6uGU4C ggcDRqeSLZwbmLH+Q+tJ6UXu5JB20v5vlxIBXjenPZjY4ZuaRIi/3IokPnquBaX7EN5BzcHKoqY M/+aWfp6V5oR1pnKrwQ01e08zUqaCcMYwvI2y7zyNtwWtFGjgfj7nnP1hVRFit3HxPYlpkVUWVd ySUmy171kbEiKgXl+gk2luejY9526 X-Google-Smtp-Source: AGHT+IHn9AzXQKTHkFYxhmpAxDLzvb6SUgH8RJxH1QG/MWDUU5I6J9PQQhDiWEsxiWitjezCgWMqFg== X-Received: by 2002:a05:6000:4022:b0:3b6:938:86b7 with SMTP id ffacd0b85a97d-3b6093886bbmr200890f8f.35.1752505951446; Mon, 14 Jul 2025 08:12:31 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:a923:75e5:f97f:ef33]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-455f222e4f4sm95460365e9.10.2025.07.14.08.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 08:12:30 -0700 (PDT) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix device statistics' has been queued to stable release 22.11.9 Date: Mon, 14 Jul 2025 16:11:05 +0100 Message-ID: <20250714151121.219866-10-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714151121.219866-1-luca.boccassi@gmail.com> References: <20250630122556.1133654-23-luca.boccassi@gmail.com> <20250714151121.219866-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ff8e0566e2ec8d3b8102523854a664b546c4f9d4 Thanks. Luca Boccassi --- >From ff8e0566e2ec8d3b8102523854a664b546c4f9d4 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:56 +0800 Subject: [PATCH] net/ngbe: fix device statistics [ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index deaf415623..79303a76ef 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1421,7 +1421,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, NGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, NGBE_MACRX65TO127L); @@ -1440,7 +1440,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-14 16:09:41.088524357 +0100 +++ 0010-net-ngbe-fix-device-statistics.patch 2025-07-14 16:09:40.704448810 +0100 @@ -1 +1 @@ -From a65009b7621a60faeb1bbefe65160eb5646925dc Mon Sep 17 00:00:00 2001 +From ff8e0566e2ec8d3b8102523854a664b546c4f9d4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index a8f847de8d..d3ac40299f 100644 +index deaf415623..79303a76ef 100644 @@ -26 +27 @@ -@@ -1429,7 +1429,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, +@@ -1421,7 +1421,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, @@ -35 +36 @@ -@@ -1448,7 +1448,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, +@@ -1440,7 +1440,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw,