From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB35246B72 for ; Mon, 14 Jul 2025 17:12:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E53254042C; Mon, 14 Jul 2025 17:12:47 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 002ED4021F for ; Mon, 14 Jul 2025 17:12:46 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-45617887276so10502005e9.2 for ; Mon, 14 Jul 2025 08:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752505966; x=1753110766; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4GmeJnn0yPtyaEQ430L5fM+kpsPCbFt3IQsd//D3hYE=; b=DRKvRN1CE//3FPFSijYiewvWpTmL02dHAS9IVAvoJ4hDS9hLG9wYr1KWNYX96HloRJ qLikuGP7keJcf/q2kiOcDwBIVbM0dS5CnN3k5Q7eppU0nMPwjsBXHEsn9/9oVYY1J88G NuLgu68bxe9Q7pQiwb0uUUQcG3MsuNy9d0e3BtOFO8AI89xF0h+69NCU3xhUGEUViecT uhIpsM73OHihoO/jqf8vxDbLEe9srlhUMREjAxxf8455KlbogJe19JmIG5wjZDDyQzG3 lK0wJ9pqI1KIQy8ba/Vgo8TfQJS/CGfdAIRVjsCE+4/+RxukybBM175hSpLNCnrAPK3c WDNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752505966; x=1753110766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4GmeJnn0yPtyaEQ430L5fM+kpsPCbFt3IQsd//D3hYE=; b=MeMVadZUCoc8ZxAMPlDBS/AGwCKC6Oy7Dr0Vz/UV+7LosLl9e0XpDXo4rnuD+Ml7VP I7MpsEvTXqvPRvHh20eKbhrvlqm7NkxpsYMsiZmZbVNuRsFLh3vk6nyuv91NXvPea6ja gkt+CPFbLm5/LRX+LBskuwmNeu5tZGQYfQzhECkqI39iI58kolndIvRbcF2+QJjvBV9w /6fi9sfx6k80zrFRaSW6J7H8ETApDAIkE3upcH5TnKQpU1QjQqHCIPS2s86XXpqSCLsL pD4XcDIM3KLCLNRv4l1ZSwt1DmmW19jAEkAgoXfHepsHc8vP7pVX5H5M+B5c5yovRjEA OvkA== X-Gm-Message-State: AOJu0YzKeqOmB+gRKoR+sJp0icvdb7Y1sUUHYmNZ2xWn1hUUst+urtkm ZrrigPODCsPdK50jxDJ565qfQGlS9iaMD8ht0Zix4lV5UB2lDrzdALud X-Gm-Gg: ASbGnctu7EHVuMIJ6fvqg69S9g1ttybdYVwLrAnHNN65rJkq0GUqK/0W/7YCuSqZks1 aHVRKGmqzckEkYpkc11RvAWIg/CyTqPLoq/dPRY5awiUkJRXMZE/TrdD7SYSuGjxVbPiMa7KAtP 1CIem6m6P9R6rrJUf3rBlS/ber74LV4i59saypYQZXVeNjqVJL0umgzrjdO5FqfzG5UnNe8WRhY jBKdgZthY2x8YlHSSvTUnu+eibqDqHRiiWjKmWif1JkYd5mxgvmcFjStQognEGGSt/+mcscIqce Fdzajk/51cxyj83CoyYtJ8XzO3gC7SNNw41eZ0tpC6cK1iSPTrULSnx8hpbEQhfJXnMf6FWx9RZ r5w+TU2DOp25qw4zVJ9HpkmkVA0Ai/SUMDgqOMVk= X-Google-Smtp-Source: AGHT+IF/RiKRnqfe6vGKljyTYX9lND1zv8DdKHe2Txbc5WxqPLn3ywjdHbHcac3TcXaC0RL34IfYDQ== X-Received: by 2002:a05:600c:8909:b0:450:d3b9:4ba4 with SMTP id 5b1f17b1804b1-455bd87a4c6mr95355045e9.2.1752505966471; Mon, 14 Jul 2025 08:12:46 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:a923:75e5:f97f:ef33]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-454dd43915dsm136712495e9.7.2025.07.14.08.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 08:12:46 -0700 (PDT) From: luca.boccassi@gmail.com To: Madhuker Mythri Cc: dpdk stable Subject: patch 'net/bonding: avoid RSS RETA update in flow isolation mode' has been queued to stable release 22.11.9 Date: Mon, 14 Jul 2025 16:11:09 +0100 Message-ID: <20250714151121.219866-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714151121.219866-1-luca.boccassi@gmail.com> References: <20250630122556.1133654-23-luca.boccassi@gmail.com> <20250714151121.219866-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a82211e6288953a2c7c14a4305f62a63993ce00a Thanks. Luca Boccassi --- >From a82211e6288953a2c7c14a4305f62a63993ce00a Mon Sep 17 00:00:00 2001 From: Madhuker Mythri Date: Fri, 4 Jul 2025 19:20:31 +0530 Subject: [PATCH] net/bonding: avoid RSS RETA update in flow isolation mode [ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] In bonding PMD, member_start() function checks whether RSS(mq_mode) is enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which is returning error in-case of device configured in flow isolation-mode. When the device configured with flow isolation mode RSS reta update is not required and the API was not supported. For example in-case of mlx5 PMD, RSS reta update API was not supported, when the device is configured in flow isolation-mode. So, added check to verify if the device is configured in flow-isolation mode, then do not call the rte_eth_dev_rss_reta_update() API. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Signed-off-by: Madhuker Mythri --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 0e6f3aa42b..9bcca18a45 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1901,12 +1901,13 @@ slave_start(struct rte_eth_dev *bonded_eth_dev, } } - /* If RSS is enabled for bonding, synchronize RETA */ - if (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) { + /* + * If flow-isolation is not enabled, then check whether RSS is enabled for + * bonding, synchronize RETA + */ + if (internals->flow_isolated_valid == 0 && + (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) { int i; - struct bond_dev_private *internals; - - internals = bonded_eth_dev->data->dev_private; for (i = 0; i < internals->slave_count; i++) { if (internals->slaves[i].port_id == slave_eth_dev->data->port_id) { -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-14 16:09:41.231343442 +0100 +++ 0014-net-bonding-avoid-RSS-RETA-update-in-flow-isolation-.patch 2025-07-14 16:09:40.712448986 +0100 @@ -1 +1 @@ -From a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f Mon Sep 17 00:00:00 2001 +From a82211e6288953a2c7c14a4305f62a63993ce00a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 83339bae3d..4906701a95 100644 +index 0e6f3aa42b..9bcca18a45 100644 @@ -29 +30 @@ -@@ -1904,12 +1904,13 @@ member_start(struct rte_eth_dev *bonding_eth_dev, +@@ -1901,12 +1901,13 @@ slave_start(struct rte_eth_dev *bonded_eth_dev, @@ -34 +35 @@ -- if (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) { +- if (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) { @@ -40 +41 @@ -+ (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) { ++ (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) { @@ -44 +45 @@ -- internals = bonding_eth_dev->data->dev_private; +- internals = bonded_eth_dev->data->dev_private; @@ -46,2 +47,2 @@ - for (i = 0; i < internals->member_count; i++) { - if (internals->members[i].port_id == member_port_id) { + for (i = 0; i < internals->slave_count; i++) { + if (internals->slaves[i].port_id == slave_eth_dev->data->port_id) {