From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 274C846B72 for ; Mon, 14 Jul 2025 17:12:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D97840615; Mon, 14 Jul 2025 17:12:32 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id EE08D40615 for ; Mon, 14 Jul 2025 17:12:30 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so30973325e9.1 for ; Mon, 14 Jul 2025 08:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752505950; x=1753110750; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hlRzzzt49lYu08GS5YdtQvBABteRcQzxRjsr48YQLzU=; b=HL2IjIqxSWCDOFireYS9CLTIuNQAfeF7nAJdRb4yOxEB6TxNsvZsshlfjxYVzc2Nnj o4zJDejOJ6S/Jqp6MHAJ2z0aXFxBzXPZSYAf8UmZD75geVqPxFBBA6qV2IhFAENv+cut NLIav8xlyW+lLMYdJ2kqJyvzVB1CrWdHsO4Fq/Uj5P9CXs3jZgTY8mgrq1QWmtvk3W7O KRwm27UDA0fdT2+I+EJSRE+UqCD0KzRkDDVsRDqyOfc3ZSw8m+73QWp9VZJovdLKZlAR FGHnxp/iTG3AoOCPK+f8u7igiUrwLQshgayos74y+e3s7QmZxH4L4gLnCI/lFsi68GpL D1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752505950; x=1753110750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hlRzzzt49lYu08GS5YdtQvBABteRcQzxRjsr48YQLzU=; b=RSL+NjTcyiCTV5WUdhb7PyeERtN5aJ/+BKY/qn1AkM5RlM+skZaivtD0gaDtDJbbey nGFxRept0QyaaXz3CvYkfr4lyfAtQzZjPbBz5NZS2gli+8DRivrGVCUgvwIdJzGyAbaN ofMRt7U6bbk2ghlq+EVn29Gwdpj25G8Wh3sBxbKpVu+Bq4NaLCHiSvRT/Pk+z+vbZ65h cI69Urtsxp3acAAwyWc874/8BXqjhFX4F34EVRVFGfQ0u8+AxmhqpP6zcx/P2vWeF+0+ Q5mh0f1wHL45rO5xCgw9Ot/tN31WnCKeTeAezrzi9yzsrnqsjCYPZnQ4e+2sBiLAM7e1 8b5w== X-Gm-Message-State: AOJu0YzeYqaC6dvGjhkBdP3PUEi28iD+sEoiB5RbxdeQSJdWXZpVmmOX fcrKu4obw0cSgMd9TiGSX8GfABchOAWLNPKRlq7rmI+UX5FYI9Ay88U6x5e8PxYB X-Gm-Gg: ASbGncvWEfBkFKiGhEY19cDeRi2hQjwvuBuBCTQi/c9xk8szw2Stetf/BVlhDE6n+Q4 A6SL0ugT1pv7HOj2HM3cHJFBGgfjkaoRPpMf9DS3tIUP3YGyL2wxK9OWn5G0nGl3oC57sNMoicB mPV9pyU7Bn7P77a+4hCYAxX8xSLHZPZbWzjeFfKEz9+0Q2ezPkRv7wtyv5822EAEyUgeKFmvkft b0g8HEclbi8ogjctgpuv37oaiD0vXfmLnlmCLIww/XS3PsjxpaRDsZRuy2JpiY+g9Y/yr4i/n4k +BlumjXnihpurk5n93vh0rERcHvMiay6EVBEK1u+FcaeO53z3x8WHIB3CjpzWBgKxiDWPYZXKC5 EaI1U1kebR9PRv17V2OR2SAEXZTFp X-Google-Smtp-Source: AGHT+IE9/ac88KxRdja2aoFlYMTKOCboPH7E5aZIeQ/TVqCZ9cKnOyABDI2L4kfykqDxsQ3K5y7IpQ== X-Received: by 2002:a05:600c:1ca2:b0:456:1a69:94fa with SMTP id 5b1f17b1804b1-4561a699783mr38300945e9.13.1752505950286; Mon, 14 Jul 2025 08:12:30 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:a923:75e5:f97f:ef33]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b5e8e25e75sm12544216f8f.87.2025.07.14.08.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 08:12:29 -0700 (PDT) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix device statistics' has been queued to stable release 22.11.9 Date: Mon, 14 Jul 2025 16:11:04 +0100 Message-ID: <20250714151121.219866-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714151121.219866-1-luca.boccassi@gmail.com> References: <20250630122556.1133654-23-luca.boccassi@gmail.com> <20250714151121.219866-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d580bc0e963706b918a18f752353b4cfebe18a98 Thanks. Luca Boccassi --- >From d580bc0e963706b918a18f752353b4cfebe18a98 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:55 +0800 Subject: [PATCH] net/txgbe: fix device statistics [ upstream commit d1406cf06220c78245bbb9db258f488e97f903e0 ] The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 697f1db579..3dfb510619 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2230,7 +2230,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, TXGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, TXGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, TXGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, TXGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, TXGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, TXGBE_MACRX65TO127L); @@ -2249,7 +2249,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, TXGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, TXGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, TXGBE_MACRXJABBER); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-14 16:09:41.052239812 +0100 +++ 0009-net-txgbe-fix-device-statistics.patch 2025-07-14 16:09:40.700448723 +0100 @@ -1 +1 @@ -From d1406cf06220c78245bbb9db258f488e97f903e0 Mon Sep 17 00:00:00 2001 +From d580bc0e963706b918a18f752353b4cfebe18a98 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d1406cf06220c78245bbb9db258f488e97f903e0 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index b68a0557be..580579094b 100644 +index 697f1db579..3dfb510619 100644 @@ -26 +27 @@ -@@ -2250,7 +2250,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, +@@ -2230,7 +2230,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, @@ -35 +36 @@ -@@ -2269,7 +2269,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, +@@ -2249,7 +2249,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw,