From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 876C746BAE for ; Fri, 18 Jul 2025 21:36:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8206440611; Fri, 18 Jul 2025 21:36:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 43F0740B8F for ; Fri, 18 Jul 2025 21:36:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJlvgajnQpQDqZj3YR09KuzRNif7/2PcphxP/odeIWc=; b=ODHhukuKeqQMns/1LQm/jaNcYEgpA3Vdqcgn0Z41lGBl6MKEXNe0sCGXVOE4wRrPCFTCWL 6l8Wkncw8KIoTKhpgF2UaW9gI+26x5X63/W1JNyuMpGc69FRxjx7S0iNmUt1MzBUJAqo6B Vd0Mk0Wc/SqWb2iiGsdx0g08qx57r8o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-978K8AIvPL-qjMR_fC5wWA-1; Fri, 18 Jul 2025 15:36:24 -0400 X-MC-Unique: 978K8AIvPL-qjMR_fC5wWA-1 X-Mimecast-MFC-AGG-ID: 978K8AIvPL-qjMR_fC5wWA_1752867384 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD00D1800292; Fri, 18 Jul 2025 19:36:23 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C0913180045B; Fri, 18 Jul 2025 19:36:22 +0000 (UTC) From: Kevin Traynor To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: check requirement for hardware GRO' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:34 +0100 Message-ID: <20250718193247.1008129-100-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kPL2uHHGSGRWt2jgH77unzYbp8hrD6zI0qsHHjzLBEQ_1752867384 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2b7f9c7142618bcf4754835ee1bf569ea42fb82f Thanks. Kevin --- >From 2b7f9c7142618bcf4754835ee1bf569ea42fb82f Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Mon, 9 Jun 2025 21:06:49 +0800 Subject: [PATCH] net/hns3: check requirement for hardware GRO [ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] The HIP08 platform requires that data address be 64-byte aligned for the GRO feature. Most applications already use 64-byte aligned. So a check is added to avoid using the GRO function when 64-byte aligned is used. Fixes: d14c995b775a ("net/hns3: check Rx DMA address alignmnent") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_rxtx.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 00a105129d..bfe4c0fa2e 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -277,10 +277,23 @@ static int hns3_check_rx_dma_addr(struct hns3_hw *hw, uint64_t dma_addr) { + uint64_t rx_offload = hw->data->dev_conf.rxmode.offloads; uint64_t rem; rem = dma_addr & (hw->rx_dma_addr_align - 1); if (rem > 0) { - hns3_err(hw, "The IO address of the beginning of the mbuf data " - "must be %u-byte aligned", hw->rx_dma_addr_align); + hns3_err(hw, + "mbuf DMA address must be %u-byte aligned", + hw->rx_dma_addr_align); + return -EINVAL; + } + + /* + * This check is for HIP08 network engine. The GRO function + * requires that mbuf DMA address is 64-byte aligned. + */ + rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1); + if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) { + hns3_err(hw, + "GRO requires that mbuf DMA address be 64-byte aligned"); return -EINVAL; } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.472660495 +0100 +++ 0100-net-hns3-check-requirement-for-hardware-GRO.patch 2025-07-18 20:29:11.015907591 +0100 @@ -1 +1 @@ -From ae68b5d91c632a1dde839123f27b0317cf094170 Mon Sep 17 00:00:00 2001 +From 2b7f9c7142618bcf4754835ee1bf569ea42fb82f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index bde46733b0..f9fde3948a 100644 +index 00a105129d..bfe4c0fa2e 100644 @@ -24 +25 @@ -@@ -282,10 +282,23 @@ static int +@@ -277,10 +277,23 @@ static int