From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13BA846BAE for ; Fri, 18 Jul 2025 21:36:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E32240611; Fri, 18 Jul 2025 21:36:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8E6B340E35 for ; Fri, 18 Jul 2025 21:36:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hF91gAKMZpb8sORdIlc0QcfaaQs57h9DSYpufydfu0=; b=ZyknGVO5ohJhSD6U+q1hx3M8QjI8bqagKHATLtXySJBSZ1mcO8u9/m59jal4vkngzJRmyU lh62h0lZ+1Xd/UIPuKyg+3FUsLVcrZt1KxDRtK8Es4VbLFDRrjvnDew+SGc6dBYLAV9E44 jeWWy6lBmnaIniGCXMJp6uEKJc4ZAN8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-41xOHeHNO3eTz4mlC4SutA-1; Fri, 18 Jul 2025 15:36:31 -0400 X-MC-Unique: 41xOHeHNO3eTz4mlC4SutA-1 X-Mimecast-MFC-AGG-ID: 41xOHeHNO3eTz4mlC4SutA_1752867390 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1ABDE195608F; Fri, 18 Jul 2025 19:36:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 86C8B180045B; Fri, 18 Jul 2025 19:36:28 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Bing Zhao , dpdk stable Subject: patch 'net/mlx5: fix crash in HWS counter pool destroy' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:37 +0100 Message-ID: <20250718193247.1008129-103-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jNaJZmdOz7uvguvy1926x-Z-CBflo65Mc4czgCCZSiA_1752867390 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/36fbed3222ee533bf84abc4007ee3d48caa60f96 Thanks. Kevin --- >From 36fbed3222ee533bf84abc4007ee3d48caa60f96 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Wed, 25 Jun 2025 12:32:47 +0300 Subject: [PATCH] net/mlx5: fix crash in HWS counter pool destroy [ upstream commit 0aa0d0e85011116d545318b79e28cb177f5da825 ] When there is not enough memory, counter pool creation fails. As a result, the pool is being destroyed. Since not all pointers were initialized during creation, Need to check for null pointer in destruction. Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode") Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_hws_cnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 124c552aec..dda3b61376 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -797,5 +797,5 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh, rte_spinlock_unlock(&sh->cpool_lock); if (cpool->cfg.host_cpool == NULL) { - if (--sh->cnt_svc->refcnt == 0) + if (sh->cnt_svc && --sh->cnt_svc->refcnt == 0) mlx5_hws_cnt_svc_deinit(sh); } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.571252639 +0100 +++ 0103-net-mlx5-fix-crash-in-HWS-counter-pool-destroy.patch 2025-07-18 20:29:11.017907597 +0100 @@ -1 +1 @@ -From 0aa0d0e85011116d545318b79e28cb177f5da825 Mon Sep 17 00:00:00 2001 +From 36fbed3222ee533bf84abc4007ee3d48caa60f96 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0aa0d0e85011116d545318b79e28cb177f5da825 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 83db242bf9..fce7a7e815 100644 +index 124c552aec..dda3b61376 100644 @@ -24 +25 @@ -@@ -811,5 +811,5 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh, +@@ -797,5 +797,5 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh,