From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 498C346BAE for ; Fri, 18 Jul 2025 21:36:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44CA340611; Fri, 18 Jul 2025 21:36:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 56A3340E2E for ; Fri, 18 Jul 2025 21:36:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTj136ZSMXovSdRRoqw28zbQAymInkc0aHV1F5rDmm0=; b=RpdbBKzRTcFfks9ibsRsME0FgrhyCGtdzYw5WjXRpZEDfRPfxQOwxOQZzfeH+Jn5rH7oN7 YM8uzrKZhXkj4qo8Sj2fkxcqMHWRRew8xpFmK8OcTWYO7oqv7dHmzAPfc0yneV/AorN7Fp AnM48a9cd1ec6Ol+81dc2+v3zwQEvA0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-CW0xJvkYNLKLueg9hNPfYA-1; Fri, 18 Jul 2025 15:36:35 -0400 X-MC-Unique: CW0xJvkYNLKLueg9hNPfYA-1 X-Mimecast-MFC-AGG-ID: CW0xJvkYNLKLueg9hNPfYA_1752867394 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7ECC41800284; Fri, 18 Jul 2025 19:36:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D0154180045B; Fri, 18 Jul 2025 19:36:32 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'common/mlx5: fix extraction of auxiliary device name' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:39 +0100 Message-ID: <20250718193247.1008129-105-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wwBOrXxWDgSp1upbJP7C-YA_unrDmhNR7wK4tJbARts_1752867394 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f85e8a3a02cd958581357b0e7162ef070ba7c2aa Thanks. Kevin --- >From f85e8a3a02cd958581357b0e7162ef070ba7c2aa Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Sun, 15 Jun 2025 10:41:29 +0300 Subject: [PATCH] common/mlx5: fix extraction of auxiliary device name [ upstream commit a60378a398fd95e6de69401e8ed06fcc3f4a3929 ] The PMD reads auxiliary network device name from the Linux sysfs. The current implementation closed directory context before it copied a file name from that directory into internal buffer. The result was uncertain. This change closes sysfs directory after file name was copied. Fixes: 777b72a9339c ("common/mlx5: support auxiliary bus") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/linux/mlx5_common_auxiliary.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_common_auxiliary.c b/drivers/common/mlx5/linux/mlx5_common_auxiliary.c index 33479ffd68..60ea67049d 100644 --- a/drivers/common/mlx5/linux/mlx5_common_auxiliary.c +++ b/drivers/common/mlx5/linux/mlx5_common_auxiliary.c @@ -37,12 +37,15 @@ mlx5_auxiliary_get_child_name(const char *dev, const char *node, break; } - closedir(dir); if (dent == NULL) { rte_errno = ENOENT; - return -rte_errno; + goto end; } if (rte_strscpy(child, dent->d_name, size) < 0) - return -rte_errno; - return 0; + goto end; + rte_errno = 0; + +end: + closedir(dir); + return -rte_errno; } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.647118453 +0100 +++ 0105-common-mlx5-fix-extraction-of-auxiliary-device-name.patch 2025-07-18 20:29:11.027995294 +0100 @@ -1 +1 @@ -From a60378a398fd95e6de69401e8ed06fcc3f4a3929 Mon Sep 17 00:00:00 2001 +From f85e8a3a02cd958581357b0e7162ef070ba7c2aa Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a60378a398fd95e6de69401e8ed06fcc3f4a3929 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index b4ea604820..3ee2f4638a 100644 +index 33479ffd68..60ea67049d 100644 @@ -27 +28 @@ -@@ -39,12 +39,15 @@ mlx5_auxiliary_get_child_name(const char *dev, const char *node, +@@ -37,12 +37,15 @@ mlx5_auxiliary_get_child_name(const char *dev, const char *node,