From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 993DC46BAE for ; Fri, 18 Jul 2025 21:36:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9444540E42; Fri, 18 Jul 2025 21:36:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C39F340B8F for ; Fri, 18 Jul 2025 21:36:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QX/txEByO8gFk6F/Lol2s/qKxzFkLR1kkN2qs9vscR4=; b=bT/kqDFLrOtJov/wlPxpusjKHwCzd0Lbu7GypiRQxowgCtsrg530V2rhfzMtpxty1SbyIF 8xiHy3ML1tEke431OaE4K+SJqWIE4UA7MgS3bDHRkH8WF6Eb1DjTfiKZAmYeDEP83B/ZpL Wtj6c/sve75SnZXpaYo1FhFvGd1Krh8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-z5yQcRu2O7GQIpVds_gAag-1; Fri, 18 Jul 2025 15:36:39 -0400 X-MC-Unique: z5yQcRu2O7GQIpVds_gAag-1 X-Mimecast-MFC-AGG-ID: z5yQcRu2O7GQIpVds_gAag_1752867398 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD65C1800C30; Fri, 18 Jul 2025 19:36:38 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 25591180045B; Fri, 18 Jul 2025 19:36:36 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix WQE size calculation for Tx queue' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:41 +0100 Message-ID: <20250718193247.1008129-107-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6WDvMfl23PuaVngCXuouhm14r2M1CywIHXvMNClyvPM_1752867398 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4ca5b4c3e0299a05c111e323f9a190413308cf78 Thanks. Kevin --- >From 4ca5b4c3e0299a05c111e323f9a190413308cf78 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 27 Jun 2025 11:25:02 +0300 Subject: [PATCH] net/mlx5: fix WQE size calculation for Tx queue [ upstream commit 5c0c1a13c34aa57c6e18f9ba852a9b5807c58b72 ] The txq_calc_wqebb_cnt() should be consistent with the calculation in the function mlx5_txq_devx_obj_new(). Or when the input descriptor number is 512, the WQE size will be wrongly considered to be 30 when no max_inline_data is zero in some cases. The total number of WQE will be considered as 256 and that is incorrect. Adjusting the WQE size will solve the wrong calculation when the calculated WQE size is less than 64B. Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_txq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 3e93517323..d0b9576b09 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -709,4 +709,5 @@ txq_calc_wqebb_cnt(struct mlx5_txq_ctrl *txq_ctrl) MLX5_ESEG_MIN_INLINE_SIZE + txq_ctrl->max_inline_data; + wqe_size = RTE_MAX(wqe_size, MLX5_WQE_SIZE); return rte_align32pow2(wqe_size * desc) / MLX5_WQE_SIZE; } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.735242335 +0100 +++ 0107-net-mlx5-fix-WQE-size-calculation-for-Tx-queue.patch 2025-07-18 20:29:11.041907671 +0100 @@ -1 +1 @@ -From 5c0c1a13c34aa57c6e18f9ba852a9b5807c58b72 Mon Sep 17 00:00:00 2001 +From 4ca5b4c3e0299a05c111e323f9a190413308cf78 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5c0c1a13c34aa57c6e18f9ba852a9b5807c58b72 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 5db12f5c64..8ee8108497 100644 +index 3e93517323..d0b9576b09 100644 @@ -28 +29 @@ -@@ -710,4 +710,5 @@ txq_calc_wqebb_cnt(struct mlx5_txq_ctrl *txq_ctrl) +@@ -709,4 +709,5 @@ txq_calc_wqebb_cnt(struct mlx5_txq_ctrl *txq_ctrl)