From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A9D446BAE for ; Fri, 18 Jul 2025 21:37:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05AD040E68; Fri, 18 Jul 2025 21:37:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 47D2A40E68 for ; Fri, 18 Jul 2025 21:37:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=itbyEVrT1sxcaMgLNhlnlYhTMTt9+KwVE5b1Tbx06as=; b=SnwYDmLIJK25FUe/DhJ+6lWDaYvFHDBw6yfC+ooGxeJeng6ZS5KdjlkxwltJcHT5odHpNL tr8VfHm8y5ihivNBJQqrjQlCF+PxqplsaR94QN4slzciS7/OYs7ExiE7IsW3QxaPUTtwSL 64cD/2uBAKO5wYveuVnDmjpPcjaU36c= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-2Sc_e18lN9-YO9PCPLXHPg-1; Fri, 18 Jul 2025 15:37:06 -0400 X-MC-Unique: 2Sc_e18lN9-YO9PCPLXHPg-1 X-Mimecast-MFC-AGG-ID: 2Sc_e18lN9-YO9PCPLXHPg_1752867425 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 819D619560AD; Fri, 18 Jul 2025 19:37:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2D72318003FC; Fri, 18 Jul 2025 19:37:03 +0000 (UTC) From: Kevin Traynor To: Rakesh Kudurumalla Cc: dpdk stable Subject: patch 'examples/ipsec-secgw: fix crash with IPv6' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:54 +0100 Message-ID: <20250718193247.1008129-120-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0KeL2VN0JRgS9d1P0Y--ElIjchFAnkwOX9rNlSqA6xM_1752867425 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a9eabc9d05e721bef57dfe08a160dd5de37c262b Thanks. Kevin --- >From a9eabc9d05e721bef57dfe08a160dd5de37c262b Mon Sep 17 00:00:00 2001 From: Rakesh Kudurumalla Date: Thu, 27 Mar 2025 12:33:00 +0530 Subject: [PATCH] examples/ipsec-secgw: fix crash with IPv6 [ upstream commit d03869e8e9c7c46bf7637d221ca6921516764109 ] While running ipsec-secgw application if IPv6 rules are not configured in IPsec configuration, LPM look up fails and destination port is updated as BAD_PORT. During process_packet ethernet_hdr is updated resulting in crash due to out of bound. This patch fixes the same. Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup") Signed-off-by: Rakesh Kudurumalla --- examples/ipsec-secgw/ipsec_neon.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_neon.h b/examples/ipsec-secgw/ipsec_neon.h index 8b93b4b52e..fc04000336 100644 --- a/examples/ipsec-secgw/ipsec_neon.h +++ b/examples/ipsec-secgw/ipsec_neon.h @@ -24,4 +24,5 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP], uint32_t *p[FWDSTEP]; struct rte_mbuf *pkt; + uint16_t port; uint32_t val; uint8_t i; @@ -35,5 +36,6 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP], p[i] = rte_pktmbuf_mtod(pkt, uint32_t *); - ve[i] = vreinterpretq_u32_s32(val_eth[dst_port[i]]); + port = (dst_port[i] == BAD_PORT) ? 0 : dst_port[i]; + ve[i] = vreinterpretq_u32_s32(val_eth[port]); te[i] = vld1q_u32(p[i]); @@ -77,4 +79,5 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads, struct rte_ether_hdr *eth_hdr; uint32x4_t te, ve; + uint16_t port; uint32_t val; @@ -86,5 +89,6 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads, te = vld1q_u32((uint32_t *)eth_hdr); - ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]); + port = (dst_port[0] == BAD_PORT) ? 0 : dst_port[0]; + ve = vreinterpretq_u32_s32(val_eth[port]); val = vgetq_lane_u32(te, 3); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:15.196591821 +0100 +++ 0120-examples-ipsec-secgw-fix-crash-with-IPv6.patch 2025-07-18 20:29:11.060020069 +0100 @@ -1 +1 @@ -From d03869e8e9c7c46bf7637d221ca6921516764109 Mon Sep 17 00:00:00 2001 +From a9eabc9d05e721bef57dfe08a160dd5de37c262b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d03869e8e9c7c46bf7637d221ca6921516764109 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org