From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 591D946BAE for ; Fri, 18 Jul 2025 21:37:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5458F40E5A; Fri, 18 Jul 2025 21:37:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 96D1E40611 for ; Fri, 18 Jul 2025 21:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xXDpw5SHlwxEF8CEpE1pCAt959yj4DreRAY77/wa6Bk=; b=ZlMZszVHLYjM1RxrXWILZAowqfqAO3NFNx+KuBzYf2BmrjG+ge9tqSF3y4Mgb5J7ICe97u FOAyEX4GpcWVnTueFzzpVG4Xyy7krQ81HX0goefK5yVfyCIXOPidD3aHVYRaOW1y7nLuXj atQUNkSBTcUa+iZao0cCdpQRtTkTK4U= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-KorACzndMY-F-lN3VQP6BQ-1; Fri, 18 Jul 2025 15:37:08 -0400 X-MC-Unique: KorACzndMY-F-lN3VQP6BQ-1 X-Mimecast-MFC-AGG-ID: KorACzndMY-F-lN3VQP6BQ_1752867427 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACD211956089; Fri, 18 Jul 2025 19:37:07 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0684D180045B; Fri, 18 Jul 2025 19:37:05 +0000 (UTC) From: Kevin Traynor To: Rakesh Kudurumalla Cc: Akhil Goyal , dpdk stable Subject: patch 'examples/ipsec-secgw: fix crash in event vector mode' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:55 +0100 Message-ID: <20250718193247.1008129-121-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rCwLlLNcwg5Q2reNdiLLZ9kFJPVCTTJ4hGNlmN5QFws_1752867427 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e7a0239da2a9ab36776394cae04b3f213649d0b8 Thanks. Kevin --- >From e7a0239da2a9ab36776394cae04b3f213649d0b8 Mon Sep 17 00:00:00 2001 From: Rakesh Kudurumalla Date: Wed, 18 Jun 2025 14:00:06 +0530 Subject: [PATCH] examples/ipsec-secgw: fix crash in event vector mode [ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ] Launching ipsec-secgw application in event vector mode after traffic has started results in segfault because we are receiving few IPSec packet and application is trying to decrypt IPsec packets using lookaside protocol. This contradicts inline event mode.This patch fixes the same by freeing IPsec packets and processing only plain packets. Fixes: 1d5078c6cf19 ("examples/ipsec-secgw: support event vector in lookaside mode") Signed-off-by: Rakesh Kudurumalla Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec_worker.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index e0690fc8d9..04609964cd 100644 --- a/examples/ipsec-secgw/ipsec_worker.c +++ b/examples/ipsec-secgw/ipsec_worker.c @@ -701,4 +701,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, struct rte_mbuf *pkt; struct ipsec_sa *sa; + uint8_t mask = (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) | + (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL); + j = ipsec_ev_route_ip_pkts(vec, rt, t); @@ -708,5 +711,5 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, pkt = t->ipsec.pkts[i]; sa = ipsec_mask_saptr(t->ipsec.saptr[i]); - if (unlikely(sa == NULL)) { + if (unlikely(sa == NULL) || ((1UL << sa->sessions[0].type) & mask)) { free_pkts(&pkt, 1); continue; -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:15.230616530 +0100 +++ 0121-examples-ipsec-secgw-fix-crash-in-event-vector-mode.patch 2025-07-18 20:29:11.060925432 +0100 @@ -1 +1 @@ -From 811383ef109d8dae04c0681b84de09c51f153543 Mon Sep 17 00:00:00 2001 +From e7a0239da2a9ab36776394cae04b3f213649d0b8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org