From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99AB746BAE for ; Fri, 18 Jul 2025 21:37:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9383340E30; Fri, 18 Jul 2025 21:37:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 94EDF40E68 for ; Fri, 18 Jul 2025 21:37:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G6uTpaYB+o0BdgMgjfUMzMgxsD1S/jQMyV7hQJft87Y=; b=bItvs9kmAu6zxywqHH8YPdVA9pmMwyKuHVkk5NsHWgSIhJBCMcYIa659Su43BKwKUbdQlk dZJlNDzB8fxvxdy2coKQ3ZaxkSroToP/rSWFozZ8B+YASjHlK1I672HcZ1GJZce/rYR90N RWsrSFJXL/dk0E1Opnetuw+LSR1Rr8I= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-2fRgrW2zNLuwvXedeOePag-1; Fri, 18 Jul 2025 15:37:13 -0400 X-MC-Unique: 2fRgrW2zNLuwvXedeOePag-1 X-Mimecast-MFC-AGG-ID: 2fRgrW2zNLuwvXedeOePag_1752867433 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E10491956089; Fri, 18 Jul 2025 19:37:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE6EB180045B; Fri, 18 Jul 2025 19:37:11 +0000 (UTC) From: Kevin Traynor To: Gowrishankar Muthukrishnan Cc: dpdk stable Subject: patch 'crypto/openssl: include private exponent in RSA session' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:58 +0100 Message-ID: <20250718193247.1008129-124-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XyRiUFBZr1EbS_x1fyxvVDFlTt0zLZ_jTNyhY8TlG0w_1752867433 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0c16ebf9f3d4f2b11ec6d24adec33fa35a43feb3 Thanks. Kevin --- >From 0c16ebf9f3d4f2b11ec6d24adec33fa35a43feb3 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Fri, 20 Jun 2025 13:49:16 +0530 Subject: [PATCH] crypto/openssl: include private exponent in RSA session [ upstream commit 9020477270c5dc93e1a347b90d5248b10e8cc4e3 ] If private exponent is available, it should be included within RSA session as per RFC 8017 (A.1.2). OpenSSL 1.1.1 implementation rely on this private exponent, to implicitly reject invalid cipher. Hence, check if it is available for session and include it. Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index 18f096abfd..f0bdd1e1f5 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c @@ -1026,5 +1026,5 @@ static int openssl_set_asym_session_parameters( goto err_rsa; - if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_EXP) { + if (xform->rsa.d.length > 0) { d = BN_bin2bn( (const unsigned char *)xform->rsa.d.data, @@ -1035,5 +1035,7 @@ static int openssl_set_asym_session_parameters( goto err_rsa; } - } else { + } + + if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT) { p = BN_bin2bn((const unsigned char *) xform->rsa.qt.p.data, -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:15.357098761 +0100 +++ 0124-crypto-openssl-include-private-exponent-in-RSA-sessi.patch 2025-07-18 20:29:11.070907760 +0100 @@ -1 +1 @@ -From 9020477270c5dc93e1a347b90d5248b10e8cc4e3 Mon Sep 17 00:00:00 2001 +From 0c16ebf9f3d4f2b11ec6d24adec33fa35a43feb3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9020477270c5dc93e1a347b90d5248b10e8cc4e3 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 04e018f3df..d3aa396c76 100644 +index 18f096abfd..f0bdd1e1f5 100644