From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77EC546BAE for ; Fri, 18 Jul 2025 21:33:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7173140611; Fri, 18 Jul 2025 21:33:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 517DC40E44 for ; Fri, 18 Jul 2025 21:33:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/rghq4FXX2eAUfrP1XInlCnUMsQdekgdNBdBgRaIL34=; b=hbMz8amCpE+kXkNUGV4lPTqO7gzhfhAbNL+dveb0Y8s37F48LLylGs1/OfukNbF0AMgW+K zX9FDI56AtatyHUJaJCrD0q1AiCtrv618FZy/c1t3QCEfZ59DkBptg8Cmj24NzuWQwmYvz eGyeprm8XLhSdGpRz2VWP/TXJAoI3Lc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-nyxRhp5ONDmi4u0Yqte5hg-1; Fri, 18 Jul 2025 15:33:24 -0400 X-MC-Unique: nyxRhp5ONDmi4u0Yqte5hg-1 X-Mimecast-MFC-AGG-ID: nyxRhp5ONDmi4u0Yqte5hg_1752867203 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 81E6A180028F; Fri, 18 Jul 2025 19:33:23 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EE07B18003FC; Fri, 18 Jul 2025 19:33:21 +0000 (UTC) From: Kevin Traynor To: Dhanya Pillai Cc: Bruce Richardson , dpdk stable Subject: patch 'net/ice: fix flow creation failure' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:07 +0100 Message-ID: <20250718193247.1008129-13-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FTsDCkHJgeHeW4gnaGNPTnUYYrvyLOakGK7jjtVI9SU_1752867203 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bcaa988a8f71765389071c656ae3d6e1429fc29d Thanks. Kevin --- >From bcaa988a8f71765389071c656ae3d6e1429fc29d Mon Sep 17 00:00:00 2001 From: Dhanya Pillai Date: Thu, 15 May 2025 11:23:44 +0000 Subject: [PATCH] net/ice: fix flow creation failure [ upstream commit 1f332499adc57c86c46fdb26c923f8f56d4cb765 ] In non-pipeline mode, priority is ignored, and a flow rule can be created as a flow director rule or a switch rule depending only on its pattern/action. Therefore, remove the priority field check from ice_fdir_parse which is causing valid flow creation to return failure. Fixes: 14b12c939f3a ("net/ice: remove pipeline mode") Signed-off-by: Dhanya Pillai Acked-by: Bruce Richardson --- drivers/net/ice/ice_fdir_filter.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 406918fed5..dc28328c09 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -2440,5 +2440,5 @@ ice_fdir_parse(struct ice_adapter *ad, const struct rte_flow_item pattern[], const struct rte_flow_action actions[], - uint32_t priority, + uint32_t priority __rte_unused, void **meta, struct rte_flow_error *error) @@ -2455,7 +2455,4 @@ ice_fdir_parse(struct ice_adapter *ad, error); - if (priority >= 1) - return -rte_errno; - if (!item) return -rte_errno; -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:11.587397871 +0100 +++ 0013-net-ice-fix-flow-creation-failure.patch 2025-07-18 20:29:10.817906985 +0100 @@ -1 +1 @@ -From 1f332499adc57c86c46fdb26c923f8f56d4cb765 Mon Sep 17 00:00:00 2001 +From bcaa988a8f71765389071c656ae3d6e1429fc29d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f332499adc57c86c46fdb26c923f8f56d4cb765 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/ice/ice_fdir_filter.c | 5 +---- + drivers/net/ice/ice_fdir_filter.c | 5 +---- @@ -20,5 +21,5 @@ -diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c -index 2ff0090aca..d41d223d52 100644 ---- a/drivers/net/intel/ice/ice_fdir_filter.c -+++ b/drivers/net/intel/ice/ice_fdir_filter.c -@@ -2447,5 +2447,5 @@ ice_fdir_parse(struct ice_adapter *ad, +diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c +index 406918fed5..dc28328c09 100644 +--- a/drivers/net/ice/ice_fdir_filter.c ++++ b/drivers/net/ice/ice_fdir_filter.c +@@ -2440,5 +2440,5 @@ ice_fdir_parse(struct ice_adapter *ad, @@ -31 +32 @@ -@@ -2462,7 +2462,4 @@ ice_fdir_parse(struct ice_adapter *ad, +@@ -2455,7 +2455,4 @@ ice_fdir_parse(struct ice_adapter *ad,