From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80AA146BAE for ; Fri, 18 Jul 2025 21:38:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CDCC40E5A; Fri, 18 Jul 2025 21:38:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4722040611 for ; Fri, 18 Jul 2025 21:37:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFQ6NjBXuk5rOp0QKDs4pE7edpE8Mfl58oUi0VaDtiU=; b=BoxoMG7uTc6ymuqEVoB6de7GGc9OT7+61fSH7LWMKM2+CN4ejuRpy2IInKQ1YEs+6eoEQN wLATjo0aVcy2EyHwOq3ULdB8n+7WURV3uGgEM+Yq1NLs6qBAMakmM+l8/I9IX1W8wFy15z tfy1Ygy8S4cSmJkRUwQWtDl1TCzx1uc= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-oW0ba2VJP8mWfRmrS3ssaw-1; Fri, 18 Jul 2025 15:37:57 -0400 X-MC-Unique: oW0ba2VJP8mWfRmrS3ssaw-1 X-Mimecast-MFC-AGG-ID: oW0ba2VJP8mWfRmrS3ssaw_1752867476 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B7CA19560A5; Fri, 18 Jul 2025 19:37:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2C113180045B; Fri, 18 Jul 2025 19:37:54 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix device statistics' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:31:20 +0100 Message-ID: <20250718193247.1008129-146-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FADYULMj2ccuWJw9VYBOIAB9N0Jd-56VMdVlHEcRdX8_1752867476 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f679ea273e24812f0340c9df1c676e57ffa34e9a Thanks. Kevin --- >From f679ea273e24812f0340c9df1c676e57ffa34e9a Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:55 +0800 Subject: [PATCH] net/txgbe: fix device statistics [ upstream commit d1406cf06220c78245bbb9db258f488e97f903e0 ] The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 7cb475d6e9..ed4f1c1360 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2251,5 +2251,5 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->rx_broadcast_packets += rd64(hw, TXGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, TXGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, TXGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, TXGBE_MACRX1TO64L); @@ -2270,5 +2270,6 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, rd64(hw, TXGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, TXGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, TXGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, TXGBE_MACRXJABBER); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:16.134220500 +0100 +++ 0146-net-txgbe-fix-device-statistics.patch 2025-07-18 20:29:11.124907925 +0100 @@ -1 +1 @@ -From d1406cf06220c78245bbb9db258f488e97f903e0 Mon Sep 17 00:00:00 2001 +From f679ea273e24812f0340c9df1c676e57ffa34e9a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d1406cf06220c78245bbb9db258f488e97f903e0 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index b68a0557be..580579094b 100644 +index 7cb475d6e9..ed4f1c1360 100644