From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9927E46BAE for ; Fri, 18 Jul 2025 21:38:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9526F40E78; Fri, 18 Jul 2025 21:38:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CCC4840E4D for ; Fri, 18 Jul 2025 21:38:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHs36bDDdeNt7lyQ9LI9AVxpKjC90FRpBLYkuZR1IBA=; b=PBVroJqcG235AmPI7Ym2fZD1tEjaPa++2lOTN6cg7WMhHqIKj8b8+P7MYLT5N7DemD+d3Z lWnOSV6Z2A4m6rpWnb3EJVTBJNemUG9WDJQQK6VR5lXM7wXsnPlx+Epb+GL/Gsx4ij3s39 aLPYIxDFFIofPa3YS3Tu8mTOkVKyfJM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-RQy_2uclOFGjWFearabx3A-1; Fri, 18 Jul 2025 15:37:59 -0400 X-MC-Unique: RQy_2uclOFGjWFearabx3A-1 X-Mimecast-MFC-AGG-ID: RQy_2uclOFGjWFearabx3A_1752867478 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4604E1800C31; Fri, 18 Jul 2025 19:37:58 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0669718003FC; Fri, 18 Jul 2025 19:37:56 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix device statistics' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:31:21 +0100 Message-ID: <20250718193247.1008129-147-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZarB_Ql5vKeveyO8l7Gctl4g90OiLvrvkl_GxK9fIYA_1752867478 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a09cf04d7af5da46df6dca2febf4b10db4085e58 Thanks. Kevin --- >From a09cf04d7af5da46df6dca2febf4b10db4085e58 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:56 +0800 Subject: [PATCH] net/ngbe: fix device statistics [ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index a8f847de8d..d3ac40299f 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1430,5 +1430,5 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); @@ -1449,5 +1449,6 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:16.166175378 +0100 +++ 0147-net-ngbe-fix-device-statistics.patch 2025-07-18 20:29:11.125907929 +0100 @@ -1 +1 @@ -From a65009b7621a60faeb1bbefe65160eb5646925dc Mon Sep 17 00:00:00 2001 +From a09cf04d7af5da46df6dca2febf4b10db4085e58 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org