From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9E6E46BAE for ; Fri, 18 Jul 2025 21:38:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5C0C40611; Fri, 18 Jul 2025 21:38:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D8B7440E5A for ; Fri, 18 Jul 2025 21:38:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WycuhPnhpNMDW7etB+TEA7M44zajOyxANGrkrcYXJ68=; b=UP4ouCVN5aL0mhZUd3PT+vt8ba+TNM8q2qP9ningkOQnUMU99RdtFZw0is4v4PnhJjwY4c uKyPwV1fpoMpqZq01ZRu6FECCK/2aEyujUkiwOv0dKRWbvd72RIO+erAXOsiapbU5UNOWP lfJOPmgGqvhNnLHpgZxoSgAP6tBo8dg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-9nz0keagMV-mNKtMmNWCwA-1; Fri, 18 Jul 2025 15:38:07 -0400 X-MC-Unique: 9nz0keagMV-mNKtMmNWCwA-1 X-Mimecast-MFC-AGG-ID: 9nz0keagMV-mNKtMmNWCwA_1752867486 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E205180028E; Fri, 18 Jul 2025 19:38:06 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DE56A18003FC; Fri, 18 Jul 2025 19:38:04 +0000 (UTC) From: Kevin Traynor To: Madhuker Mythri Cc: dpdk stable Subject: patch 'net/bonding: avoid RSS RETA update in flow isolation mode' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:31:25 +0100 Message-ID: <20250718193247.1008129-151-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NGjCgxsIAhyPfAdBqOhMRRDGUv9KRD9FHiKu4iLtfYo_1752867486 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c5ab91d4e9a9510455eb382fe64170e9069a55ec Thanks. Kevin --- >From c5ab91d4e9a9510455eb382fe64170e9069a55ec Mon Sep 17 00:00:00 2001 From: Madhuker Mythri Date: Fri, 4 Jul 2025 19:20:31 +0530 Subject: [PATCH] net/bonding: avoid RSS RETA update in flow isolation mode [ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] In bonding PMD, member_start() function checks whether RSS(mq_mode) is enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which is returning error in-case of device configured in flow isolation-mode. When the device configured with flow isolation mode RSS reta update is not required and the API was not supported. For example in-case of mlx5 PMD, RSS reta update API was not supported, when the device is configured in flow isolation-mode. So, added check to verify if the device is configured in flow-isolation mode, then do not call the rte_eth_dev_rss_reta_update() API. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Signed-off-by: Madhuker Mythri --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 9d72140b82..062ec26d64 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1905,10 +1905,11 @@ member_start(struct rte_eth_dev *bonding_eth_dev, } - /* If RSS is enabled for bonding, synchronize RETA */ - if (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) { + /* + * If flow-isolation is not enabled, then check whether RSS is enabled for + * bonding, synchronize RETA + */ + if (internals->flow_isolated_valid == 0 && + (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) { int i; - struct bond_dev_private *internals; - - internals = bonding_eth_dev->data->dev_private; for (i = 0; i < internals->member_count; i++) { -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:16.285195064 +0100 +++ 0151-net-bonding-avoid-RSS-RETA-update-in-flow-isolation-.patch 2025-07-18 20:29:11.134907956 +0100 @@ -1 +1 @@ -From a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f Mon Sep 17 00:00:00 2001 +From c5ab91d4e9a9510455eb382fe64170e9069a55ec Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 83339bae3d..4906701a95 100644 +index 9d72140b82..062ec26d64 100644