From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A975746BAE for ; Fri, 18 Jul 2025 21:38:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0ED440E42; Fri, 18 Jul 2025 21:38:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 41D1A40611 for ; Fri, 18 Jul 2025 21:38:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4FqAyAdap2gApvbqm+Huyn85shDZkdlc2+JAEtHZGCA=; b=bD1WHZNu1/stqYcblyUbMQE1i+Ix859SaMvNAHCz3qbnT4dN/OQPrhsDMZZswgN6A5B/ws 6ZssUhHDMFsAdOzx4PHc5mml3c4sHmsd7UVqK96cFllg7LRDpZd1EyJf9LRHQ9uHeAzalm cMR8LZySnELgIQlx0GmUTBaEk4PDFN8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-OYq4LnUzPFqb5rro49zR5Q-1; Fri, 18 Jul 2025 15:38:16 -0400 X-MC-Unique: OYq4LnUzPFqb5rro49zR5Q-1 X-Mimecast-MFC-AGG-ID: OYq4LnUzPFqb5rro49zR5Q_1752867494 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5558F1800286; Fri, 18 Jul 2025 19:38:14 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C1F2C180045B; Fri, 18 Jul 2025 19:38:12 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'bus/auxiliary: fix crash in cleanup' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:31:29 +0100 Message-ID: <20250718193247.1008129-155-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iTnDmX8m6uze3BIUhyWmN1Gw5Ia-8hI9kiTJUMyf2W8_1752867494 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a16363c20fc190c47b89b47ecd19bab802393f38 Thanks. Kevin --- >From a16363c20fc190c47b89b47ecd19bab802393f38 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Mon, 7 Jul 2025 13:06:48 +0300 Subject: [PATCH] bus/auxiliary: fix crash in cleanup [ upstream commit f03c01f601b1b8d90f62c8a5acead72c04797d7a ] DPDK auxiliary bus first creates a list of known devices in the `auxiliary_bus.device_list` and then tries to attach a driver to each device on that list. If the driver attachment has failed, a device will remain on the list. The device destruction did not validate driver existence and crashed. The patch validates auxiliary device driver before accessing driver related resources. Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/bus/auxiliary/auxiliary_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index e6cbc4d356..b19b226a43 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -161,4 +161,6 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev) drv = dev->driver; + if (drv == NULL) + return 0; AUXILIARY_LOG(DEBUG, "Driver %s remove auxiliary device %s on NUMA node %i", -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:16.416879934 +0100 +++ 0155-bus-auxiliary-fix-crash-in-cleanup.patch 2025-07-18 20:29:11.140913466 +0100 @@ -1 +1 @@ -From f03c01f601b1b8d90f62c8a5acead72c04797d7a Mon Sep 17 00:00:00 2001 +From a16363c20fc190c47b89b47ecd19bab802393f38 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f03c01f601b1b8d90f62c8a5acead72c04797d7a ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 5c6c6b0ef2..ac766e283e 100644 +index e6cbc4d356..b19b226a43 100644 @@ -31 +32 @@ -@@ -164,4 +164,6 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev) +@@ -161,4 +161,6 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev)