From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB99446BAE for ; Fri, 18 Jul 2025 21:38:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5ED040611; Fri, 18 Jul 2025 21:38:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9955E40B8F for ; Fri, 18 Jul 2025 21:38:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WVKA996pyIrxwteKQ15lhI25VrvjtehclnD3UabJPrM=; b=KcydGp9DQ3GUZ1ZRvqsDGkoGWH3YIGU+PjWx5i+leWJBHDzJtzBI3940NeLy10aAXFWMWu QZAS4t/MdIwMkwLviwOfYDbfluHJ2hNgdU1piZ5tUtLdMH9TIV4HqW0ZP80oLMqz0L+4GB /1ZGjS/aZXx6JCKskKZXYvpBPB3MQjs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-_HQdgAcaM_qZ7Je0hsjB_w-1; Fri, 18 Jul 2025 15:38:21 -0400 X-MC-Unique: _HQdgAcaM_qZ7Je0hsjB_w-1 X-Mimecast-MFC-AGG-ID: _HQdgAcaM_qZ7Je0hsjB_w_1752867500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3595818002A1; Fri, 18 Jul 2025 19:38:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CC078180049D; Fri, 18 Jul 2025 19:38:18 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: dpdk stable Subject: patch 'examples/ntb: check more heap allocations' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:31:32 +0100 Message-ID: <20250718193247.1008129-158-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9WVqBoMXcmW48emI8SO0A4ftP_ZtDN-0p-wJ1CK3P3Q_1752867500 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d7169bb15d919bf45d5857288173da87e8cf934d Thanks. Kevin --- >From d7169bb15d919bf45d5857288173da87e8cf934d Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 21 May 2025 20:23:33 +0300 Subject: [PATCH] examples/ntb: check more heap allocations [ upstream commit 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 ] In some rare case, the libc memory heap allocation may fail and return NULL pointer. Before accessing the memory via the pointer, the NULL pointer check should be done to ensure the code locates in the safe side and no crash. Some newer GCC version will check this by default and report warning on this. Adding the NULL pointer check will help to get rid of such warning. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Signed-off-by: Bing Zhao --- examples/ntb/ntb_fwd.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index 37d60208e3..33f3c1ef17 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -775,4 +775,8 @@ ntb_stats_clear(void) } ids = malloc(sizeof(uint32_t) * nb_ids); + if (ids == NULL) { + printf("Cannot allocate memory for statistics IDs\n"); + return; + } for (i = 0; i < nb_ids; i++) ids[i] = i; @@ -844,7 +848,18 @@ ntb_stats_display(void) } ids = malloc(sizeof(uint32_t) * nb_ids); + if (ids == NULL) { + printf("Cannot allocate memory for statistics IDs\n"); + free(xstats_names); + return; + } for (i = 0; i < nb_ids; i++) ids[i] = i; values = malloc(sizeof(uint64_t) * nb_ids); + if (values == NULL) { + printf("Cannot allocate memory to save fetching values\n"); + free(xstats_names); + free(ids); + return; + } if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) { printf("Error: Unable to get xstats\n"); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:16.518690420 +0100 +++ 0158-examples-ntb-check-more-heap-allocations.patch 2025-07-18 20:29:11.156073403 +0100 @@ -1 +1 @@ -From 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 Mon Sep 17 00:00:00 2001 +From d7169bb15d919bf45d5857288173da87e8cf934d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org