From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33BC546BAE for ; Fri, 18 Jul 2025 21:33:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 127DC40611; Fri, 18 Jul 2025 21:33:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D708A40611 for ; Fri, 18 Jul 2025 21:33:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kP0RnEeQVG0nai0A9fo9RMt+t3oz5cvMFm4lXQKvQvo=; b=iK3X2uZg8P+Zgi60uLsMZnWFTNObyjipflNX+xRVoOBgqR3Gi9BxUGYfL6Z9DJhl/MObGI Y19uKRG4U+uu6PpRfIgFCDrSeyTTXXQeeJr/dN9BVPkw8fjf9B+L9466cCStmITnab+p7n HgoY7sNpT0EU7k04sZxMwQRDJ2mOAKE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-MeAUwRA3MjegWelhhAOr6A-1; Fri, 18 Jul 2025 15:33:00 -0400 X-MC-Unique: MeAUwRA3MjegWelhhAOr6A-1 X-Mimecast-MFC-AGG-ID: MeAUwRA3MjegWelhhAOr6A_1752867179 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 737C01800297; Fri, 18 Jul 2025 19:32:59 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B43E618003FC; Fri, 18 Jul 2025 19:32:57 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Anatoly Burakov , dpdk stable Subject: patch 'net/ixgbe/base: correct definition of endianness macro' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:28:56 +0100 Message-ID: <20250718193247.1008129-2-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bWkzBTnYvV_eSGAqZ_ossWdfkVeQNDp3BcckmuZDssk_1752867179 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a47768eb29e1612673b712f68f7c009e819d9bde Thanks. Kevin --- >From a47768eb29e1612673b712f68f7c009e819d9bde Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 28 Mar 2025 11:16:15 +0000 Subject: [PATCH] net/ixgbe/base: correct definition of endianness macro [ upstream commit 3e7ea9ad5162876583e72de6061752810bdde0fe ] The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value in place - similar to the le32_to_cpus() macro in kernel. Fixing the definition allows us to remove some warning flags, and removes the need for the uintptr_t typecasts. Fixes: aa4fc14d2cee ("ixgbe: update base driver") Signed-off-by: Bruce Richardson Reviewed-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_common.c | 4 ++-- drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index d6425c5b78..fbc9605e4d 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -4611,5 +4611,5 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, for (bi = 0; bi < dword_len; bi++) { buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi); - IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]); + IXGBE_LE32_TO_CPUS(&buffer[bi]); } @@ -4647,5 +4647,5 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 *buffer, for (; bi <= dword_len; bi++) { buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi); - IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]); + IXGBE_LE32_TO_CPUS(&buffer[bi]); } diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h index 502f386b56..4188d83b4f 100644 --- a/drivers/net/ixgbe/base/ixgbe_osdep.h +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h @@ -84,5 +84,5 @@ enum { #define IXGBE_LE32_TO_CPU(_i) rte_le_to_cpu_32(_i) #define IXGBE_LE64_TO_CPU(_i) rte_le_to_cpu_64(_i) -#define IXGBE_LE32_TO_CPUS(_i) rte_le_to_cpu_32(_i) +#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0) #define IXGBE_CPU_TO_BE16(_i) rte_cpu_to_be_16(_i) #define IXGBE_CPU_TO_BE32(_i) rte_cpu_to_be_32(_i) diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build index 7e4fbdfa0f..f8b2ee6341 100644 --- a/drivers/net/ixgbe/base/meson.build +++ b/drivers/net/ixgbe/base/meson.build @@ -20,5 +20,5 @@ sources = [ ] -error_cflags = ['-Wno-unused-value', +error_cflags = [ '-Wno-unused-but-set-variable', '-Wno-unused-parameter', -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:11.256235232 +0100 +++ 0002-net-ixgbe-base-correct-definition-of-endianness-macr.patch 2025-07-18 20:29:10.786906890 +0100 @@ -1 +1 @@ -From 3e7ea9ad5162876583e72de6061752810bdde0fe Mon Sep 17 00:00:00 2001 +From a47768eb29e1612673b712f68f7c009e819d9bde Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3e7ea9ad5162876583e72de6061752810bdde0fe ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17,3 +18,3 @@ - drivers/net/intel/ixgbe/base/ixgbe_common.c | 4 ++-- - drivers/net/intel/ixgbe/base/ixgbe_osdep.h | 2 +- - drivers/net/intel/ixgbe/base/meson.build | 2 +- + drivers/net/ixgbe/base/ixgbe_common.c | 4 ++-- + drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- + drivers/net/ixgbe/base/meson.build | 2 +- @@ -22 +23 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_common.c b/drivers/net/intel/ixgbe/base/ixgbe_common.c +diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c @@ -24,2 +25,2 @@ ---- a/drivers/net/intel/ixgbe/base/ixgbe_common.c -+++ b/drivers/net/intel/ixgbe/base/ixgbe_common.c +--- a/drivers/net/ixgbe/base/ixgbe_common.c ++++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -40,4 +41,4 @@ -diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -index cffc6a4ce8..6e5f7b4ae8 100644 ---- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h -+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h +diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h +index 502f386b56..4188d83b4f 100644 +--- a/drivers/net/ixgbe/base/ixgbe_osdep.h ++++ b/drivers/net/ixgbe/base/ixgbe_osdep.h @@ -51 +52 @@ -diff --git a/drivers/net/intel/ixgbe/base/meson.build b/drivers/net/intel/ixgbe/base/meson.build +diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build @@ -53,2 +54,2 @@ ---- a/drivers/net/intel/ixgbe/base/meson.build -+++ b/drivers/net/intel/ixgbe/base/meson.build +--- a/drivers/net/ixgbe/base/meson.build ++++ b/drivers/net/ixgbe/base/meson.build