From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CC0646BAE for ; Fri, 18 Jul 2025 21:34:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96E5340E2E; Fri, 18 Jul 2025 21:34:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D8F7C40E44 for ; Fri, 18 Jul 2025 21:34:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qvPeYrXcuPSBDIwsjbco8CoNfQpK33ORsZ7z+da3sD0=; b=cp/+/CDeiVw6U3wzqGCiLu0nqnKHStrHMzra2dZEitCeTTEpcgACwxPNmHBeJyZUVZrC6g XrY6Brt9CRtnNF5o/5N4OjyPJXYzgINs3y6HoroHaJUz52w1gFOAqTcTKXjpbvYwFB4zfO 9El/gfObAkYJGYT5l6I/UNfCWzVugwY= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-xuoA0sBUOEKLCiWw6HhTdA-1; Fri, 18 Jul 2025 15:34:00 -0400 X-MC-Unique: xuoA0sBUOEKLCiWw6HhTdA-1 X-Mimecast-MFC-AGG-ID: xuoA0sBUOEKLCiWw6HhTdA_1752867238 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3A891956087; Fri, 18 Jul 2025 19:33:58 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 00DD318003FC; Fri, 18 Jul 2025 19:33:56 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Alex Vesker , Bing Zhao , dpdk stable Subject: patch 'net/mlx5/hws: fix send queue drain on FW WQE destroy' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:24 +0100 Message-ID: <20250718193247.1008129-30-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lRyeg8L176SJcF7OIgYol3Vo_Lxd_1bG1nASv-BORLc_1752867238 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bd350a3297e3b39b1b7ee8b2b24b4237e5246132 Thanks. Kevin --- >From bd350a3297e3b39b1b7ee8b2b24b4237e5246132 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Sun, 27 Apr 2025 14:28:21 +0300 Subject: [PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy [ upstream commit 0394577bdc91a25338fd9a61eb2ddfedf09f2800 ] Queue sync operation was skipped on rule destroy. Unlike on fw wqe rule create in which both fence and notify_hw are set to true, on destroy fence was set to false causing previous queue operation to be stuck in the queue forever. Example: rule_a - HW rule, rule_b - FW WQE rule. Sequence: rule_a destroy, burst=1 (HW rule put to queue but no DB) rule_b destroy, burst=0 (FW WQE rule cmd but no queue sync) Outcome: rule_a is stuck forever in the queue - no completion. Fixes: 338aaf911665 ("net/mlx5/hws: add send FW match STE using gen WQE") Signed-off-by: Alex Vesker Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e121c7f7ed..d01fc7ef2c 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -340,5 +340,5 @@ void mlx5dr_send_stes_fw(struct mlx5dr_send_engine *queue, /* Writing through FW can't HW fence, therefore we drain the queue */ - if (send_attr->fence) + if (send_attr->fence || send_attr->notify_hw) mlx5dr_send_queue_action(ctx, queue_id, -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.153295516 +0100 +++ 0030-net-mlx5-hws-fix-send-queue-drain-on-FW-WQE-destroy.patch 2025-07-18 20:29:10.867907138 +0100 @@ -1 +1 @@ -From 0394577bdc91a25338fd9a61eb2ddfedf09f2800 Mon Sep 17 00:00:00 2001 +From bd350a3297e3b39b1b7ee8b2b24b4237e5246132 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0394577bdc91a25338fd9a61eb2ddfedf09f2800 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org