From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC77746BAE for ; Fri, 18 Jul 2025 21:34:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B62F040611; Fri, 18 Jul 2025 21:34:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 584EF40E2C for ; Fri, 18 Jul 2025 21:34:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOf7exZSgLg9fm6rNMZo+bL2rCfDviMNbvVZ54RxnZc=; b=i2//h/Yw9MYx/p7DVaRPJfej6JFpCBo5uaLVwgxO2fhbp0Nxy3SYK0jFn+OWqORXjwujR9 8JMmqnBCZ+uDSvVhanP0Im6KU1yUhwiErSj0+rHJ0FSePM2MNHqdPozZL8EW1p7u3PJKMD LmVFW4jUpvMdO/96BKBGjVWdBQxwxHY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-Z4qynFL1OXucJER5lmgi4g-1; Fri, 18 Jul 2025 15:34:16 -0400 X-MC-Unique: Z4qynFL1OXucJER5lmgi4g-1 X-Mimecast-MFC-AGG-ID: Z4qynFL1OXucJER5lmgi4g_1752867255 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7E3DA1800C31; Fri, 18 Jul 2025 19:34:15 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9363F180045B; Fri, 18 Jul 2025 19:34:13 +0000 (UTC) From: Kevin Traynor To: Chaoyong He Cc: Long Wu , Peng Zhang , dpdk stable Subject: patch 'net/nfp: fix crash with null RSS hash key' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:31 +0100 Message-ID: <20250718193247.1008129-37-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C2ZKJMNaHFFAIZh9-XS4m0eK8u2p3cAfwLnA7XppmOk_1752867255 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9ba34acb5fcc44f82dad90c893d94655660f6519 Thanks. Kevin --- >From 9ba34acb5fcc44f82dad90c893d94655660f6519 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 15:55:07 +0800 Subject: [PATCH] net/nfp: fix crash with null RSS hash key [ upstream commit 53df26286e4570ea328c5972fb244d8bc0008315 ] Some testpmd application commands will use 'rss_conf->rss_key' parameter with a NULL value to call 'rte_eth_dev_rss_hash_conf_get()' API, and NFP PMD will coredump at these situations. Fix this by add a check about the 'rss_conf->rss_key' pointer. Fixes: 934e4c60fbff ("nfp: add RSS") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index aaa515bac2..600fcd5c0e 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -2063,7 +2063,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, /* Reading the key byte a byte */ - for (i = 0; i < rss_conf->rss_key_len; i++) { - key = nn_cfg_readb(hw, NFP_NET_CFG_RSS_KEY + i); - memcpy(&rss_conf->rss_key[i], &key, 1); + if (rss_conf->rss_key != NULL) { + for (i = 0; i < rss_conf->rss_key_len; i++) { + key = nn_cfg_readb(hw, NFP_NET_CFG_RSS_KEY + i); + memcpy(&rss_conf->rss_key[i], &key, 1); + } } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.413042145 +0100 +++ 0037-net-nfp-fix-crash-with-null-RSS-hash-key.patch 2025-07-18 20:29:10.909907267 +0100 @@ -1 +1 @@ -From 53df26286e4570ea328c5972fb244d8bc0008315 Mon Sep 17 00:00:00 2001 +From 9ba34acb5fcc44f82dad90c893d94655660f6519 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 53df26286e4570ea328c5972fb244d8bc0008315 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org