From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0827146BAE for ; Fri, 18 Jul 2025 21:34:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 025A940611; Fri, 18 Jul 2025 21:34:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C11540E44 for ; Fri, 18 Jul 2025 21:34:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/qg25OBnVSgNB4gzGUEeGc3ieGmY9HrxKMhR+YGMIv0=; b=JHAvr7yjeaY06vJD1VC0NthUE/3Nw+UQJQaUKqzHUAL0bA9xuIYVeECoRqh/Wyfr3EXQmF 2Oufwb+Q3lXFMDJL+wIpn6b3tIdDqEtststJhNPsC3OkMpUGL7wxBJzdinpfhnDUBWR152 MNrE0khpoNPIthkZpNT9DoVNKnIgt9Q= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-snig6WUqOnGNMXAo-G3PNw-1; Fri, 18 Jul 2025 15:34:18 -0400 X-MC-Unique: snig6WUqOnGNMXAo-G3PNw-1 X-Mimecast-MFC-AGG-ID: snig6WUqOnGNMXAo-G3PNw_1752867257 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 46FEA1800286; Fri, 18 Jul 2025 19:34:17 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1775C18003FC; Fri, 18 Jul 2025 19:34:15 +0000 (UTC) From: Kevin Traynor To: Chaoyong He Cc: dpdk stable Subject: patch 'net/nfp: fix hash key length logic' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:32 +0100 Message-ID: <20250718193247.1008129-38-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mF6p9m8wcNITok7ekaA747ZDqrm5-23SAEWxRujCEA0_1752867257 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/55c400bab9a7541cec577f78a069e474bf251213 Thanks. Kevin --- >From 55c400bab9a7541cec577f78a069e474bf251213 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 07:09:31 -0700 Subject: [PATCH] net/nfp: fix hash key length logic [ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ] There does not exist an API for driver to get/set the hash key length from/to the firmware. --- drivers/net/nfp/nfp_net_common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 600fcd5c0e..df89595773 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -1967,7 +1967,4 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev, nn_cfg_writel(hw, NFP_NET_CFG_RSS_CTRL, cfg_rss_ctrl); - /* Writing the key size */ - nn_cfg_writeb(hw, NFP_NET_CFG_RSS_KEY_SZ, rss_conf->rss_key_len); - return 0; } @@ -2060,5 +2057,5 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, /* Reading the key size */ - rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ); + rss_conf->rss_key_len = NFP_NET_CFG_RSS_KEY_SZ; /* Reading the key byte a byte */ -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.442880085 +0100 +++ 0038-net-nfp-fix-hash-key-length-logic.patch 2025-07-18 20:29:10.910907270 +0100 @@ -1 +1 @@ -From 346a007e161e68950acbf59984fefc2bb6fe3982 Mon Sep 17 00:00:00 2001 +From 55c400bab9a7541cec577f78a069e474bf251213 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 346a007e161e68950acbf59984fefc2bb6fe3982 ] + @@ -8,15 +9,0 @@ ---- - #define NFP_NET_CFG_RSS_KEY_SZ 0x28 - #define NFP_NET_CFG_MACADDR 0x0024 ---- - -The original logic try to use the 'NFP_NET_CFG_RSS_KEY_SZ' as the -inexistent API, read from this address will get wrong hash key length -and write to this address will overwrite the MAC address unexpected, -which will cause very strange problem. - -Fixes: 934e4c60fbff ("nfp: add RSS") -Cc: stable@dpdk.org - -Signed-off-by: Chaoyong He -Reviewed-by: Peng Zhang