From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C32746BAE for ; Fri, 18 Jul 2025 21:34:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6666940E41; Fri, 18 Jul 2025 21:34:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D222940E42 for ; Fri, 18 Jul 2025 21:34:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r4CmkXj0R4IiYXdix6ZFGtyi6cv1StG68+YpS0RnQx4=; b=N44N8cqZ4F8u6MP3B6M6dIQkK1uRjkpWkYCvyeZzzLdQbXnMC5RFOsjb+MC7Wo7otZbnHd UJTBBthHXCS27xsY2W33B9881mwuITb9Iow1F3IQeFYOdXaNMX/REBJGXMO1Lv/SpAAOMk wNPUcOAgXo2z+5+fwQmKYQw7D+HmciA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-dnReVyt5MFWh6fIMez_DfA-1; Fri, 18 Jul 2025 15:34:24 -0400 X-MC-Unique: dnReVyt5MFWh6fIMez_DfA-1 X-Mimecast-MFC-AGG-ID: dnReVyt5MFWh6fIMez_DfA_1752867259 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B7C03195FD2B; Fri, 18 Jul 2025 19:34:19 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC096180049D; Fri, 18 Jul 2025 19:34:17 +0000 (UTC) From: Kevin Traynor To: Chaoyong He Cc: Long Wu , Peng Zhang , dpdk stable Subject: patch 'app/testpmd: fix RSS hash key update' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:33 +0100 Message-ID: <20250718193247.1008129-39-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _qEeBPfGUeyZyGmusUKpZEsG9ZQSV5SbS798V1YV8Y8_1752867259 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5c7b58471af11358fb7f4e58417c0395817cf214 Thanks. Kevin --- >From 5c7b58471af11358fb7f4e58417c0395817cf214 Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 1 Apr 2025 15:48:36 +0800 Subject: [PATCH] app/testpmd: fix RSS hash key update [ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] There has logic problem in 'port_rss_hash_key_update()', the user input will be overwritten by the call to 'rte_eth_dev_rss_hash_conf_get()', so the RSS functions will not get update as expected. ------ testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> port config 0 rss-hash-key ipv6-tcp 6D5A56DA255B0EC24167253D 43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B73BBEAC01FA testpmd> show port 0 rss-hash key RSS functions: ipv4 ipv6 RSS key: 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F20C6A42B7 3BBEAC01FA testpmd> ------ Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b183f14737..d2585e0edc 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -4794,9 +4794,10 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, rss_conf.rss_key = NULL; rss_conf.rss_key_len = 0; - rss_conf.rss_hf = str_to_rsstypes(rss_type); + rss_conf.rss_hf = 0; diag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); if (diag == 0) { rss_conf.rss_key = hash_key; rss_conf.rss_key_len = hash_key_len; + rss_conf.rss_hf = str_to_rsstypes(rss_type); diag = rte_eth_dev_rss_hash_update(port_id, &rss_conf); } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.472409782 +0100 +++ 0039-app-testpmd-fix-RSS-hash-key-update.patch 2025-07-18 20:29:10.914907282 +0100 @@ -1 +1 @@ -From 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f Mon Sep 17 00:00:00 2001 +From 5c7b58471af11358fb7f4e58417c0395817cf214 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 24e94a4c86c52f45a7a7c139e4e8484f3afe6d8f ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -39 +40 @@ -index e89af21cec..c32e011fa6 100644 +index b183f14737..d2585e0edc 100644 @@ -42 +43 @@ -@@ -4807,9 +4807,10 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, +@@ -4794,9 +4794,10 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,