From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FABC46BAE for ; Fri, 18 Jul 2025 21:33:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A6D940E2C; Fri, 18 Jul 2025 21:33:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1BBE640611 for ; Fri, 18 Jul 2025 21:33:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kqz3Sqpw5f21siiI7tr0+nt/ilRkHV76p74GG50mFmc=; b=BKIQdR44MIuV1+iyvOXhOimv9eEuPJuV9sOLA/mYHdBRvbbDUK1JE0xcmK/LrjcEO9P+C3 NUELTgzssba7FOBgUYI62mDu25ju3TlFPPkNItVckVYi7lwwwxLTii/PuvMMXGYkZMVK12 Ci7PByZn9qTC9E6qdkQazzaYg9xqbgw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-MFKLhEBENUScd7qK5eoohQ-1; Fri, 18 Jul 2025 15:33:04 -0400 X-MC-Unique: MFKLhEBENUScd7qK5eoohQ-1 X-Mimecast-MFC-AGG-ID: MFKLhEBENUScd7qK5eoohQ_1752867183 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC0741800284; Fri, 18 Jul 2025 19:33:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3455918003FC; Fri, 18 Jul 2025 19:33:01 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Anatoly Burakov , dpdk stable Subject: patch 'net/i40e/base: fix unused value warnings' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:28:58 +0100 Message-ID: <20250718193247.1008129-4-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fYQVeew9zngVo_g_C3HvM6SO5XVXUCip6-pfIHxyn0w_1752867183 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d2cb553ea36f2d2085cc6b3fa431a3edf18efea9 Thanks. Kevin --- >From d2cb553ea36f2d2085cc6b3fa431a3edf18efea9 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 28 Mar 2025 11:16:18 +0000 Subject: [PATCH] net/i40e/base: fix unused value warnings [ upstream commit 3c2125852742d46accc3f35f4fa683768ba25e09 ] Fix warnings about unused values - parameters, variables, etc., and remove the warning disable flags for them. Although modifying the base-code files is not ideal, the changes required are minor, and only affect two files from the imported base code. Fixes: 8db9e2a1b232 ("i40e: base driver") Signed-off-by: Bruce Richardson Acked-by: Anatoly Burakov --- drivers/net/i40e/base/i40e_nvm.c | 1 + drivers/net/i40e/base/i40e_osdep.h | 4 ++-- drivers/net/i40e/base/i40e_type.h | 14 +++++++++----- drivers/net/i40e/base/meson.build | 3 --- drivers/net/i40e/i40e_ethdev.c | 1 + 5 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index 3e16a0d997..00a207ca81 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -1749,4 +1749,5 @@ STATIC enum i40e_status_code i40e_nvmupd_get_aq_event(struct i40e_hw *hw, u32 aq_desc_len; + UNREFERENCED_1PARAMETER(perrno); i40e_debug(hw, I40E_DEBUG_NVM, "NVMUPD: %s\n", __func__); diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h index 8960206d8b..d056ae4ec6 100644 --- a/drivers/net/i40e/base/i40e_osdep.h +++ b/drivers/net/i40e/base/i40e_osdep.h @@ -185,6 +185,6 @@ struct i40e_dma_mem { } __rte_packed; -#define i40e_allocate_dma_mem(h, m, unused, s, a) \ - i40e_allocate_dma_mem_d(h, m, s, a) +#define i40e_allocate_dma_mem(h, m, mt, s, a) \ + i40e_allocate_dma_mem_d(h, m, mt, s, a) #define i40e_free_dma_mem(h, m) i40e_free_dma_mem_d(h, m) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index 7cc746f82f..968e1982a6 100644 --- a/drivers/net/i40e/base/i40e_type.h +++ b/drivers/net/i40e/base/i40e_type.h @@ -15,9 +15,13 @@ #define UNREFERENCED_XPARAMETER -#define UNREFERENCED_1PARAMETER(_p) (_p); -#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); -#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); -#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); -#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); +#define UNREFERENCED_1PARAMETER(_p) (void)(_p) +#define UNREFERENCED_2PARAMETER(_p, _q) \ + do { (void)(_p); (void)(_q); } while (0) +#define UNREFERENCED_3PARAMETER(_p, _q, _r) \ + do { (void)(_p); (void)(_q); (void)(_r); } while (0) +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); } while (0) +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) \ + do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); (void)(_t); } while (0) #define BIT(a) (1UL << (a)) diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build index a0912b1788..2648e5d0c4 100644 --- a/drivers/net/i40e/base/meson.build +++ b/drivers/net/i40e/base/meson.build @@ -14,8 +14,5 @@ sources = [ error_cflags = [ '-Wno-sign-compare', - '-Wno-unused-value', '-Wno-strict-aliasing', - '-Wno-unused-but-set-variable', - '-Wno-unused-parameter', ] c_args = cflags diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 30dcdc68a8..b316f977d3 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4695,4 +4695,5 @@ enum i40e_status_code i40e_allocate_dma_mem_d(__rte_unused struct i40e_hw *hw, struct i40e_dma_mem *mem, + __rte_unused enum i40e_memory_type mtype, u64 size, u32 alignment) -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:11.317011560 +0100 +++ 0004-net-i40e-base-fix-unused-value-warnings.patch 2025-07-18 20:29:10.804906945 +0100 @@ -1 +1 @@ -From 3c2125852742d46accc3f35f4fa683768ba25e09 Mon Sep 17 00:00:00 2001 +From d2cb553ea36f2d2085cc6b3fa431a3edf18efea9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3c2125852742d46accc3f35f4fa683768ba25e09 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17,5 +18,5 @@ - drivers/net/intel/i40e/base/i40e_nvm.c | 1 + - drivers/net/intel/i40e/base/i40e_osdep.h | 4 ++-- - drivers/net/intel/i40e/base/i40e_type.h | 14 +++++++++----- - drivers/net/intel/i40e/base/meson.build | 3 --- - drivers/net/intel/i40e/i40e_ethdev.c | 1 + + drivers/net/i40e/base/i40e_nvm.c | 1 + + drivers/net/i40e/base/i40e_osdep.h | 4 ++-- + drivers/net/i40e/base/i40e_type.h | 14 +++++++++----- + drivers/net/i40e/base/meson.build | 3 --- + drivers/net/i40e/i40e_ethdev.c | 1 + @@ -24 +25 @@ -diff --git a/drivers/net/intel/i40e/base/i40e_nvm.c b/drivers/net/intel/i40e/base/i40e_nvm.c +diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c @@ -26,2 +27,2 @@ ---- a/drivers/net/intel/i40e/base/i40e_nvm.c -+++ b/drivers/net/intel/i40e/base/i40e_nvm.c +--- a/drivers/net/i40e/base/i40e_nvm.c ++++ b/drivers/net/i40e/base/i40e_nvm.c @@ -34,6 +35,6 @@ -diff --git a/drivers/net/intel/i40e/base/i40e_osdep.h b/drivers/net/intel/i40e/base/i40e_osdep.h -index c04f94732a..197f4678bf 100644 ---- a/drivers/net/intel/i40e/base/i40e_osdep.h -+++ b/drivers/net/intel/i40e/base/i40e_osdep.h -@@ -185,6 +185,6 @@ struct __rte_packed_begin i40e_dma_mem { - } __rte_packed_end; +diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h +index 8960206d8b..d056ae4ec6 100644 +--- a/drivers/net/i40e/base/i40e_osdep.h ++++ b/drivers/net/i40e/base/i40e_osdep.h +@@ -185,6 +185,6 @@ struct i40e_dma_mem { + } __rte_packed; @@ -47 +48 @@ -diff --git a/drivers/net/intel/i40e/base/i40e_type.h b/drivers/net/intel/i40e/base/i40e_type.h +diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h @@ -49,2 +50,2 @@ ---- a/drivers/net/intel/i40e/base/i40e_type.h -+++ b/drivers/net/intel/i40e/base/i40e_type.h +--- a/drivers/net/i40e/base/i40e_type.h ++++ b/drivers/net/i40e/base/i40e_type.h @@ -70 +71 @@ -diff --git a/drivers/net/intel/i40e/base/meson.build b/drivers/net/intel/i40e/base/meson.build +diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build @@ -72,2 +73,2 @@ ---- a/drivers/net/intel/i40e/base/meson.build -+++ b/drivers/net/intel/i40e/base/meson.build +--- a/drivers/net/i40e/base/meson.build ++++ b/drivers/net/i40e/base/meson.build @@ -83,4 +84,4 @@ -diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c -index 1c5ab35a8b..90eba3419f 100644 ---- a/drivers/net/intel/i40e/i40e_ethdev.c -+++ b/drivers/net/intel/i40e/i40e_ethdev.c +diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c +index 30dcdc68a8..b316f977d3 100644 +--- a/drivers/net/i40e/i40e_ethdev.c ++++ b/drivers/net/i40e/i40e_ethdev.c