From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5703846BAE for ; Fri, 18 Jul 2025 21:34:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5178540B8F; Fri, 18 Jul 2025 21:34:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1142D40E30 for ; Fri, 18 Jul 2025 21:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mzMfFTqnX4IIFOC4dX6gwNNawqAaNIauAmdsi2sRk9I=; b=dIgcL4LIa7aXPF4DSXp6dLS+vD5qdXYYtBZwTxhXoN0r5jxrc5E8w93SeQAqzEYmIpVsJk uWHqp4b0qAlrLv3QBCfZL4UzFjUYcCRW1V3CA11UfSP4eIOP5ovGxFiA3t8a/iep8Gt702 aUNJal7bDobsYboxX8tjqibEp05Rse8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-K5JsbTuxNaaPyMf8069l8w-1; Fri, 18 Jul 2025 15:34:34 -0400 X-MC-Unique: K5JsbTuxNaaPyMf8069l8w-1 X-Mimecast-MFC-AGG-ID: K5JsbTuxNaaPyMf8069l8w_1752867273 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7495F19560AA; Fri, 18 Jul 2025 19:34:33 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 30E95180049D; Fri, 18 Jul 2025 19:34:31 +0000 (UTC) From: Kevin Traynor To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: fix divide by zero' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:40 +0100 Message-ID: <20250718193247.1008129-46-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OYxDNanoP8qgVE2orjQh2hYrkzUSUY8Ld3SLoS9A2z8_1752867273 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/180ac497e64dfcfc32b08abf4f2dc2171869be46 Thanks. Kevin --- >From 180ac497e64dfcfc32b08abf4f2dc2171869be46 Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Tue, 8 Apr 2025 16:30:59 +0800 Subject: [PATCH] net/hns3: fix divide by zero [ upstream commit a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 ] Driver may encounter divide-by-zero if the total_tqps_num and rss_size_max in hw structure from firmware are zero. So add some verification to them. Fixes: d51867db65c1 ("net/hns3: add initialization") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 2b56b6e44e..2d4e348442 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -2545,4 +2545,8 @@ hns3_query_pf_resource(struct hns3_hw *hw) hw->total_tqps_num = rte_le_to_cpu_16(req->tqp_num) + rte_le_to_cpu_16(req->ext_tqp_num); + if (hw->total_tqps_num == 0) { + PMD_INIT_LOG(ERR, "the total tqp number of the port is 0."); + return -EINVAL; + } ret = hns3_get_pf_max_tqp_num(hw); if (ret) @@ -2796,4 +2800,5 @@ static int hns3_get_board_configuration(struct hns3_hw *hw) { +#define HNS3_RSS_SIZE_MAX_DEFAULT 64 struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw); struct hns3_pf *pf = &hns->pf; @@ -2814,4 +2819,9 @@ hns3_get_board_configuration(struct hns3_hw *hw) hw->mac.media_type = cfg.media_type; hw->rss_size_max = cfg.rss_size_max; + if (hw->rss_size_max == 0) { + PMD_INIT_LOG(WARNING, "rss_size_max is 0, already adjust to %u.", + HNS3_RSS_SIZE_MAX_DEFAULT); + hw->rss_size_max = HNS3_RSS_SIZE_MAX_DEFAULT; + } memcpy(hw->mac.mac_addr, cfg.mac_addr, RTE_ETHER_ADDR_LEN); hw->mac.phy_addr = cfg.phy_addr; -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.711560672 +0100 +++ 0046-net-hns3-fix-divide-by-zero.patch 2025-07-18 20:29:10.927907322 +0100 @@ -1 +1 @@ -From a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 Mon Sep 17 00:00:00 2001 +From 180ac497e64dfcfc32b08abf4f2dc2171869be46 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a88f60f32de6f94a5acbf2101cb5e527fac0b2d2 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org