From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7B9F46BAE for ; Fri, 18 Jul 2025 21:34:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2EDE40E44; Fri, 18 Jul 2025 21:34:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A64740611 for ; Fri, 18 Jul 2025 21:34:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oY7sJTZfbPrc7M3+GEFt/bfe5X1H6e7+95Uk0e86QfY=; b=VvHa/3HQOV1Xf9GTY0TGMe16Rerco8DSd+IC742suaFJ8jPKCKq757/5dkvDvb8qdTbObu gEnjd5wccr8LRuXz6bp1WRmWK77Z13/C/qKsZjLTFjQFhi5gJIvIEtJ5T5aiDjf/B2yzx3 LktKIZlY4qfwg4a+9mOwZnrbHMMPmP8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-QUdWKYmYNsiinlIiZ0Ip6Q-1; Fri, 18 Jul 2025 15:34:36 -0400 X-MC-Unique: QUdWKYmYNsiinlIiZ0Ip6Q-1 X-Mimecast-MFC-AGG-ID: QUdWKYmYNsiinlIiZ0Ip6Q_1752867275 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4043919560AA; Fri, 18 Jul 2025 19:34:35 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0FD28180045B; Fri, 18 Jul 2025 19:34:33 +0000 (UTC) From: Kevin Traynor To: Dengdui Huang Cc: dpdk stable Subject: patch 'net/hns3: fix resources release on reset' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:41 +0100 Message-ID: <20250718193247.1008129-47-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DuVXPAGme4tdkBFobLSHo5dzmeZUzfrOl8Pk_31KeFM_1752867275 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a8b88d0a0af7247776ee3b9cab0abc72e25b120e Thanks. Kevin --- >From a8b88d0a0af7247776ee3b9cab0abc72e25b120e Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Tue, 8 Apr 2025 16:31:00 +0800 Subject: [PATCH] net/hns3: fix resources release on reset [ upstream commit 361eab82df67c09cb84a9e2e66c0d93a84be610d ] Some resources, like, unmapping Rx interrupt, doesn't perform when execute dev_stop on reset. This will lead to other issues. Fixes: 2790c6464725 ("net/hns3: support device reset") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_ethdev.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 2d4e348442..9f99525e70 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -5220,4 +5220,9 @@ hns3_dev_stop(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); + if (rte_atomic_load_explicit(&hw->reset.resetting, rte_memory_order_relaxed) != 0) { + hns3_warn(hw, "device is resetting, stop operation is not allowed."); + return -EBUSY; + } + dev->data->dev_started = 0; @@ -5226,12 +5231,10 @@ hns3_dev_stop(struct rte_eth_dev *dev) rte_spinlock_lock(&hw->lock); - if (rte_atomic_load_explicit(&hw->reset.resetting, rte_memory_order_relaxed) == 0) { - hns3_tm_dev_stop_proc(hw); - hns3_config_mac_tnl_int(hw, false); - hns3_stop_tqps(hw); - hns3_do_stop(hns); - hns3_unmap_rx_interrupt(dev); - hw->adapter_state = HNS3_NIC_CONFIGURED; - } + hns3_tm_dev_stop_proc(hw); + hns3_config_mac_tnl_int(hw, false); + hns3_stop_tqps(hw); + hns3_do_stop(hns); + hns3_unmap_rx_interrupt(dev); + hw->adapter_state = HNS3_NIC_CONFIGURED; hns3_rx_scattered_reset(dev); rte_eal_alarm_cancel(hns3_service_handler, dev); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.744425887 +0100 +++ 0047-net-hns3-fix-resources-release-on-reset.patch 2025-07-18 20:29:10.929907328 +0100 @@ -1 +1 @@ -From 361eab82df67c09cb84a9e2e66c0d93a84be610d Mon Sep 17 00:00:00 2001 +From a8b88d0a0af7247776ee3b9cab0abc72e25b120e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 361eab82df67c09cb84a9e2e66c0d93a84be610d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org