From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22E3046BAE for ; Fri, 18 Jul 2025 21:34:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E09E40E31; Fri, 18 Jul 2025 21:34:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 300E140611 for ; Fri, 18 Jul 2025 21:34:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4OLJDg6DIZHeZG3WFngw1NUxFWASvDTHvfR559SYUU=; b=RGd284lWsbKDAHCF6z30fbvjtnjHaaV8TRfasc6RTNMoCFATGTHARcGbtMQ3vgw3laDj6j lcBUScMrUrYNg3ALgmmYM4jw3mUHPmWwT3MxeDf3RTLJdv9IcNJHG0Fx0pUpAOgJdAKJ8k 4Eng4W6j1qHQ4jpVJEhRKJAzESaYxlM= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-qkYXVN6NO5WOubTm9tzsuA-1; Fri, 18 Jul 2025 15:34:44 -0400 X-MC-Unique: qkYXVN6NO5WOubTm9tzsuA-1 X-Mimecast-MFC-AGG-ID: qkYXVN6NO5WOubTm9tzsuA_1752867283 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C34519560AE; Fri, 18 Jul 2025 19:34:43 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3DEC7180045B; Fri, 18 Jul 2025 19:34:41 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/qede: fix use after free' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:45 +0100 Message-ID: <20250718193247.1008129-51-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UbKlJsQuh2Hsx2TfMfv_mNRCPW3h6hG4eEa74YhQ4GI_1752867283 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/562dab834f712c051aee23e8afb16ed64c3bd99e Thanks. Kevin --- >From 562dab834f712c051aee23e8afb16ed64c3bd99e Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 13 Mar 2025 10:22:03 -0700 Subject: [PATCH] net/qede: fix use after free [ upstream commit ab8caba639ee6378055b2d8518e2a97b2212c737 ] The loop cleaning up flowdir resources was using SLIST_FOREACH but the inner loop would call rte_free. Found by building with address sanitizer undefined check. Also remove needless initialization, and null check. Fixes: f5765f66f9bb ("net/qede: refactor flow director into generic aRFS") Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_filter.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c index 14fb4338e9..cecb58c997 100644 --- a/drivers/net/qede/qede_filter.c +++ b/drivers/net/qede/qede_filter.c @@ -13,4 +13,11 @@ #include "qede_ethdev.h" +#ifndef SLIST_FOREACH_SAFE +#define SLIST_FOREACH_SAFE(var, head, field, tvar) \ + for ((var) = SLIST_FIRST((head)); \ + (var) && ((tvar) = SLIST_NEXT((var), field), 1); \ + (var) = (tvar)) +#endif + /* VXLAN tunnel classification mapping */ const struct _qede_udp_tunn_types { @@ -155,13 +162,10 @@ void qede_fdir_dealloc_resc(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); - struct qede_arfs_entry *tmp = NULL; + struct qede_arfs_entry *tmp, *tmp2; - SLIST_FOREACH(tmp, &qdev->arfs_info.arfs_list_head, list) { - if (tmp) { - rte_memzone_free(tmp->mz); - SLIST_REMOVE(&qdev->arfs_info.arfs_list_head, tmp, - qede_arfs_entry, list); - rte_free(tmp); - } + SLIST_FOREACH_SAFE(tmp, &qdev->arfs_info.arfs_list_head, list, tmp2) { + rte_memzone_free(tmp->mz); + SLIST_REMOVE(&qdev->arfs_info.arfs_list_head, tmp, qede_arfs_entry, list); + rte_free(tmp); } } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.866837068 +0100 +++ 0051-net-qede-fix-use-after-free.patch 2025-07-18 20:29:10.932907337 +0100 @@ -1 +1 @@ -From ab8caba639ee6378055b2d8518e2a97b2212c737 Mon Sep 17 00:00:00 2001 +From 562dab834f712c051aee23e8afb16ed64c3bd99e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ab8caba639ee6378055b2d8518e2a97b2212c737 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org