From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 494D546BAE for ; Fri, 18 Jul 2025 21:34:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43B3640611; Fri, 18 Jul 2025 21:34:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2FE0B40E41 for ; Fri, 18 Jul 2025 21:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hSCKrfV1zp8KLaxsUHrwaoLbwmUX0yXp/O+L5VzeNU0=; b=EFOxlartsO4ikWLnMU1OaYPZWBcY5SY/nVCb00nKrJihhu24/FRw6nves1GaAH71RcQKoZ LV+pstWSX+Hl2hRsmEG/Qx9jme63S5ZUDtOVNR6TQHg4B1eEGbcdlGFmgrdlFs4lAb2gKS SgqSecbadsRQPx8+RwjXdq6xbS05pIA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-7LNNONHmPpaDTdV1snkOsQ-1; Fri, 18 Jul 2025 15:34:46 -0400 X-MC-Unique: 7LNNONHmPpaDTdV1snkOsQ-1 X-Mimecast-MFC-AGG-ID: 7LNNONHmPpaDTdV1snkOsQ_1752867285 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 92EB1180028E; Fri, 18 Jul 2025 19:34:45 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1BA86180045B; Fri, 18 Jul 2025 19:34:43 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Hemant Agrawal , dpdk stable Subject: patch 'bus/fslmc: fix use after free' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:46 +0100 Message-ID: <20250718193247.1008129-52-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 29BAXSWwKtuG_gzlE0sg_MvbBCeqdZJlH3Af0vudPhI_1752867285 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bbb4e92be549046a558d90eaeea2439a1e5b6ea1 Thanks. Kevin --- >From bbb4e92be549046a558d90eaeea2439a1e5b6ea1 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 16 Apr 2025 07:58:14 -0700 Subject: [PATCH] bus/fslmc: fix use after free [ upstream commit 1cad17c43079268d9e15db62b3a1edd42df8d81e ] The cleanup loop would dereference the dpio_dev after freeing. Use TAILQ_FOREACH_SAFE to fix that. Found by building with sanitizer undefined flag. Fixes: e55d0494ab98 ("bus/fslmc: support secondary process") Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c index 2dfcf7a498..bc03b4dd05 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c @@ -39,4 +39,11 @@ #include +#ifndef TAILQ_FOREACH_SAFE +#define TAILQ_FOREACH_SAFE(var, head, field, tvar) \ + for ((var) = TAILQ_FIRST((head)); \ + (var) && ((tvar) = TAILQ_NEXT((var), field), 1); \ + (var) = (tvar)) +#endif + #define NUM_HOST_CPUS RTE_MAX_LCORE @@ -404,4 +411,5 @@ dpaa2_create_dpio_device(int vdev_fd, { struct dpaa2_dpio_dev *dpio_dev = NULL; + struct dpaa2_dpio_dev *dpio_tmp; struct vfio_region_info reg_info = { .argsz = sizeof(reg_info)}; struct qbman_swp_desc p_des; @@ -589,5 +597,5 @@ err: /* For each element in the list, cleanup */ - TAILQ_FOREACH(dpio_dev, &dpio_dev_list, next) { + TAILQ_FOREACH_SAFE(dpio_dev, &dpio_dev_list, next, dpio_tmp) { if (dpio_dev->dpio) { dpio_disable(dpio_dev->dpio, CMD_PRI_LOW, -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:12.898276654 +0100 +++ 0052-bus-fslmc-fix-use-after-free.patch 2025-07-18 20:29:10.933860847 +0100 @@ -1 +1 @@ -From 1cad17c43079268d9e15db62b3a1edd42df8d81e Mon Sep 17 00:00:00 2001 +From bbb4e92be549046a558d90eaeea2439a1e5b6ea1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1cad17c43079268d9e15db62b3a1edd42df8d81e ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index bad25a0ec2..e32471d8b5 100644 +index 2dfcf7a498..bc03b4dd05 100644 @@ -23 +24 @@ -@@ -40,4 +40,11 @@ +@@ -39,4 +39,11 @@ @@ -35 +36 @@ -@@ -413,4 +420,5 @@ dpaa2_create_dpio_device(int vdev_fd, +@@ -404,4 +411,5 @@ dpaa2_create_dpio_device(int vdev_fd, @@ -41 +42 @@ -@@ -598,5 +606,5 @@ err: +@@ -589,5 +597,5 @@ err: