From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAD8D46BAE for ; Fri, 18 Jul 2025 21:35:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4B2E40611; Fri, 18 Jul 2025 21:35:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 262CF40B8F for ; Fri, 18 Jul 2025 21:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VW86FG2K6JPLg1oU/OPwriv5x9JLcorRBXV8wdqk9yI=; b=E5znyRYd4x/vn/ilewK/pCOk3Nm1FhWtPd3O84fre9lOKNQGwp5IyF4MsQ/OEkAVQVvHl4 fv99PT+R5yiBxeHta2fKh06MCAqLp2uvZ+7aObGsQIFGU7bWZP3CeU7An3Mf2LTnE9pc6Z s46YFAHpWInYXh16FMP8GDrUPleH1f0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-OlEJP5fCO3uBk6E3VZKYhQ-1; Fri, 18 Jul 2025 15:34:57 -0400 X-MC-Unique: OlEJP5fCO3uBk6E3VZKYhQ-1 X-Mimecast-MFC-AGG-ID: OlEJP5fCO3uBk6E3VZKYhQ_1752867296 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97DEE19560A2; Fri, 18 Jul 2025 19:34:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 58DEB180045B; Fri, 18 Jul 2025 19:34:55 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: dpdk stable Subject: patch 'app/testpmd: fix flow random item token' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:52 +0100 Message-ID: <20250718193247.1008129-58-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k3vV-ljH7sNwA1oZJeSZkgsSvXJp1oM51kkuplvNc0E_1752867296 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9449422de54736cb72098da745b37f05e8e33e1e Thanks. Kevin --- >From 9449422de54736cb72098da745b37f05e8e33e1e Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Mon, 19 May 2025 09:30:45 +0300 Subject: [PATCH] app/testpmd: fix flow random item token [ upstream commit 9a18070e3fe43cd45fc5f000452853a0a45d25c2 ] ITEM_RANDOM_VALUE token initializes 32 bits mask argument value from a constant source buffer. Testpmd initiated the mast value from the 3 bytes buffer - [0xff, 0xff, 0x00]. When testpmd copied that value to 32 bits mask it accessed a memory byte outside the source buffer. The patch fixes the source buffer size. Fixes: 738ef8f7c706 ("ethdev: add flow item for random matching") Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 835fc3690d..eb26333759 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -5583,5 +5583,5 @@ static const struct token token_list[] = { item_param), .args = ARGS(ARGS_ENTRY_MASK(struct rte_flow_item_random, - value, "\xff\xff")), + value, "\x00\x00\xff\xff")), }, [ITEM_GRE_KEY] = { -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.093392747 +0100 +++ 0058-app-testpmd-fix-flow-random-item-token.patch 2025-07-18 20:29:10.954907405 +0100 @@ -1 +1 @@ -From 9a18070e3fe43cd45fc5f000452853a0a45d25c2 Mon Sep 17 00:00:00 2001 +From 9449422de54736cb72098da745b37f05e8e33e1e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9a18070e3fe43cd45fc5f000452853a0a45d25c2 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 998527590f..fc807ad8cf 100644 +index 835fc3690d..eb26333759 100644 @@ -28 +29 @@ -@@ -5592,5 +5592,5 @@ static const struct token token_list[] = { +@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {