From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93AFF46BAE for ; Fri, 18 Jul 2025 21:35:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F5FC40E41; Fri, 18 Jul 2025 21:35:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3492C40E41 for ; Fri, 18 Jul 2025 21:35:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E97EnxEs/gqTDYya3HysHYYarGl+FsJB51FdI06R/b4=; b=g2Y0qCMKZgmAsroOUeBQ+HXQpZQtZdPSQB+Jiy0YgynLG+fn0QNPKWFh3m5rnyNMJjZ6HP HmNdzOTa1VOuWnZGQfiordJAlyj97nMky/fQKG7qPhInxU4UhuqWnhFW6sIXN2PbYCPKxL vtIzjpotStbdXRUtbQ/Jeac/8RIcyaM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-Zx_zXJIYNI2Vw6Dt5l1nuw-1; Fri, 18 Jul 2025 15:34:59 -0400 X-MC-Unique: Zx_zXJIYNI2Vw6Dt5l1nuw-1 X-Mimecast-MFC-AGG-ID: Zx_zXJIYNI2Vw6Dt5l1nuw_1752867298 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 713D919560B4; Fri, 18 Jul 2025 19:34:58 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 35680180045B; Fri, 18 Jul 2025 19:34:56 +0000 (UTC) From: Kevin Traynor To: Long Li Cc: dpdk stable Subject: patch 'net/mana: check vendor ID when probing RDMA device' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:53 +0100 Message-ID: <20250718193247.1008129-59-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hezn5h2rGJBbAYimIpj1qfLmD9GY7_IC5NVfsOxZKYQ_1752867298 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/90b684d7a0fbe29a8aa5b91c39bb8729ed5d5c24 Thanks. Kevin --- >From 90b684d7a0fbe29a8aa5b91c39bb8729ed5d5c24 Mon Sep 17 00:00:00 2001 From: Long Li Date: Mon, 12 May 2025 14:52:02 -0700 Subject: [PATCH] net/mana: check vendor ID when probing RDMA device [ upstream commit be4ed96378811e572860cac558bff54b5c361992 ] The RDMA kernel driver may expose two MANA RDMA devices, for RC and RAW QP types. The purpose is to support fast service mode at SOC. Depending on kernel version, the probe may fail if DPDK picks up the wrong device. Add check for vendor_part_id and RAW QP capability when probing the MANA device. This check is compatible with all kernel versions. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Signed-off-by: Long Li --- drivers/net/mana/mana.c | 14 ++++++++++++++ drivers/net/mana/mana.h | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 2934da29f7..c42a987a30 100644 --- a/drivers/net/mana/mana.c +++ b/drivers/net/mana/mana.c @@ -1491,4 +1491,18 @@ mana_pci_probe_mac(struct rte_pci_device *pci_dev, } + if (dev_attr.orig_attr.vendor_part_id) { + if (dev_attr.orig_attr.vendor_part_id != + GDMA_DEVICE_MANA) { + DRV_LOG(INFO, "Skip device vendor part id %x", + dev_attr.orig_attr.vendor_part_id); + continue; + } + if (!dev_attr.raw_packet_caps) { + DRV_LOG(INFO, + "Skip device without RAW support"); + continue; + } + } + for (port = 1; port <= dev_attr.orig_attr.phys_port_cnt; port++) { diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 855d98911b..6309cae76b 100644 --- a/drivers/net/mana/mana.h +++ b/drivers/net/mana/mana.h @@ -13,4 +13,8 @@ struct mana_shared_data { }; +/* vendor_part_id returned from ibv_query_device */ +#define GDMA_DEVICE_MANA 2 +#define GDMA_DEVICE_MANA_IB 3 + #define MANA_MAX_MTU 9000 #define MIN_RX_BUF_SIZE 1024 -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.131148102 +0100 +++ 0059-net-mana-check-vendor-ID-when-probing-RDMA-device.patch 2025-07-18 20:29:10.955907408 +0100 @@ -1 +1 @@ -From be4ed96378811e572860cac558bff54b5c361992 Mon Sep 17 00:00:00 2001 +From 90b684d7a0fbe29a8aa5b91c39bb8729ed5d5c24 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit be4ed96378811e572860cac558bff54b5c361992 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org