From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00D346BAE for ; Fri, 18 Jul 2025 21:35:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9B0440E30; Fri, 18 Jul 2025 21:35:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7251640611 for ; Fri, 18 Jul 2025 21:35:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIif2+wtsHmRwvZ0vg9Jt04hL6t16kIBfi2XM6NZt54=; b=aWAUiOJJm3hAX1xJXlxtTCEkpgdHHNmwDu0PN8eBp4tDE1Y4o30eYLNBtYS7F0BMjk6Wpj PQlyQTdUHjnwAvOVbonVb7+8aJLeYBKIvL4p4DLXAuYQCxViRIv9HWT/wUXsWVuNL78V7Q PUVn5YZaVyc3SHCs361N2UdotlCagKQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172--41OhmyLOXyv1D7nZEPoNQ-1; Fri, 18 Jul 2025 15:35:02 -0400 X-MC-Unique: -41OhmyLOXyv1D7nZEPoNQ-1 X-Mimecast-MFC-AGG-ID: -41OhmyLOXyv1D7nZEPoNQ_1752867301 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ADAB018002A2; Fri, 18 Jul 2025 19:35:00 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B4FF180045B; Fri, 18 Jul 2025 19:34:58 +0000 (UTC) From: Kevin Traynor To: Danylo Vodopianov Cc: dpdk stable Subject: patch 'net/ntnic: avoid divide by zero' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:54 +0100 Message-ID: <20250718193247.1008129-60-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wI9hym2B1oacjR2fkOD9OzJFOutxE17zBZI5IuHDIu8_1752867301 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cc5b54d0d2c07c676771ed09e74322f6512e6cc1 Thanks. Kevin --- >From cc5b54d0d2c07c676771ed09e74322f6512e6cc1 Mon Sep 17 00:00:00 2001 From: Danylo Vodopianov Date: Mon, 5 May 2025 09:13:01 +0200 Subject: [PATCH] net/ntnic: avoid divide by zero [ upstream commit 8bbae3e37cf309e8ffc5292bf9d41c44a217f7f1 ] Fix CID issue 457736 divide by 0. It was avoided by adding adittional checking on the return value for function. Fixes: effa04693274 ("net/ntnic: add statistics") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/stat/nthw_stat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ntnic/nthw/stat/nthw_stat.c b/drivers/net/ntnic/nthw/stat/nthw_stat.c index b0db7b1984..d3e9225e58 100644 --- a/drivers/net/ntnic/nthw/stat/nthw_stat.c +++ b/drivers/net/ntnic/nthw/stat/nthw_stat.c @@ -319,4 +319,8 @@ int nthw_stat_init(nthw_stat_t *p, nthw_fpga_t *p_fpga, int n_instance) if (p->mp_fld_load_bin) { uint32_t rpp = nthw_fpga_get_product_param(p_fpga, NT_RPP_PER_PS, 0); + if (rpp == 0) { + NT_LOG(ERR, NTHW, "RPP has wrong value"); /* Avoid divide by 0 */ + return -1; + } uint32_t bin = (uint32_t)(((PORT_LOAD_WINDOWS_SIZE * 1000000000000ULL) / (32ULL * rpp)) - -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.162673752 +0100 +++ 0060-net-ntnic-avoid-divide-by-zero.patch 2025-07-18 20:29:10.956907411 +0100 @@ -1 +1 @@ -From 8bbae3e37cf309e8ffc5292bf9d41c44a217f7f1 Mon Sep 17 00:00:00 2001 +From cc5b54d0d2c07c676771ed09e74322f6512e6cc1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8bbae3e37cf309e8ffc5292bf9d41c44a217f7f1 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 2ddef052a5..9bb97bf311 100644 +index b0db7b1984..d3e9225e58 100644 @@ -22 +23 @@ -@@ -320,4 +320,8 @@ int nthw_stat_init(nthw_stat_t *p, nthw_fpga_t *p_fpga, int n_instance) +@@ -319,4 +319,8 @@ int nthw_stat_init(nthw_stat_t *p, nthw_fpga_t *p_fpga, int n_instance)