From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6A1546BAE for ; Fri, 18 Jul 2025 21:35:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDF2940B8F; Fri, 18 Jul 2025 21:35:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 252BF40E2E for ; Fri, 18 Jul 2025 21:35:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wctRuboMjQ1Y6YQ+QpwcqBN7R7M8FfY3wHxOXZc4zxI=; b=hkNtWoOJVGg3JiEC9rLbLbfh5LEbg1fSkVIlLXLSwWa2vAAq4YiQ4Xyik754LMKwzfbIIV JK3nzAH+xd3zAaxdVN/DyCcRvH7hAjQYlmu7qfZjjtLJ2aDoS0x6IzF8URfS4TOPbMa9q9 xMKRSNFVlbdKtl1w7EO5MnYO6s3E/qk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-tGJLhdU4PraI0o8rbcSDFA-1; Fri, 18 Jul 2025 15:35:03 -0400 X-MC-Unique: tGJLhdU4PraI0o8rbcSDFA-1 X-Mimecast-MFC-AGG-ID: tGJLhdU4PraI0o8rbcSDFA_1752867302 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A80C1956096; Fri, 18 Jul 2025 19:35:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3E9D118003FC; Fri, 18 Jul 2025 19:35:01 +0000 (UTC) From: Kevin Traynor To: Danylo Vodopianov Cc: dpdk stable Subject: patch 'net/ntnic: fix ring queue operation' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:55 +0100 Message-ID: <20250718193247.1008129-61-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4cxD_-mhyUbo42_4LTljaIpJMtkFZpmGURgAnBMcspM_1752867302 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8 Thanks. Kevin --- >From cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8 Mon Sep 17 00:00:00 2001 From: Danylo Vodopianov Date: Mon, 5 May 2025 09:13:06 +0200 Subject: [PATCH] net/ntnic: fix ring queue operation [ upstream commit 13b59c07d6827e3cd7f746997b97fcffb5992435 ] User should call rte_ring_dequeue_zc_elem_finish to complete the dequeue operation. However this complete step if record absent. This change rework queue read operation. Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling") Signed-off-by: Danylo Vodopianov --- .../profile_inline/flow_api_profile_inline.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c index ff8eb502f4..5325657551 100644 --- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c +++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c @@ -404,16 +404,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt, { read_record r = flm_lrn_queue_get_read_buffer(flm_lrn_queue_arr); + uint32_t handled_records = 0; if (r.num) { - uint32_t handled_records = 0; - - if (hw_mod_flm_lrn_data_set_flush(&dev->ndev->be, HW_FLM_FLOW_LRN_DATA, r.p, r.num, - &handled_records, inf_word_cnt, sta_word_cnt)) { + if (hw_mod_flm_lrn_data_set_flush(&dev->ndev->be, HW_FLM_FLOW_LRN_DATA, r.p, + r.num, &handled_records, inf_word_cnt, sta_word_cnt)) NT_LOG(ERR, FILTER, "Flow programming failed"); - - } else if (handled_records > 0) { - flm_lrn_queue_release_read_buffer(flm_lrn_queue_arr, handled_records); - } } + flm_lrn_queue_release_read_buffer(flm_lrn_queue_arr, handled_records); return r.num; -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.192578837 +0100 +++ 0061-net-ntnic-fix-ring-queue-operation.patch 2025-07-18 20:29:10.959907420 +0100 @@ -1 +1 @@ -From 13b59c07d6827e3cd7f746997b97fcffb5992435 Mon Sep 17 00:00:00 2001 +From cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 13b59c07d6827e3cd7f746997b97fcffb5992435 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index cb6a66a061..f78c6fbf49 100644 +index ff8eb502f4..5325657551 100644 @@ -23 +24 @@ -@@ -399,16 +399,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt, +@@ -404,16 +404,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt,