From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A28446BAE for ; Fri, 18 Jul 2025 21:33:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85BA140611; Fri, 18 Jul 2025 21:33:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 77B3E40611 for ; Fri, 18 Jul 2025 21:33:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4j9uhQkuVjXtXCErU81tCmzIjhYlHTXX/O84f8PXfY=; b=D1uMNzy4QBSYJjYNyIufBwCLnfsjXRMECNfQMpM3nBzbjo+Cynbl7GZ33bH0OVGmTbm4d/ zk7sQG8ps7rAXZZZyVOvhYmP4vn2Hi2LtefX6IIijuFedLOBdsMbxAnyQoH0iD3owGjSUQ vlhbFlsACqtYFV2e6tLZIhy9ZbXbuco= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-TmwHFasNPBWRsmaCuTF54g-1; Fri, 18 Jul 2025 15:33:11 -0400 X-MC-Unique: TmwHFasNPBWRsmaCuTF54g-1 X-Mimecast-MFC-AGG-ID: TmwHFasNPBWRsmaCuTF54g_1752867190 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B36771956088; Fri, 18 Jul 2025 19:33:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2AE5A180045B; Fri, 18 Jul 2025 19:33:08 +0000 (UTC) From: Kevin Traynor To: Yang Ming Cc: Stephen Hemminger , dpdk stable Subject: patch 'eal/linux: improve ASLR check' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:29:01 +0100 Message-ID: <20250718193247.1008129-7-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NsigKvgwAIZF52xQz5UZnNCknZnRmP_7xWHUxgReh4M_1752867190 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9d88498a1cf3abf2460b03ba691e6f8d32dd5a3d Thanks. Kevin --- >From 9d88498a1cf3abf2460b03ba691e6f8d32dd5a3d Mon Sep 17 00:00:00 2001 From: Yang Ming Date: Thu, 13 Mar 2025 14:19:03 +0800 Subject: [PATCH] eal/linux: improve ASLR check [ upstream commit dcf9f9363aa9b4163d241caf8b26a84ca0c0006b ] This change ensures that the current process is checked for being run with 'setarch' before verifying the value of '/proc/sys/kernel/randomize_va_space'. The '-R' or '--addr-no-randomize' parameter of the 'setarch' command is used to disable the randomization of the virtual address space. Fixes: af75078fece3 ("first public release") Signed-off-by: Yang Ming Acked-by: Stephen Hemminger --- lib/eal/linux/eal_memory.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 9dda60c0e1..5ef1575b66 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -16,4 +16,5 @@ #include #include +#include #include #include @@ -201,4 +202,15 @@ aslr_enabled(void) { char c; + + /* + * Check whether the current process is executed with the command line + * "setarch ... --addr-no-randomize ..." or "setarch ... -R ..." + * This complements the sysfs check to ensure comprehensive ASLR status detection. + * This check is necessary to support the functionality of the "setarch" command, + * which can disable ASLR by setting the ADDR_NO_RANDOMIZE personality flag. + */ + if ((personality(0xffffffff) & ADDR_NO_RANDOMIZE) == ADDR_NO_RANDOMIZE) + return 0; + int retval, fd = open(RANDOMIZE_VA_SPACE_FILE, O_RDONLY); if (fd < 0) -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:11.410768838 +0100 +++ 0007-eal-linux-improve-ASLR-check.patch 2025-07-18 20:29:10.808906957 +0100 @@ -1 +1 @@ -From dcf9f9363aa9b4163d241caf8b26a84ca0c0006b Mon Sep 17 00:00:00 2001 +From 9d88498a1cf3abf2460b03ba691e6f8d32dd5a3d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dcf9f9363aa9b4163d241caf8b26a84ca0c0006b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 8c896379fe..7f03bb517b 100644 +index 9dda60c0e1..5ef1575b66 100644 @@ -31 +32 @@ -@@ -204,4 +205,15 @@ aslr_enabled(void) +@@ -201,4 +202,15 @@ aslr_enabled(void)