From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D8DE46BAE for ; Fri, 18 Jul 2025 21:35:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98D2640611; Fri, 18 Jul 2025 21:35:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C4B4D40E2E for ; Fri, 18 Jul 2025 21:35:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+6j17Rze+Pszb51Q2yJl0TC5OUmxKCKNzVA4gzff/fk=; b=IAUkIxiArjkvFl0nxwQTN/whVUtmJH5vRPwiMBuyoF2/sihn+1IUbDipefBKSLuv7lAElx r4+Vq59CW97hgtCE85obb9ISaUJ0Qq/xvFFFmFALii66HxNSzpBJUobgc6sZ+mN+vLDnxu AuxyJOicRt6KahqBlKJSmtrrM4VfgvQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-e4sUYuhZOk-0fdhpas4bnw-1; Fri, 18 Jul 2025 15:35:27 -0400 X-MC-Unique: e4sUYuhZOk-0fdhpas4bnw-1 X-Mimecast-MFC-AGG-ID: e4sUYuhZOk-0fdhpas4bnw_1752867326 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97CA71956089; Fri, 18 Jul 2025 19:35:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 729DA180045B; Fri, 18 Jul 2025 19:35:25 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: dpdk stable Subject: patch 'ethdev: fix error struct in flow configure' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:07 +0100 Message-ID: <20250718193247.1008129-73-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HLZX8Vre3o4LDi5flCcG4RUfDLQljPl5TwboLDFpvA0_1752867326 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e743b62f364744bdeeb256a14fda31523c72291c Thanks. Kevin --- >From e743b62f364744bdeeb256a14fda31523c72291c Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Thu, 29 May 2025 08:56:10 +0300 Subject: [PATCH] ethdev: fix error struct in flow configure [ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ] rte_flow_configure() returned error value w/o filling the error struct which caused a crash on complain function. Filling the error struct fixed the issue. Fixes: 4ff58b734bc9 ("ethdev: introduce flow engine configuration") Signed-off-by: Maayan Kashani --- lib/ethdev/rte_flow.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 4a7735b5ab..9a14242965 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1694,5 +1694,5 @@ rte_flow_configure(uint16_t port_id, "Device with port_id=%"PRIu16" is not configured.", port_id); - return -EINVAL; + goto error; } if (dev->data->dev_started != 0) { @@ -1700,13 +1700,13 @@ rte_flow_configure(uint16_t port_id, "Device with port_id=%"PRIu16" already started.", port_id); - return -EINVAL; + goto error; } if (port_attr == NULL) { FLOW_LOG(ERR, "Port %"PRIu16" info is NULL.", port_id); - return -EINVAL; + goto error; } if (queue_attr == NULL) { FLOW_LOG(ERR, "Port %"PRIu16" queue info is NULL.", port_id); - return -EINVAL; + goto error; } if ((port_attr->flags & RTE_FLOW_PORT_FLAG_SHARE_INDIRECT) && @@ -1729,4 +1729,8 @@ rte_flow_configure(uint16_t port_id, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, rte_strerror(ENOTSUP)); +error: + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, rte_strerror(EINVAL)); } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.573770473 +0100 +++ 0073-ethdev-fix-error-struct-in-flow-configure.patch 2025-07-18 20:29:10.973907463 +0100 @@ -1 +1 @@ -From af7ac22d8da82398065d5f3c799c17a7cec3a6af Mon Sep 17 00:00:00 2001 +From e743b62f364744bdeeb256a14fda31523c72291c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit af7ac22d8da82398065d5f3c799c17a7cec3a6af ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 9f8d8f3dc2..fe8f43caff 100644 +index 4a7735b5ab..9a14242965 100644 @@ -23 +24 @@ -@@ -1726,5 +1726,5 @@ rte_flow_configure(uint16_t port_id, +@@ -1694,5 +1694,5 @@ rte_flow_configure(uint16_t port_id, @@ -30 +31 @@ -@@ -1732,13 +1732,13 @@ rte_flow_configure(uint16_t port_id, +@@ -1700,13 +1700,13 @@ rte_flow_configure(uint16_t port_id, @@ -47 +48 @@ -@@ -1761,4 +1761,8 @@ rte_flow_configure(uint16_t port_id, +@@ -1729,4 +1729,8 @@ rte_flow_configure(uint16_t port_id,