From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1344546BAE for ; Fri, 18 Jul 2025 21:35:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E01B40E4D; Fri, 18 Jul 2025 21:35:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DB63A40E4D for ; Fri, 18 Jul 2025 21:35:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tqMxUVMc0I8xGK4jYVUYuYX62I0mXT1FEjmGz+xVyOo=; b=E/+v0FAXi6pdqUgswLqxkrrWDswLfOQ3a5S2j/W8ez6w7awF8ypIF8vBsDRHvtdRh5P3B0 lBlWTAWXE3PZn9qR4G70meVi+bRR9N8gYTCgnEiLc1zmd06ARqZYSzUcryOhZjRWj3gZ/M 4IMZQ+dWyAGSh1Tp8rJ8KbPd0v0E6As= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-TU5EWM7TO7qZvkGaJaVatQ-1; Fri, 18 Jul 2025 15:35:48 -0400 X-MC-Unique: TU5EWM7TO7qZvkGaJaVatQ-1 X-Mimecast-MFC-AGG-ID: TU5EWM7TO7qZvkGaJaVatQ_1752867347 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 245A61955F65; Fri, 18 Jul 2025 19:35:47 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8651C18003FC; Fri, 18 Jul 2025 19:35:45 +0000 (UTC) From: Kevin Traynor To: Radu Nicolau Cc: Akhil Goyal , dpdk stable Subject: patch 'crypto/virtio: fix driver cleanup' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:17 +0100 Message-ID: <20250718193247.1008129-83-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2aO3errRFjqIR07sGiwKgP2-HWfmWxYGGhlfp4hZCJk_1752867347 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b626ee594ce8a046af1ebb6f24183575cd8919d5 Thanks. Kevin --- >From b626ee594ce8a046af1ebb6f24183575cd8919d5 Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 29 May 2025 11:45:53 +0000 Subject: [PATCH] crypto/virtio: fix driver cleanup [ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] Improper cleanup resulted in a segfault when more than 1 device was used Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- drivers/crypto/virtio/virtio_cryptodev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c index b4a6fae9e0..034a479994 100644 --- a/drivers/crypto/virtio/virtio_cryptodev.c +++ b/drivers/crypto/virtio/virtio_cryptodev.c @@ -779,6 +779,5 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) cryptodev->dequeue_burst = NULL; - rte_free(cryptodev->data); - cryptodev->data = NULL; + rte_cryptodev_pmd_release_device(cryptodev); VIRTIO_CRYPTO_DRV_LOG_INFO("dev_uninit completed"); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.901646530 +0100 +++ 0083-crypto-virtio-fix-driver-cleanup.patch 2025-07-18 20:29:10.988907509 +0100 @@ -1 +1 @@ -From 6adb7f4ae156341958463db80951d8f528932e9f Mon Sep 17 00:00:00 2001 +From b626ee594ce8a046af1ebb6f24183575cd8919d5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index f591cf0c7a..299898e585 100644 +index b4a6fae9e0..034a479994 100644 @@ -22 +23 @@ -@@ -626,6 +626,5 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) +@@ -779,6 +779,5 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev)