From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3759D46BAE for ; Fri, 18 Jul 2025 21:35:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 304EA40E7C; Fri, 18 Jul 2025 21:35:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BB6D540611 for ; Fri, 18 Jul 2025 21:35:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WgjZsjJc4ix/6Tycq/35zWBbemCDfrvL7rGBpPtX+U8=; b=OqdgEFYmdkguaizt0CcksUisx9lUouA2agbXYEWUbyvJHJvXhtOtVHnd5A/IcKNphqWB+a agt86Yi59vcFvawOTGYZE2vpWlwzVJIRVtziimY1kdZSWFYDJ/AhwNz5+TGtcOBmkZBldE UiSe1cympNClKjoEcSBFyvj3g1CtOAE= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-xnq1g_8fOJOKiO_VRfLLDQ-1; Fri, 18 Jul 2025 15:35:50 -0400 X-MC-Unique: xnq1g_8fOJOKiO_VRfLLDQ-1 X-Mimecast-MFC-AGG-ID: xnq1g_8fOJOKiO_VRfLLDQ_1752867350 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BABAF1956063; Fri, 18 Jul 2025 19:35:49 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C249018003FC; Fri, 18 Jul 2025 19:35:47 +0000 (UTC) From: Kevin Traynor To: Pavan Nikhilesh Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , dpdk stable Subject: patch 'eal: fix return value of lcore role' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:18 +0100 Message-ID: <20250718193247.1008129-84-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8vZ4iE9Fz4zLAmIvPHB6e1_em5xbGXxbZynxwdpcE9w_1752867350 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4cf7ad1d4188a27e94da43ef59fd07bfce7c2bbe Thanks. Kevin --- >From 4cf7ad1d4188a27e94da43ef59fd07bfce7c2bbe Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Wed, 21 May 2025 01:47:26 +0530 Subject: [PATCH] eal: fix return value of lcore role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] Update rte_lcore_has_role() to return false instead of a negative value for invalid lcore IDs, removing the need for callers to pre-validate the ID. Fixes: b0a1502a277c ("eal: make semantics of lcore role function more intuitive") Suggested-by: Morten Brørup Signed-off-by: Pavan Nikhilesh Reviewed-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/common/eal_common_lcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 820a6534b1..10a523b8fa 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common/eal_common_lcore.c @@ -80,5 +80,5 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) if (lcore_id >= RTE_MAX_LCORE) - return -EINVAL; + return 0; return cfg->lcore_role[lcore_id] == role; -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.932537491 +0100 +++ 0084-eal-fix-return-value-of-lcore-role.patch 2025-07-18 20:29:10.989748243 +0100 @@ -1 +1 @@ -From 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde Mon Sep 17 00:00:00 2001 +From 4cf7ad1d4188a27e94da43ef59fd07bfce7c2bbe Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 294267177d..9dd6c72055 100644 +index 820a6534b1..10a523b8fa 100644 @@ -28 +29 @@ -@@ -88,5 +88,5 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) +@@ -80,5 +80,5 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)