From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DF9C46BAE for ; Fri, 18 Jul 2025 21:35:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 784E340611; Fri, 18 Jul 2025 21:35:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 13A7240E4D for ; Fri, 18 Jul 2025 21:35:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+FufBTPWp4uc1XwMlO6GjOmLylABM88z610jiFkd7Fk=; b=TwGdCrRT9SP3PiGluS6CfGg78sRYBqnyPrPPXaw5T7E69cEQ0K0D/avfcLJ9koqsjMekz+ jn9nAQ02xbIRBWHx2n3/pD83iYh5pc3ipntvrBgKphhfwb0kDf4s0wFJamduI9Y9Ou/zig rg01MbIeSb93pYjQY3sUil5gb11jKgo= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-y4bUCUPmMtSKl_40Thcvpg-1; Fri, 18 Jul 2025 15:35:52 -0400 X-MC-Unique: y4bUCUPmMtSKl_40Thcvpg-1 X-Mimecast-MFC-AGG-ID: y4bUCUPmMtSKl_40Thcvpg_1752867351 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBE741800872; Fri, 18 Jul 2025 19:35:51 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 57EF018003FC; Fri, 18 Jul 2025 19:35:50 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Anatoly Burakov , dpdk stable Subject: patch 'eal: warn if no lcore is available' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:19 +0100 Message-ID: <20250718193247.1008129-85-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -IDIBa74RDL_dDBJEHCs_sC80ybTHdn3Ku2yiIY0oXU_1752867351 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/466f5576ce8812c2d726e3e1f48cc19f8f8fb6ae Thanks. Kevin --- >From 466f5576ce8812c2d726e3e1f48cc19f8f8fb6ae Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 8 May 2025 07:19:15 +0200 Subject: [PATCH] eal: warn if no lcore is available [ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] On systems with more cpu than RTE_MAX_LCORE, starting DPDK with cores >= RTE_MAX_LCORE ends up with an ambiguous error log. Example with RTE_MAX_LCORE=8: $ taskset -c 8 ./build/app/dpdk-testpmd EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Invalid 'command line' arguments. EAL: Error - exiting with code: 1 Cannot init EAL: Invalid argument Add a better hint to help the user. Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") Signed-off-by: David Marchand Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_options.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 79db9a47dd..5811de130e 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -2050,4 +2050,9 @@ eal_adjust_config(struct internal_config *internal_cfg) eal_auto_detect_cores(cfg); + if (cfg->lcore_count == 0) { + EAL_LOG(ERR, "No detected lcore is enabled, please check the core list"); + return -1; + } + if (internal_conf->process_type == RTE_PROC_AUTO) internal_conf->process_type = eal_proc_type_detect(); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.962552935 +0100 +++ 0085-eal-warn-if-no-lcore-is-available.patch 2025-07-18 20:29:10.989907512 +0100 @@ -1 +1 @@ -From 2ea1d30dc938866a983156473579d10bddb4951e Mon Sep 17 00:00:00 2001 +From 466f5576ce8812c2d726e3e1f48cc19f8f8fb6ae Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index b6fff7ec05..b194d0ee06 100644 +index 79db9a47dd..5811de130e 100644 @@ -32 +33 @@ -@@ -2053,4 +2053,9 @@ eal_adjust_config(struct internal_config *internal_cfg) +@@ -2050,4 +2050,9 @@ eal_adjust_config(struct internal_config *internal_cfg)