From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1C7646BAE for ; Fri, 18 Jul 2025 21:35:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BC4940611; Fri, 18 Jul 2025 21:35:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2E7D740ECF for ; Fri, 18 Jul 2025 21:35:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6+dkdB39agjOLVOFWNceA1s0rZa18CF793OvO+Lt60=; b=YjBWIGcNvrkqxNoBi3Oo0zibp27J0suE7pzra2+65sNO26t9+c21yYflAA/zIAhfETKysv cBGbAlmWVOJcvQ/00eg7bBfU6jeJviqer+BiyP69Gnju8IWykG9WiFukNKFmvA3jCsivJG tUtUMtiITUrUbrY8S9YFxF1biAMbTO8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-UJq5cLTaO0mWG-BEPMeKvQ-1; Fri, 18 Jul 2025 15:35:54 -0400 X-MC-Unique: UJq5cLTaO0mWG-BEPMeKvQ-1 X-Mimecast-MFC-AGG-ID: UJq5cLTaO0mWG-BEPMeKvQ_1752867354 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1AF6D180028C for ; Fri, 18 Jul 2025 19:35:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ECF31180049D; Fri, 18 Jul 2025 19:35:52 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: dpdk stable Subject: patch 'test/lcore: fix race in per-lcore test' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:20 +0100 Message-ID: <20250718193247.1008129-86-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TFtsfXLu2wE8TdlQO2eVX0AuZ0TZeWNuEzFTE1esBpQ_1752867354 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d522170814a9150569920a82e73ec916e96d7ced Thanks. Kevin --- >From d522170814a9150569920a82e73ec916e96d7ced Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 17 Mar 2025 15:30:15 +0100 Subject: [PATCH] test/lcore: fix race in per-lcore test [ upstream commit 7c37826c2b87966f3b11b2c74dc720fcc1e0e6f5 ] In some CI, this unit test can fail, as the main thread may get rescheduled while lcores execute the callback waiting 100ms. Bugzilla ID: 1668 Fixes: af75078fece3 ("first public release") Signed-off-by: David Marchand --- app/test/test_per_lcore.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/app/test/test_per_lcore.c b/app/test/test_per_lcore.c index 63c5c80c24..9c72f0fa21 100644 --- a/app/test/test_per_lcore.c +++ b/app/test/test_per_lcore.c @@ -60,9 +60,20 @@ display_vars(__rte_unused void *arg) static int -test_per_lcore_delay(__rte_unused void *arg) +test_per_lcore_delay(void *arg) { + RTE_ATOMIC(bool) *wait; + rte_delay_ms(100); printf("wait 100ms on lcore %u\n", rte_lcore_id()); + if (arg == NULL) + return 0; + + wait = arg; + while (rte_atomic_load_explicit(wait, rte_memory_order_relaxed)) { + rte_delay_ms(100); + printf("wait 100ms on lcore %u\n", rte_lcore_id()); + } + return 0; } @@ -71,4 +82,5 @@ static int test_per_lcore(void) { + RTE_ATOMIC(bool) wait = true; unsigned lcore_id; int ret; @@ -87,5 +99,5 @@ test_per_lcore(void) /* test if it could do remote launch twice at the same time or not */ - ret = rte_eal_mp_remote_launch(test_per_lcore_delay, NULL, SKIP_MAIN); + ret = rte_eal_mp_remote_launch(test_per_lcore_delay, &wait, SKIP_MAIN); if (ret < 0) { printf("It fails to do remote launch but it should able to do\n"); @@ -98,4 +110,5 @@ test_per_lcore(void) return -1; } + rte_atomic_store_explicit(&wait, false, rte_memory_order_relaxed); RTE_LCORE_FOREACH_WORKER(lcore_id) { if (rte_eal_wait_lcore(lcore_id) < 0) -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:13.992821197 +0100 +++ 0086-test-lcore-fix-race-in-per-lcore-test.patch 2025-07-18 20:29:10.990907515 +0100 @@ -1 +1 @@ -From 7c37826c2b87966f3b11b2c74dc720fcc1e0e6f5 Mon Sep 17 00:00:00 2001 +From d522170814a9150569920a82e73ec916e96d7ced Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7c37826c2b87966f3b11b2c74dc720fcc1e0e6f5 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org